Page MenuHomePhabricator
Create Task
Maniphest T360709

Make PHP 8.2 voting on development (master) branch of Math extension
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php82-noselenium-docker/360/consoleFull

00:02:33.277 There were 648 errors:
00:02:33.278 
00:02:33.278 1) MediaWiki\Extension\Math\Tests\WikiTexVC\AllTest::testRunCases with data set "Box functions" (array('\text {-0-9a-zA-Z+*,=():/;?.!... €-ÿ} ', '{\text{-0-9a-zA-Z+*,=():/;?.!... €-ÿ}}'))
00:02:33.278 Creation of dynamic property MediaWiki\Extension\Math\WikiTexVC\Parser::$tu is deprecated

Details

SubjectRepoBranchLines +/-
Zuul: [mediawiki/extensions/Math] Re-enable PHP 8.2 CI votingintegration/configmaster+8 -121
Declare properties staticallymediawiki/extensions/MathREL1_40+7 -2
Declare properties staticallymediawiki/extensions/MathREL1_41+7 -2
Declare properties staticallymediawiki/extensions/MathREL1_39+9 K -0
Declare properties staticallymediawiki/extensions/Mathmaster+7 -2
Zuul: [mediawiki/extensions/MathSearch] Disable PHP 8.2 testing for nowintegration/configmaster+6 -2
Zuul: [mediawiki/extensions/Math] Disable PHP 8.2 testing for nowintegration/configmaster+6 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Mar 21 2024, 8:10 PM
Jdforrester-WMF moved this task from Backlog to Wikimedia production on the PHP 8.2 support board.
gerritbot added a comment.Mar 21 2024, 8:16 PM

Change #1013399 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/Math] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1013399

gerritbot added a project: Patch-For-Review.Mar 21 2024, 8:16 PM
gerritbot added a comment.Mar 21 2024, 8:19 PM

Change #1013399 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/Math] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1013399

Stashbot added a comment.Mar 21 2024, 8:20 PM

Mentioned in SAL (#wikimedia-releng) [2024-03-21T20:20:03Z] <James_F> Zuul: [mediawiki/extensions/Math] Disable PHP 8.2 testing for now, for T360709

Physikerwelt subscribed.Mar 24 2024, 2:22 PM

@Jdforrester-WMF did we eventually drop support for PHP7. If so this might be easy to fix, by upgrading the library that generates the code that produces the errors.

Jdforrester-WMF added a comment.Mar 25 2024, 11:43 AM
In T360709#9656333, @Physikerwelt wrote:

@Jdforrester-WMF did we eventually drop support for PHP7. If so this might be easy to fix, by upgrading the library that generates the code that produces the errors.

Dropping official PHP 7.4 support (and PHP 8.0 support) is happening from the REL1_42 branch, but CI will still enforce PHP 7.4 compatibility until Wikimedia production migrates to PHP 8.1.

Physikerwelt added a comment.Mar 25 2024, 1:17 PM

Ok. Do you think it is good enough to wait until then? If so we can maybe make this task a subtask of the migration of production migration task.

gerritbot added a comment.Mar 27 2024, 4:06 PM

Change #1015079 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[integration/config@master] Zuul: [mediawiki/extensions/MathSearch] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1015079

gerritbot added a comment.Mar 28 2024, 8:31 PM

Change #1015079 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/MathSearch] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1015079

Physikerwelt added a comment.Sat, Apr 6, 7:46 AM

The only problem I see locally is the problem with dynamic property creation T314099.

gerritbot added a comment.Sat, Apr 6, 7:57 AM

Change #1017425 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Declare properties statically

https://gerrit.wikimedia.org/r/1017425

Umherirrender subscribed.Sat, Apr 6, 10:52 AM

Math depends on Wikibase T360560: Make PHP 8.2 voting on development branch of Wikibase

As Wikibase fails in step 2 of 3 (first is unit test, second "PHPUnit extensions suite (without database or standalone)" and third "PHPUnit extensions suite (with database)") is not proofed on CI that everything would run, but that is still a risk for all the Wikibase dependency.

After math runs so far, the comments in zuul config could be changed to point to Wikibase.

Physikerwelt added a comment.Sat, Apr 6, 10:56 AM

That makes perfect sense, as I don't run wikibase tests locally.

Reedy updated the task description. (Show Details)Sat, Apr 6, 9:05 PM
gerritbot added a comment.Sat, Apr 6, 9:29 PM

Change #1017425 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Declare properties statically

https://gerrit.wikimedia.org/r/1017425

gerritbot added a comment.Sat, Apr 6, 9:31 PM

Change #1017474 had a related patch set uploaded (by Reedy; author: Physikerwelt):

[mediawiki/extensions/Math@REL1_41] Declare properties statically

https://gerrit.wikimedia.org/r/1017474

gerritbot added a comment.Sat, Apr 6, 9:33 PM

Change #1017475 had a related patch set uploaded (by Reedy; author: Physikerwelt):

[mediawiki/extensions/Math@REL1_40] Declare properties statically

https://gerrit.wikimedia.org/r/1017475

gerritbot added a comment.Sat, Apr 6, 9:33 PM

Change #1017476 had a related patch set uploaded (by Reedy; author: Physikerwelt):

[mediawiki/extensions/Math@REL1_39] Declare properties statically

https://gerrit.wikimedia.org/r/1017476

gerritbot added a comment.Sat, Apr 6, 9:34 PM

Change #1017476 abandoned by Reedy:

[mediawiki/extensions/Math@REL1_39] Declare properties statically

Reason:

https://gerrit.wikimedia.org/r/1017476

gerritbot added a comment.Sat, Apr 6, 9:59 PM

Change #1017474 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_41] Declare properties statically

https://gerrit.wikimedia.org/r/1017474

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Sat, Apr 6, 10:00 PM
gerritbot added a comment.Sat, Apr 6, 10:03 PM

Change #1017475 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_40] Declare properties statically

https://gerrit.wikimedia.org/r/1017475

gerritbot added a comment.Fri, Apr 26, 6:49 PM

Change #1024786 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/Math] Re-enable PHP 8.2 CI voting

https://gerrit.wikimedia.org/r/1024786

gerritbot added a comment.Fri, Apr 26, 6:53 PM

Change #1024786 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/Math] Re-enable PHP 8.2 CI voting

https://gerrit.wikimedia.org/r/1024786

Stashbot added a comment.Fri, Apr 26, 6:55 PM

Mentioned in SAL (#wikimedia-releng) [2024-04-26T18:55:19Z] <James_F> Zuul: [mediawiki/extensions/Math] Re-enable PHP 8.2 CI voting for T360709

Jdforrester-WMF closed this task as Resolved.Fri, Apr 26, 6:55 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF mentioned this in T352085: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries).
Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 7:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL