Page MenuHomePhabricator

Make PHP 8.2 voting on development (master) branch of Math extension
Open, Needs TriagePublic

Description

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php82-noselenium-docker/360/consoleFull

00:02:33.277 There were 648 errors:
00:02:33.278 
00:02:33.278 1) MediaWiki\Extension\Math\Tests\WikiTexVC\AllTest::testRunCases with data set "Box functions" (array('\text {-0-9a-zA-Z+*,=():/;?.!... €-ÿ} ', '{\text{-0-9a-zA-Z+*,=():/;?.!... €-ÿ}}'))
00:02:33.278 Creation of dynamic property MediaWiki\Extension\Math\WikiTexVC\Parser::$tu is deprecated

Event Timeline

Change #1013399 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/Math] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1013399

Change #1013399 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/Math] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1013399

Mentioned in SAL (#wikimedia-releng) [2024-03-21T20:20:03Z] <James_F> Zuul: [mediawiki/extensions/Math] Disable PHP 8.2 testing for now, for T360709

@Jdforrester-WMF did we eventually drop support for PHP7. If so this might be easy to fix, by upgrading the library that generates the code that produces the errors.

@Jdforrester-WMF did we eventually drop support for PHP7. If so this might be easy to fix, by upgrading the library that generates the code that produces the errors.

Dropping official PHP 7.4 support (and PHP 8.0 support) is happening from the REL1_42 branch, but CI will still enforce PHP 7.4 compatibility until Wikimedia production migrates to PHP 8.1.

Ok. Do you think it is good enough to wait until then? If so we can maybe make this task a subtask of the migration of production migration task.

Change #1015079 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[integration/config@master] Zuul: [mediawiki/extensions/MathSearch] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1015079

Change #1015079 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/MathSearch] Disable PHP 8.2 testing for now

https://gerrit.wikimedia.org/r/1015079

The only problem I see locally is the problem with dynamic property creation T314099.

Change #1017425 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Declare properties statically

https://gerrit.wikimedia.org/r/1017425

Math depends on Wikibase T360560: Make PHP 8.2 voting on development branch of Wikibase

As Wikibase fails in step 2 of 3 (first is unit test, second "PHPUnit extensions suite (without database or standalone)" and third "PHPUnit extensions suite (with database)") is not proofed on CI that everything would run, but that is still a risk for all the Wikibase dependency.

After math runs so far, the comments in zuul config could be changed to point to Wikibase.

That makes perfect sense, as I don't run wikibase tests locally.

Change #1017425 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Declare properties statically

https://gerrit.wikimedia.org/r/1017425

Change #1017474 had a related patch set uploaded (by Reedy; author: Physikerwelt):

[mediawiki/extensions/Math@REL1_41] Declare properties statically

https://gerrit.wikimedia.org/r/1017474

Change #1017475 had a related patch set uploaded (by Reedy; author: Physikerwelt):

[mediawiki/extensions/Math@REL1_40] Declare properties statically

https://gerrit.wikimedia.org/r/1017475

Change #1017476 had a related patch set uploaded (by Reedy; author: Physikerwelt):

[mediawiki/extensions/Math@REL1_39] Declare properties statically

https://gerrit.wikimedia.org/r/1017476

Change #1017476 abandoned by Reedy:

[mediawiki/extensions/Math@REL1_39] Declare properties statically

Reason:

https://gerrit.wikimedia.org/r/1017476

Change #1017474 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_41] Declare properties statically

https://gerrit.wikimedia.org/r/1017474

Change #1017475 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_40] Declare properties statically

https://gerrit.wikimedia.org/r/1017475