WikimediaMessages becoming a dumping ground for "common" code
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Reedy
	Mar 26 2024, 7:08 PM

Description

The extension describes itself as Wikimedia specific messages.

The longer version from the README.md

The WikimediaMessages extension adds Wikimedia-specific internationalisation messages and grammar, as well as Wikimedia-specific overrides for license and other legal-related messages.

It's unclear why various JS, CSS and LESS are making their way into the extension...

Maybe the scope of the extension is purposefully changing, and it's more than "Messages"; it's WMF "common" code, and renaming the extension isn't worth the effort (as we've seen in numerous other cases). But that doesn't mean the documentation in the repo, where in WikimediaMessages and at https://www.mediawiki.org/wiki/Extension:WikimediaMessages can't be updated.

Details

	Subject	Repo	Branch	Lines +/-
	Remove orphaned feedback-blue.svg images	mediawiki/extensions/WikimediaMessages	master	+0 -8

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T361044 WikimediaMessages becoming a dumping ground for "common" code
Resolved	Dreamy_Jazz	T364213 Remove feedback link on Special:Investigate
Resolved	Dreamy_Jazz	T362538 Disable or redirect the feedback link for the IP Info infobox
Resolved	Dreamy_Jazz	T217451 Remove RCFilters Guided Tours

Event Timeline

Reedy created this task.Mar 26 2024, 7:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2024, 7:08 PM

Reedy updated the task description. (Show Details)Mar 26 2024, 7:10 PM

The work I know of has been due to trying to find a home for hacks.less CSS/LESS currently living in Minerva skin repository. T358071 (As I have suggested I think in the community discussion subtask, I think MF is the appropriate place for hacks, but that was only true for the mobile-related hacks, rather than the dark-theme hacks now also being added in hacks.less.)

I do not know of other cases.

There's some ContactPage stuff... There's some IPInfo stuff... There's some RCFilters stuff...

rEWMEa4a3b5bd8416: Add a link for feedback about the IPInfo feature from March 2022

rEWME04f58c33a5aa: RCFilters: Add introduction tour when RCFilters comes out of beta from September 2017

rEWME5bd503b579eb: Add a request for feedback on proposed changes to SpecialBlock. from July 2018, apparently "temporary" - T194301: Introduce temporary element on Special:Block UI to invite users to participate in the Partial Block consultation

rEWMEe650606e4eb1: RCFilters: Add guided tour for Watchlist, with instant opt-out from June 2018

rEWME996d7a8c529b: RC filters: highlight guided tour from April 2017

Pretty much everything in the modules folder:

.
├── ext.wikimediaMessages.ipInfo.hooks
│   ├── infobox.js
│   └── infobox.less
├── ext.wikimediamessages.contactpage
│   ├── affcomchapthorg.css
│   └── affcomusergroup.css
├── images
│   ├── feedback-blue-ltr.svg
│   ├── feedback-blue-rtl.svg
│   ├── highlight-tour-ltr.svg
│   ├── highlight-tour-rtl.svg
│   ├── rc-beta-tour-welcome-ltr.gif
│   ├── rc-beta-tour-welcome-rtl.gif
│   └── rc-intro-tour-preferences.svg
├── mediawiki.special.block.feedback.request.less
├── rcfilters-highlight-tour-hooks.js
├── rcfilters-highlight-tour.js
├── rcfilters-highlight-tour.less
├── rcfilters-intro-tour.js
├── rcfilters-intro-tour.less
└── wlfilters-intro-tour.js

4 directories, 18 files

Much of it is unclear how long it needs to be here for. Is it still used? Does anyone still care about it?

Change #1014675 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/WikimediaMessages@master] Remove orphaned feedback-blue.svg images

https://gerrit.wikimedia.org/r/1014675

gerritbot added a project: Patch-For-Review.Mar 27 2024, 1:56 AM

And still seeming orphaned over 5 years ago, that is still sitting around...

Change #1014675 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Remove orphaned feedback-blue.svg images

https://gerrit.wikimedia.org/r/1014675

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mar 27 2024, 3:00 AM

Reedy removed a project: Patch-For-Review.Mar 27 2024, 3:36 PM

Reedy mentioned this in T361716: Remove block feedback link.Apr 3 2024, 3:44 PM

Trust and Safety Product Team have a few feedback links in there (blocks and IPInfo mentioned above). Is there a better way for adding WMF-specific feedback links?

Some of our feedback links have been there for a long time (FAO @Niharika), so another solution might be to limit the length of time they're there, though that wouldn't solve this task.

Change #1027102 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaMessages@master] Remove feedback link for Special:Investigate

https://gerrit.wikimedia.org/r/1027102

gerritbot added a project: Patch-For-Review.Sat, May 4, 12:32 PM

Dreamy_Jazz added a subtask: T364213: Remove feedback link on Special:Investigate.Sat, May 4, 12:33 PM

Dreamy_Jazz added a subtask: T362538: Disable or redirect the feedback link for the IP Info infobox.Sat, May 4, 12:36 PM

Dreamy_Jazz mentioned this in T217451: Remove RCFilters Guided Tours.Sat, May 4, 2:49 PM

Dreamy_Jazz added a subtask: T217451: Remove RCFilters Guided Tours.

Etonkovidova closed subtask T217451: Remove RCFilters Guided Tours as Resolved.Mon, May 6, 8:18 PM

Pppery removed a project: Patch-For-Review.Thu, May 9, 2:13 AM

Quiddity subscribed.Fri, May 10, 12:22 AM

Dreamy_Jazz closed subtask T364213: Remove feedback link on Special:Investigate as Resolved.Mon, May 13, 9:17 AM