Page MenuHomePhabricator

Content overflow guidelines: include them in Codex
Closed, ResolvedPublic3 Estimated Story Points

Description

Background

In T359636: Define an approach to content overflow in Codex components we defined the approach to content overflow for Codex components and we documented these decisions in these Content overflow guidelines.

This task is to include these guidelines in the Codex site.

Acceptance criteria (or Done)

  • Review guidelines with the DST
  • Include guidelines in Codex

Event Timeline

Catrope set the point value for this task to 3.May 13 2024, 6:07 PM

Change #1031422 had a related patch set uploaded (by Bmartinezcalvo; author: Bmartinezcalvo):

[design/codex@main] docs: include "Content overflow" guidelines

https://gerrit.wikimedia.org/r/1031422

Thanks for the quick turnover @bmartinezcalvo
Repeating from patch for general visibility:

I feel like content overflow is more a visual style belonging to Typography or even better “Layout guidelines” than being such important overarching design principle.

El T364611#9796892, @Volker_E escribió:

Repeating from patch for general visibility:

I feel like content overflow is more a visual style belonging to Typography or even better “Layout guidelines” than being such important overarching design principle.

Regarding the navigation of this new "Content overflow" section, there are 2 possible options:

Captura de pantalla 2024-05-17 a las 13.23.11.png (1×2 px, 428 KB)
Captura de pantalla 2024-05-17 a las 13.28.07.png (1×2 px, 436 KB)
Op.1: Within the "Design Principles" section.Op.2: Within the "Layout Guidelines" section.

I lean towards Op.1 since this content-overflow approach it's not just a design recommendation but it will be implemented in all the Codex components.

In case we go with Op.2, I would include this "Content overflow" section in the first position to avoid confusions with the next "Content" section below.

@DTorsani-WMF @mwilliams @Volker_E @Sarai-WMDE what do you think?

I would vote for option 2, as content overflow feels less like a design principle and more like a guideline.

Ok, since it seems there is a slight agreement on Op.2, let's go with that option. Thank you!

Change #1031422 merged by jenkins-bot:

[design/codex@main] docs: include "Content overflow" guidelines

https://gerrit.wikimedia.org/r/1031422

Change #1034529 had a related patch set uploaded (by Bmartinezcalvo; author: Bmartinezcalvo):

[design/codex@main] docs: fix image in the fade don't example

https://gerrit.wikimedia.org/r/1034529

Change #1034529 merged by jenkins-bot:

[design/codex@main] docs: fix image in the fade don't example

https://gerrit.wikimedia.org/r/1034529

Change #1037103 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v1.6.0 to v1.6.1

https://gerrit.wikimedia.org/r/1037103

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/ce0a74a0e6/w

Change #1037103 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.6.0 to v1.6.1

https://gerrit.wikimedia.org/r/1037103

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/ce0a74a0e6/w/