Page MenuHomePhabricator
Create Task
Maniphest T364783

Large amount of errors in animateToolbarIntoView function in VisualEditor
Closed, ResolvedPublicBUG REPORT
Actions

Description

Web team have been getting paged about a spike in errors which seems related to this series of error.

https://logstash.wikimedia.org/goto/9a6499efdda161e6ed1a973f68fd0949

183,623 errors in the last 7 day commencing since 8th May 2024 inside the function animateToolbarIntoView

  • TypeError: Cannot read properties of undefined (reading '$el')
  • TypeError: undefined is not an object (evaluating 'this.overlay.$el')
  • TypeError: Cannot read property '$el' of undefined
  • TypeError: this.overlay is undefined
  • TypeError: Cannot read properties of undefined (reading 'getBoundingClientRect')
  • TypeError: can't access property "$el", this.overlay is undefined
  • TypeError: $header[0] is undefined

Details

SubjectRepoBranchLines +/-
Convert function to arrow function to fix contextmediawiki/extensions/VisualEditorwmf/1.43.0-wmf.4+1 -1
Convert function to arrow function to fix contextmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.May 13 2024, 8:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2024, 8:33 PM
Jdlrobson updated the task description. (Show Details)May 13 2024, 8:33 PM
Jdlrobson added a parent task: T361399: 1.43.0-wmf.5 deployment blockers.
Jdlrobson added a comment.May 13 2024, 8:36 PM

I've added this as a deployment blocker since the increase in errors caused by it is significant and meets the criteria of https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Error-rate_increases_(See_#Logspam)

Screenshot 2024-05-13 at 1.35.21 PM.png (282×1 px, 34 KB)

Jdlrobson triaged this task as Unbreak Now! priority.May 13 2024, 8:36 PM
Jdlrobson mentioned this in T364517: New Client Error `TypeError: undefined is not an object (evaluating 'a.L')`.May 13 2024, 8:48 PM
Aklapper added a project: Editing-team.May 13 2024, 9:14 PM
Aklapper added a subscriber: Esanders.

+ Editing-team because train blocker

Jdlrobson added a comment.May 13 2024, 9:21 PM

Caused by eb757c4c9f

gerritbot added a comment.May 13 2024, 9:33 PM

Change #1031088 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Convert function to arrow function to fix context

https://gerrit.wikimedia.org/r/1031088

gerritbot added a project: Patch-For-Review.May 13 2024, 9:33 PM
gerritbot added a comment.May 13 2024, 10:07 PM

Change #1031088 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Convert function to arrow function to fix context

https://gerrit.wikimedia.org/r/1031088

Maintenance_bot removed a project: Patch-For-Review.May 13 2024, 10:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 13 2024, 11:00 PM
hashar subscribed.May 14 2024, 9:51 AM

I have tried to cherry pick the patch https://gerrit.wikimedia.org/r/1031088 from master to wmf/1.43.0-wmf.5 using Gerrit Cherry pick button but unfortunately it is reported as conflicting with that branch. Can you take care of the backport please?

Aklapper added a comment.EditedMay 14 2024, 10:00 AM

In my understanding, https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/VisualEditor/+/2615070b42914f97b0e2a7682a058ea97e49331c seems to have been both merged into https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/VisualEditor/+log/refs/heads/master and https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/VisualEditor/+log/refs/heads/wmf/1.43.0-wmf.5 ?
If there's no further work to be done, could this ticket be resolved?

Aklapper assigned this task to Esanders.May 14 2024, 10:18 AM
gerritbot added a comment.May 14 2024, 1:09 PM

Change #1031180 had a related patch set uploaded (by Jforrester; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.43.0-wmf.4] Convert function to arrow function to fix context

https://gerrit.wikimedia.org/r/1031180

gerritbot added a project: Patch-For-Review.May 14 2024, 1:09 PM
Jdforrester-WMF subscribed.May 14 2024, 1:10 PM
In T364783#9793716, @hashar wrote:

I have tried to cherry pick the patch https://gerrit.wikimedia.org/r/1031088 from master to wmf/1.43.0-wmf.5 using Gerrit Cherry pick button but unfortunately it is reported as conflicting with that branch. Can you take care of the backport please?

It already landed in wmf.5; the remaining part of this task is about back-porting it to wmf.4. It's not a current train blocker.

hashar removed a parent task: T361399: 1.43.0-wmf.5 deployment blockers.May 14 2024, 1:23 PM

I guess it should have blocked last week train so :)

gerritbot added a comment.May 14 2024, 3:57 PM

Change #1031180 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.43.0-wmf.4] Convert function to arrow function to fix context

https://gerrit.wikimedia.org/r/1031180

Stashbot mentioned this in T363779: [Bug] Echo not compatible with desktop night theme.May 14 2024, 3:58 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-14T15:58:16Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap: Backport for [[gerrit:1030984|Add notheme class to Echo (T363779)]], [[gerrit:1031180|Convert function to arrow function to fix context (T364783)]]

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.4; 2024-05-07); removed MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 14 2024, 4:00 PM
Stashbot added a comment.May 14 2024, 4:05 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-14T16:05:33Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 jdlrobson and jforrester and lucaswerkmeister-wmde: Backport for [[gerrit:1030984|Add notheme class to Echo (T363779)]], [[gerrit:1031180|Convert function to arrow function to fix context (T364783)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.May 14 2024, 4:21 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-14T16:21:00Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1030984|Add notheme class to Echo (T363779)]], [[gerrit:1031180|Convert function to arrow function to fix context (T364783)]] (duration: 22m 43s)

ppelberg subscribed.May 14 2024, 4:23 PM
Maintenance_bot removed a project: Patch-For-Review.May 14 2024, 4:30 PM
SToyofuku-WMF subscribed.May 14 2024, 4:40 PM
Jdlrobson closed this task as Resolved.May 14 2024, 8:03 PM

Thanks for the quick response here:

Screenshot 2024-05-14 at 1.03.25 PM.png (522×3 px, 124 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL