Page MenuHomePhabricator
Create Task
Maniphest T365403

CentralAuthApiSessionProviderTest::testUserScriptsDisabled is failing in CI
Closed, ResolvedPublic
Actions

Description

Similar to T353512. Seen in the GlobalBlocking extension. Seems to be caused by the MediaWiki-extensions-WikimediaEvents extension.

23:26:36 1) CentralAuthApiSessionProviderTest::testUserScriptsDisabled
23:26:36 MediaWiki\Session\Session::getUser(): MediaWiki\User\User was not expected to be called.
23:26:36 
23:26:36 /workspace/src/extensions/WikimediaEvents/includes/WikimediaEventsHooks.php:106
23:26:36 /workspace/src/includes/HookContainer/HookContainer.php:159
23:26:36 /workspace/src/includes/HookContainer/HookRunner.php:945
23:26:36 /workspace/src/includes/Output/OutputPage.php:3010
23:26:36 /workspace/src/extensions/CentralAuth/tests/phpunit/CentralAuthTokenSessionProviderTestBase.php:339
23:26:36 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium/12729/console

Details

SubjectRepoBranchLines +/-
Mock Session::getUser in ::testUserScriptsDisabledmediawiki/extensions/CentralAuthmaster+2 -1
Mock Session::getUser in ::testUserScriptsDisabledmediawiki/extensions/CentralAuthwmf/1.43.0-wmf.6+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Dreamy_Jazz created this task.May 20 2024, 10:41 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMay 20 2024, 10:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Dreamy_Jazz updated the task description. (Show Details)May 20 2024, 10:41 PM
Dreamy_Jazz added a comment.May 20 2024, 10:49 PM

This was caused by cdf546e7aa9171f17706874f9bcfe2e146f7aeb4 being merged.

gerritbot added a comment.May 20 2024, 10:55 PM

Change #1034190 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] Mock Session::getUser in ::testUserScriptsDisabled

https://gerrit.wikimedia.org/r/1034190

gerritbot added a project: Patch-For-Review.May 20 2024, 10:55 PM
Dreamy_Jazz claimed this task.May 20 2024, 10:56 PM
Dreamy_Jazz triaged this task as Unbreak Now! priority.
Dreamy_Jazz added a subscriber: Urbanecm_WMF.
SToyofuku-WMF mentioned this in T363935: Replace $wgMFUseParsoid configuration flag with Parsoid API.May 20 2024, 11:43 PM
SToyofuku-WMF subscribed.
MusikAnimal subscribed.May 21 2024, 6:29 AM
gerritbot added a comment.May 21 2024, 7:40 AM

Change #1034190 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Mock Session::getUser in ::testUserScriptsDisabled

https://gerrit.wikimedia.org/r/1034190

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 21 2024, 8:00 AM
Tgr mentioned this in T333541: Add CentralAuth to gated extensions.May 21 2024, 8:02 AM
Tgr closed this task as Resolved.May 21 2024, 8:05 AM
Tgr subscribed.

Thanks @Dreamy_Jazz!

gerritbot added a comment.May 21 2024, 8:20 AM

Change #1034174 had a related patch set uploaded (by Gergő Tisza; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.6] Mock Session::getUser in ::testUserScriptsDisabled

https://gerrit.wikimedia.org/r/1034174

gerritbot added a comment.May 21 2024, 8:32 AM

Change #1034174 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.6] Mock Session::getUser in ::testUserScriptsDisabled

https://gerrit.wikimedia.org/r/1034174

ArthurTaylor mentioned this in T365440: Test failure in Wikibase CI CentralAuthApiSessionProviderTest::testUserScriptsDisabled Session::getUser() was not expected to be called..May 21 2024, 8:54 AM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.6; 2024-05-21); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 21 2024, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 21 2024, 9:30 AM
Dreamy_Jazz merged a task: T365440: Test failure in Wikibase CI CentralAuthApiSessionProviderTest::testUserScriptsDisabled Session::getUser() was not expected to be called..May 21 2024, 9:43 AM
Dreamy_Jazz added subscribers: ArthurTaylor, WMDE-leszek.
Lucas_Werkmeister_WMDE mentioned this in T365705: ApiUploadVideoTest::testUploadVideoFiles fails in Wikibase CI (AccountCreationLogger: Error: Call to a member function getDBkey() on null).May 23 2024, 1:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits