Page MenuHomePhabricator

Evaluate temp user banner in RTL contexts
Open, Needs TriagePublic

Description

In a recent meeting, @Ladsgroup noted that the temp user banner design created in T330510: IP masking: Make temporary account status and create account actions more prominent via a separate temp account status bar did not seem "correct" in right-to-left language context.

This task exists to:

  • Allow for input from folks about the banner as it appears in RTL contexts
  • Collect discussion and actionable follow-ups

Event Timeline

@Ladsgroup can you please add comments with observations you have about what doesn't seem correct about the temp user banner design in RTL context? Thank you.

I want to put a screenshot but beta cluster is down

I want to put a screenshot but beta cluster is down

If you want to set it up in your local environment, $wgAutoCreateTempUser['enabled'] = true; in LocalSettings.php should be enough.

grafik.png (745×1 px, 95 KB)

It's not too annoying to me but since start of the sentence is at the middle of the page, it feels wrong to me as a native speaker, specially since the counter is in latin digits (in Persian and some other languages the digits are different e.g. instead of 0 it's ۰, 1 -> ۱, 2 -> ۲, etc.) and generally numbers are read left to right even in Persian.

grafik.png (745×1 px, 95 KB)

It's not too annoying to me but since start of the sentence is at the middle of the page, it feels wrong to me as a native speaker, specially since the counter is in latin digits (in Persian and some other languages the digits are different e.g. instead of 0 it's ۰, 1 -> ۱, 2 -> ۲, etc.) and generally numbers are read left to right even in Persian.

Thanks @Ladsgroup. Do you have a proposal for what might feel more correct? (It's ok if not, just thought I'd ask.)

I prefer it to start from the right. i.e. start of the page (which would be left in LTR languages). The buttons can stay at the end of the page but text feels wrong to stay like this.

@KColeman-WMF could you take a look at this task from a design perspective please?

I think I know why it feels wrong. In English, every time something is right aligned, you know it's intentional but in RTL languages there has been so many issues with text that supposed to be right aligned being put on the left side that when you see a left aligned text, the immediate reaction is "oh that's another RTL bug"

Adding @ovasileva and @RHo as their team worked on this piece.

A few comments:

I tried enabling it on my local installation by adding $wgAutoCreateTempUser['enabled'] = true;, but it doesn't seem to work. I'd love to test it, but I can't do it on any Wikimedia site because this can only work for users who try to edit while they aren't logged-in, and my whole ISP is blocked from non-logged-in editing, so I cannot even try to edit.

I guess that it's the left corner of the screen in RTL because that's the username usually is, at least in Vector 2022, Vector, and Monobook. (I hope that it works well in other skins, come to think of it.) If that's the intention, then it should probably stay in the left corner for RTL.

@Ladsgroup's comment about digits made me think about a few more things, which are not really about the banner, but they are about temporary accounts and RTL. In order of importance:

  1. It kind of sucks that the tilde will always be on the other side in RTL sides. Is it totally set in stone by now that it will be a tilde? I wrote a much longer comment about it on https://www.mediawiki.org/wiki/Talk:Trust_and_Safety_Product/Temporary_Accounts
  2. The digits shouldn't be converted, even in languages in which there is conversion, like Persian. Q page titles in Wikidata are not converted, for example. Or, if they are converted, it should be super-easy for developers to ensure that they are converted everywhere consistently. But since this is probably too complicated to be perfectly consistent, they probably shouldn't be converted at all.
  3. In the N'Ko language (nqo.wikipedia.org), the native digits go from right to left. But since they probably shouldn't be converted to native digits (see previous point), it doesn't matter.

I prefer it to start from the right. i.e. start of the page (which would be left in LTR languages). The buttons can stay at the end of the page but text feels wrong to stay like this.

This is how it would look if we split the temp account name out from the log in/create buttons:

rtl-banner.png (789×1 px, 146 KB)

I am not sure that this works for LTR languages.

@Ladsgroup I talked to the design team about this and it makes sense to keep the temp account text and buttons together. However we can float them right for both LTR and RTL. Does this solve some of the issues?

rtl-banner-2.png (807×1 px, 148 KB)

Hi, It looks good with the new design, some other thing that can be done on the top is to move the buttons (only on RTL wikis and only the buttons, nothing else) to the left side so it would be on top of "user buttons" but not a big deal IMO.

Thanks @Ladsgroup. I can see why you are suggesting moving the buttons to sit on top of the user buttons. I will take it to design review and see what folks think.

@Ladsgroup I talked to the design team about this and it makes sense to keep the temp account text and buttons together. However we can float them right for both LTR and RTL.

Please don't. Everything else on the MediaWiki platform is on the opposite sides in RTL and LTR, unless there's a very specific reason for an exception, and there is no such reason here.

To me, it makes perfect sense to put it on the right in LTR and on the left in RTL, because that's where the username and the "log in" / "log out" buttons are (in Monobook and in both versions of Vector; I don't strongly care about other skins).