Page MenuHomePhabricator
Create Task
Maniphest T365794

[ES-M2] Split EntitySchemaValueParser into parser and deserializer
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

EntitySchemaValueParser is currently handling calls from wbformatvalue and from wbparsevalue, by detected whether its input is a string or an array. This works, but it is an uncomfortable workaround for the fact that we are not able to register independent parsers and deserializers for datatypes with the new datatype registration mechanism.

Acceptance Criteria

  • Split EntitySchemaValueParser into two classes that reflect the separate functions, or remove the TODO in the code

Details

SubjectRepoBranchLines +/-
Register EntitySchema value deserializermediawiki/extensions/EntitySchemamaster+86 -99
Don't conflate snak parsing and deserializingmediawiki/extensions/Wikibasemaster+284 -218
Add 'deserializer-builder' to DataTypeDefinitionsmediawiki/extensions/Wikibasemaster+108 -62
Add new DeserializerFactory constructor argmediawiki/extensions/WikibaseLexememaster+2 -0
Don't conflate snak parsing and deserializingmediawiki/extensions/Wikibasemaster+292 -226
Don't conflate snak parsing and deserializingmediawiki/extensions/Wikibasemaster+270 -226
Customize query in gerrit

Related Objects
Search...

Event Timeline

ArthurTaylor created this task.May 24 2024, 10:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2024, 10:12 AM
ArthurTaylor added a parent task: T362000: [ES-M2]: [EPIC] Continue development of PoC EntitySchema patch.May 24 2024, 10:12 AM
Maintenance_bot moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.May 24 2024, 10:29 AM
Maintenance_bot added a project: Wikidata.
Lucas_Werkmeister_WMDE subscribed.May 24 2024, 11:39 AM
ArthurTaylor removed a project: Wikidata Dev Team (Wikidata.org Slice).May 24 2024, 12:19 PM
Ifrahkhanyaree_WMDE added a project: Wikibase Product Platform Team WPP.Tue, May 28, 9:55 AM
Ifrahkhanyaree_WMDE moved this task from Incoming tickets outside WPP to Ready for planning on the Wikibase Product Platform Team WPP board.
Ifrahkhanyaree_WMDE set the point value for this task to 5.Tue, May 28, 10:03 AM
Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 21 on the Wikibase Product Platform Team WPP board.
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 21); removed Wikibase Product Platform Team WPP.
Ifrahkhanyaree_WMDE added a parent task: T354778: Build a solution in Wikibase for EntitySchemas to be returned with valuetype wikibase-entity.Wed, May 29, 8:21 AM
Jakob_WMDE claimed this task.Wed, May 29, 8:32 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 21) board.
gerritbot added a comment.Fri, May 31, 12:36 PM

Change #1037772 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Add 'deserializer-builder' to DataTypeDefinitions

https://gerrit.wikimedia.org/r/1037772

gerritbot added a project: Patch-For-Review.Fri, May 31, 12:36 PM
gerritbot added a comment.Fri, May 31, 3:40 PM

Change #1037817 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Don't conflate parsing and deserializing in SnakDeserializer

https://gerrit.wikimedia.org/r/1037817

gerritbot added a comment.Tue, Jun 4, 12:35 PM

Change #1038763 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseLexeme@master] Add new DeserializerFactory constructor arg

https://gerrit.wikimedia.org/r/1038763

gerritbot added a comment.Tue, Jun 4, 12:42 PM

Change #1038764 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Don't conflate snak parsing and deserializing

https://gerrit.wikimedia.org/r/1038764

gerritbot added a comment.Tue, Jun 4, 12:52 PM

Change #1038764 abandoned by Jakob:

[mediawiki/extensions/Wikibase@master] Don't conflate snak parsing and deserializing

Reason:

accidentally overwrote the change-id. oopsie.

https://gerrit.wikimedia.org/r/1038764

gerritbot added a comment.Tue, Jun 4, 1:35 PM

Change #1038780 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Don't conflate snak parsing and deserializing

https://gerrit.wikimedia.org/r/1038780

gerritbot added a comment.Tue, Jun 4, 1:41 PM

Change #1038784 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseLexeme@master] Add new DeserializerFactory constructor arg

https://gerrit.wikimedia.org/r/1038784

gerritbot added a comment.Tue, Jun 4, 1:44 PM

Change #1038780 abandoned by Jakob:

[mediawiki/extensions/Wikibase@master] Don't conflate snak parsing and deserializing

Reason:

successfully confused gerrit

https://gerrit.wikimedia.org/r/1038780

gerritbot added a comment.Wed, Jun 5, 12:22 PM

Change #1039203 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/EntitySchema@master] Register EntitySchema value deserializer

https://gerrit.wikimedia.org/r/1039203

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 21) board.Thu, Jun 6, 9:01 AM
gerritbot added a comment.Fri, Jun 7, 12:01 PM

Change #1038784 abandoned by Jakob:

[mediawiki/extensions/WikibaseLexeme@master] Add new DeserializerFactory constructor arg

Reason:

changed approach, no longer needed

https://gerrit.wikimedia.org/r/1038784

gerritbot added a comment.Fri, Jun 7, 2:05 PM

Change #1037772 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add 'deserializer-builder' to DataTypeDefinitions

https://gerrit.wikimedia.org/r/1037772

gerritbot added a comment.Fri, Jun 7, 2:26 PM

Change #1037817 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Don't conflate snak parsing and deserializing

https://gerrit.wikimedia.org/r/1037817

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Fri, Jun 7, 3:00 PM
gerritbot added a comment.Sun, Jun 9, 11:43 PM

Change #1039203 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Register EntitySchema value deserializer

https://gerrit.wikimedia.org/r/1039203

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 21) board.Mon, Jun 10, 8:03 AM
Dima_Koushha_WMDE removed a project: Patch-For-Review.Mon, Jun 10, 10:48 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Tue, Jun 11, 10:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL