Page MenuHomePhabricator

[Bug] Table of contents arrows are hiding
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?: The arrows to indicate dropdowns are hiding.

image.png (298×227 px, 7 KB)

What should have happened instead?: Need a color flip.

The element shouldn't be subject to a CSS invert like other icons. Likely needs a not selector.

Derived Requirement

Ensure that the table of contents arrows are visible and correctly styled in dark mode on the desktop.

BDD

Feature: Table of Contents Arrows Visibility in Dark Mode

Scenario: Ensure arrows in the table of contents are visible in dark mode

Given a user is viewing a Wikipedia page in dark mode on desktop
When the user expands or collapses sections in the table of contents
Then the arrows should be visible and correctly styled
Test Steps

Test Case 1: Ensure TOC Arrows are Visible in Dark Mode

  1. Visit a page on beta. For PROD in dark mode
  2. Switch to dark mode.
  3. Expand and collapse sections in the table of contents.
  4. AC1: Confirm that the arrows are visible and styled correctly in dark mode.

QA Results - Beta

ACStatusDetails
1T365951#9885251

Event Timeline

JScherer-WMF renamed this task from Table of contents arrows are hiding to [Bug] Table of contents arrows are hiding.Mon, May 27, 7:00 PM
JScherer-WMF added a project: Web-Team-Backlog.
NBaca-WMF set the point value for this task to 1.Tue, May 28, 4:56 PM

Change #1038910 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

https://gerrit.wikimedia.org/r/1038910

Jdlrobson raised the priority of this task from Medium to High.Tue, Jun 11, 6:27 PM

Change #1041787 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/Vector@master] Remove not selector and target OOUI icons for inversion only

https://gerrit.wikimedia.org/r/1041787

Change #1041787 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove not selector and target OOUI icons for inversion only

https://gerrit.wikimedia.org/r/1041787

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 125
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure TOC Arrows are Visible in Dark Mode

  1. Visit a page on beta. For PROD in dark mode
  2. Switch to dark mode.
  3. Expand and collapse sections in the table of contents.
  4. AC1: Confirm that the arrows are visible and styled correctly in dark mode.

2024-06-12_08-37-49.png (772×1 px, 277 KB)

GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF added a subscriber: Edtadros.

Looks good, resolving!

Change #1038910 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

Reason:

To be discussed with DST on Tuesday June 18th

https://gerrit.wikimedia.org/r/1038910