Page MenuHomePhabricator
Create Task
Maniphest T365580

Contribution icons provided by Special:ContentTranslation are not reverted in the dark mode
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Ladsgroup
May 22 2024, 11:32 AM
Project Tags
Referenced Files
F56716890: screenshot 7.png
Jul 27 2024, 3:02 AM
F55273556: 2024-06-12_16-30-21.png
Jun 12 2024, 11:36 PM
F54127439: grafik.png
May 22 2024, 11:32 AM
Subscribers
Aklapper
Edtadros
GMikesell-WMF
Jdlrobson
Ladsgroup
ovasileva
Quiddity
SToyofuku-WMF

Description

grafik.png (204×339 px, 14 KB)

"my translations" and "my file uploads" icons are still black in the dark mode.

Derived Requirement

Ensure that contribution icons provided by Special
are correctly inverted in dark mode.

BDD

Feature: Icon Visibility in Dark Mode

Scenario: Ensure contribution icons are visible in dark mode

Given a user is using Special:ContentTranslation in dark mode
When the user views the contribution icons
Then the icons should be correctly inverted and visible
Test Steps

Test Case 1: Ensure Contribution Icons are Visible in Dark Mode

  1. Open beta- https://en.wikipedia.beta.wmflabs.org/wiki/Lightsaber, PROD- https://en.wikipedia.org/wiki/Lightsaber
  2. Switch to dark mode in Appearances.
  3. Observe the contribution icons (e.g., "my translations", "my file uploads").
  4. AC1: Confirm that the icons are correctly inverted and visible in dark mode.

QA Results - Beta

ACStatusDetails
1✅T365580#9887044

QA Results - Prod

ACStatusDetails
1✅T365580#10020115

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove not selector and target OOUI icons for inversion onlyStoyofuku-wmfmediawiki/skins/Vectormaster+39 -3
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.May 22 2024, 11:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 22 2024, 11:32 AM
Jdlrobson renamed this task from Some icons in personal toolbar are not reverted in the dark mode to Contribution icons provided by Special:ContentTranslation are not reverted in the dark mode.May 23 2024, 12:55 AM
Jdlrobson edited projects, added: FY2023-24-WE 2.1 Typography and palette customizations, Language-Team, ContentTranslation; removed: Web-Team-Backlog-Archived.
Jdlrobson updated the task description. (Show Details)
• Nikerabbit triaged this task as Medium priority.May 23 2024, 8:28 AM
• Nikerabbit edited projects, added: Language-Team (Language-2024-April-June); removed: Language-Team.
• Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.
Jdlrobson mentioned this in T322740: Contribute entry point.May 23 2024, 8:32 PM
Jdlrobson moved this task from Backlog to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.May 24 2024, 9:30 PM
Jdlrobson merged a task: T365895: Icon fixes for supplementary vector user links.May 25 2024, 1:08 AM
Jdlrobson added a subscriber: Quiddity.
Jdlrobson mentioned this in T363780: [QA] Exploratory testing: Vector 2022 night theme.May 31 2024, 3:56 AM
Jdlrobson added a comment.May 31 2024, 3:13 PM

This should be addressed by T363920. We are playing whack-a-mole until then.

gerritbot added a comment.Jun 4 2024, 10:02 PM

Change #1038910 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Use mask-image for all Vector icons

https://gerrit.wikimedia.org/r/1038910

gerritbot added a project: Patch-For-Review.Jun 4 2024, 10:02 PM
Jdlrobson edited projects, added: Vector 2022; removed: Language-Team (Language-2024-April-June), ContentTranslation.Jun 6 2024, 6:42 PM

This is actually a web team bug.

Jdlrobson added a project: Web-Team-Backlog-Archived.Jun 6 2024, 6:42 PM
Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog-Archived board.Jun 7 2024, 4:25 PM
SToyofuku-WMF claimed this task.Jun 11 2024, 9:05 PM
SToyofuku-WMF subscribed.
gerritbot added a comment.Jun 11 2024, 9:58 PM

Change #1041787 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/Vector@master] Remove not selector and target OOUI icons for inversion only

https://gerrit.wikimedia.org/r/1041787

Jdlrobson set the point value for this task to 0.Jun 12 2024, 1:15 AM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5), Unplanned-Sprint-Work; removed: Web-Team-Backlog-Archived.

Should be fixed by T365951

Jdlrobson reassigned this task from SToyofuku-WMF to Edtadros.Jun 12 2024, 1:15 AM
Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5) board.
gerritbot added a comment.Jun 12 2024, 2:12 AM

Change #1041787 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove not selector and target OOUI icons for inversion only

https://gerrit.wikimedia.org/r/1041787

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.10; 2024-06-18).Jun 12 2024, 3:00 AM
GMikesell-WMF updated the task description. (Show Details)Jun 12 2024, 11:34 PM
GMikesell-WMF subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Contribution Icons are Visible in Dark Mode

  1. Open beta- https://en.wikipedia.beta.wmflabs.org/wiki/Lightsaber, PROD- https://en.wikipedia.org/wiki/Lightsaber
  2. Switch to dark mode in Appearances.
  3. Observe the contribution icons (e.g., "my translations", "my file uploads").
  4. AC1: Confirm that the icons are correctly inverted and visible in dark mode.

2024-06-12_16-30-21.png (2,349×372 px, 159 KB)

GMikesell-WMF removed Edtadros as the assignee of this task.Jun 12 2024, 11:36 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 5) board.
GMikesell-WMF added a subscriber: Edtadros.
Jdlrobson assigned this task to ovasileva.Jun 13 2024, 1:08 AM
ovasileva closed this task as Resolved.Jun 17 2024, 9:45 AM

Icons look good. Resolving!

gerritbot added a comment.Jun 17 2024, 11:24 PM

Change #1038910 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

Reason:

To be discussed with DST on Tuesday June 18th

https://gerrit.wikimedia.org/r/1038910

Maintenance_bot removed a project: Patch-For-Review.Jun 17 2024, 11:32 PM
Jdlrobson mentioned this in T367780: Verify 1.43.0-wmf.10 deployment.Jul 3 2024, 10:58 PM
gerritbot added a comment.Jul 9 2024, 9:40 PM

Change #1038910 restored by Jdlrobson:

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

https://gerrit.wikimedia.org/r/1038910

gerritbot added a project: Patch-For-Review.Jul 9 2024, 9:40 PM
Edtadros added a project: Verified.Jul 27 2024, 3:02 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Contribution Icons are Visible in Dark Mode

  1. Open beta- https://en.wikipedia.beta.wmflabs.org/wiki/Lightsaber, PROD- https://en.wikipedia.org/wiki/Lightsaber
  2. Switch to dark mode in Appearances.
  3. Observe the contribution icons (e.g., "my translations", "my file uploads").
  4. AC1: Confirm that the icons are correctly inverted and visible in dark mode.

screenshot 7.png (1,175×677 px, 229 KB)

Edtadros updated the task description. (Show Details)Jul 27 2024, 3:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits