Contribution icons provided by Special:ContentTranslation are not reverted in the dark mode
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To

Authored By

	Ladsgroup
	May 22 2024, 11:32 AM

Description

"my translations" and "my file uploads" icons are still black in the dark mode.

Derived Requirement

Ensure that contribution icons provided by Special
are correctly inverted in dark mode.

BDD

Feature: Icon Visibility in Dark Mode

Scenario: Ensure contribution icons are visible in dark mode

Given a user is using Special:ContentTranslation in dark mode
When the user views the contribution icons
Then the icons should be correctly inverted and visible

Test Steps

Test Case 1: Ensure Contribution Icons are Visible in Dark Mode

Open beta- https://en.wikipedia.beta.wmflabs.org/wiki/Lightsaber, PROD- https://en.wikipedia.org/wiki/Lightsaber
Switch to dark mode in Appearances.
Observe the contribution icons (e.g., "my translations", "my file uploads").
AC1: Confirm that the icons are correctly inverted and visible in dark mode.

QA Results - Beta

AC	Status	Details
1	✅	T365580#9887044

Details

	Subject	Repo	Branch	Lines +/-
	POC: Use mask-image for all Vector icons	mediawiki/skins/Vector	master	+15 -44
	Remove not selector and target OOUI icons for inversion only	mediawiki/skins/Vector	master	+39 -3

Customize query in gerrit

Related Objects

Mentioned In: T363780: [QA] Exploratory testing: Vector 2022 night theme
T322740: Contribute entry point
Mentioned Here: T365951: [Bug] Table of contents arrows are hiding
T363920: Migrate ResourceLoader Icons in Vector to use Codex

Event Timeline

Ladsgroup created this task.May 22 2024, 11:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 22 2024, 11:32 AM

Jdlrobson renamed this task from Some icons in personal toolbar are not reverted in the dark mode to Contribution icons provided by Special:ContentTranslation are not reverted in the dark mode.May 23 2024, 12:55 AM

Jdlrobson edited projects, added FY2023-24-WE 2.1 Typography and palette customizations, Language-Team, ContentTranslation; removed Web-Team-Backlog.

Jdlrobson updated the task description. (Show Details)

Nikerabbit triaged this task as Medium priority.May 23 2024, 8:28 AM

Nikerabbit edited projects, added Language-Team (Language-2024-April-June); removed Language-Team.

Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.

Jdlrobson mentioned this in T322740: Contribute entry point.May 23 2024, 8:32 PM

Jdlrobson moved this task from Backlog to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.May 24 2024, 9:30 PM

Jdlrobson merged a task: T365895: Icon fixes for supplementary vector user links.May 25 2024, 1:08 AM

Jdlrobson added a subscriber: Quiddity.

Jdlrobson mentioned this in T363780: [QA] Exploratory testing: Vector 2022 night theme.Fri, May 31, 3:56 AM

This should be addressed by T363920. We are playing whack-a-mole until then.

Change #1038910 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Use mask-image for all Vector icons

https://gerrit.wikimedia.org/r/1038910

gerritbot added a project: Patch-For-Review.Tue, Jun 4, 10:02 PM

This is actually a web team bug.

Jdlrobson added a project: Web-Team-Backlog.Thu, Jun 6, 6:42 PM

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.Fri, Jun 7, 4:25 PM

SToyofuku-WMF claimed this task.Tue, Jun 11, 9:05 PM

SToyofuku-WMF subscribed.

Change #1041787 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/Vector@master] Remove not selector and target OOUI icons for inversion only

https://gerrit.wikimedia.org/r/1041787

Should be fixed by T365951

Jdlrobson reassigned this task from SToyofuku-WMF to Edtadros.Wed, Jun 12, 1:15 AM

Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 5) board.

Change #1041787 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove not selector and target OOUI icons for inversion only

https://gerrit.wikimedia.org/r/1041787

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.10; 2024-06-18).Wed, Jun 12, 3:00 AM

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Contribution Icons are Visible in Dark Mode

Open beta- https://en.wikipedia.beta.wmflabs.org/wiki/Lightsaber, PROD- https://en.wikipedia.org/wiki/Lightsaber
Switch to dark mode in Appearances.
Observe the contribution icons (e.g., "my translations", "my file uploads").
AC1: Confirm that the icons are correctly inverted and visible in dark mode.