Page MenuHomePhabricator

Error messages for Title field in upload Wizard
Open, Needs TriagePublic

Description

This ticket is to both document and make changes to error message for title to cover all cases.

Scenario 1: When the title is not unique show the following error

Error 1.png (230×1 px, 30 KB)

Scenario 2: When the title is not informative show the following error. This is a new error message that was introduced as it is the most common reason for getting an error. The proposal is to also simplify the dialog message for this scenario by only showing examples.

Error 2.png (192×1 px, 23 KB)

Error 2 - dialog.png (682×1 px, 91 KB)

Scenario 3: For all other cases show the generic error message leading to a dialog with appropriate Titleblacklist message.

Error 3.png (172×850 px, 23 KB)

Some of the above has already been implemented and few things yet to be implemented. Here is the list of remaining updates:

  • Trigger error message as shown in Scenario 2 only if the title is uninformative.
    • Update the copy in the error message as shown in Scenario 2 (from "see examples" to "View examples")
    • Create a new dialog as shown in Scenario 2 with only the examples and a "Learn more" linking out to the original Titleblacklist message
  • For other invalid title issues, trigger an error message as shown in Scenario 3. "Click here" links to a dialog with appropriate Titleblacklist message

Event Timeline

@Etonkovidova we closed the other ticket as duplicate so linking your testing comments here.

Change #1043017 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Update error messages for titleblacklist violations in UW

https://gerrit.wikimedia.org/r/1043017

Change #1043017 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Update error messages for titleblacklist violations in UW

https://gerrit.wikimedia.org/r/1043017

Checked in commons beta

Scenario 1: ✅ - no issues When the title is not unique show the following error

task description examplecommons beta
Error 1.png (230×1 px, 30 KB)
Screen Shot 2024-06-14 at 3.24.24 PM.png (1×2 px, 567 KB)

Scenario 2: - needs Design review When the title is not informative show the following error. This is a new error message that was introduced as it is the most common reason for getting an error. The proposal is to also simplify the dialog message for this scenario by only showing examples.
Testing tip for triggering this scenario: Enter as a file name this one - 2E44F1FC-67F5-45AD-A1BA-85943BE39E5F 1 105 c

  • the popup warning looks stylistically different from the one provided in the task description
  • the link is not present. The popup in production has quite few links.
  • "see examples" is still displayed. Is the matching MediaWiki:Titleblacklist-custom-filename is missing?
task description examplecommons betacurrent production commons wmf.9
Error 2.png (192×1 px, 23 KB)
Error 2 - dialog.png (682×1 px, 91 KB)
Screen Shot 2024-06-14 at 4.36.57 PM.png (1×2 px, 528 KB)
Screen Shot 2024-06-14 at 4.37.07 PM.png (1×2 px, 536 KB)
Screen Shot 2024-06-14 at 4.37.28 PM.png (1×2 px, 562 KB)
Screen Shot 2024-06-14 at 4.37.36 PM.png (1×2 px, 781 KB)

Scenario 3: ✅ - no issues For all other cases show the generic error message leading to a dialog with appropriate Titleblacklist message.

task description examplecommons beta
Error 3.png (172×850 px, 23 KB)
Screen Shot 2024-06-14 at 4.23.31 PM.png (1×1 px, 516 KB)
Screen Shot 2024-06-14 at 4.23.42 PM.png (1×1 px, 752 KB)

Note: the link displayed as [[c:MediaWiki:Titleblacklist|blacklisted]] seems to be just a commons beta quirk.

Change #1046729 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/UploadWizard@master] Update msgs

https://gerrit.wikimedia.org/r/1046729

Change #1046729 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Update msgs

https://gerrit.wikimedia.org/r/1046729

Some comments about recent changes in messages:

  1. "Please choose a different, descriptive title": this was changed from "Please write a more informative title". Other messages still say write, for example: "Please write a more informative title ([$2 see examples])." Perhaps this should use "write", too?
  2. "This file name contains invalid characters or format": what is "invalid format"? "Format" is usually not a thing that is contained. Perhaps it should say "invalid formatting"? Or maybe it can be "This file name contains invalid characters or uses an invalid format" or "This file name contains invalid characters or is in an invalid format"?
  1. "This file name contains invalid characters or format": what is "invalid format"? "Format" is usually not a thing that is contained. Perhaps it should say "invalid formatting"? Or maybe it can be "This file name contains invalid characters or uses an invalid format" or "This file name contains invalid characters or is in an invalid format"?

Agree - the error message should be revised for clarity. There are rules on MediaWiki:Titleblacklist that refer to a file name format as being incorrect - e.g. # SVG-rendered-as-PNG file names, with special error message.

@Etonkovidova
For scenario 2 design review: Yes the learn more link should be present and the copy of the link is also needs to change to "View". The stylistic differences are fine for now.

For scenario 3 copy suggestion: We can update to one of the options suggested as it does seem more clear. I have updated the design with this option "This file name contains invalid characters or is in an invalid format."

May be we can keep this ticket open until they are fixed in the next round.