Page MenuHomePhabricator

Newcomer Homepage: Suggested Edits (mobile preview) empty state when there are no suggested edits
Closed, ResolvedPublic

Description

Task to improve the Suggested Edits module when no Suggested Edits are available, and address: T368405: Special:Homepage is rendered much slower (<1 sec to 2+ sec).

User story & summary:

As a newcomer visiting my Homepage, I want the Suggested Edits module to display helpful information even when there are no Suggested Edits available, so that I'm encouraged to contribute to Wikipedia.

Background & research:

this "mobile preview with edit-count" was introduced in Fall 2019 for T235810: Newcomer tasks: mobile preview.
In Fall 2020 it was switched to showing the first task right away instead, at least for some variants: T258021: Variant C/D: mobile preview for suggested edits module with first suggested edit.

The "mobile preview with edit-count" still displays on mobile as the empty state / when there are no suggested edits available. The edit-count is pulled from the Analytics Query Service (AQS) for every Homepage load, even when the the empty state isn't displayed, and is slowing down the page load.
The edit-count is currently rendering as "0". The "0" is the server-rendered response when it failed to retrieve the number of edits from the AQS. Once javascript kicks in, it will show as because the widget does not expect to get something that is not a number. (in this case it gets the error message from the server)

Current Designs:

Current Mobile Preview Suggested Edit empty state:

Screenshot 2024-06-26 at 9.36.33 AM (1).png (410×696 px, 37 KB)

Current Desktop Suggested Edit layout:

Screenshot 2024-06-26 at 9.36.12 AM.png (1×1 px, 105 KB)

Invision mockup.

Ideas
  • Match the current Desktop design: "No suggested edits are available at this time."
  • Consider different copy: "Currently no structured tasks available. Try selecting more topics and task-types or check back later."
  • Consider surfacing other information that might be more helpful for newer editors (we could consider using the community configurable "Help panel links" to surface the the first help link).
  • Hide the Suggested Edits module when there are no suggestions available.
New Designs:

(1) Change the empty state mobile preview to:

New mobile preview (1).png (225×344 px, 16 KB)

(2) If the arrow is clicked, the mobile Suggested Edits module empty state is shown:

Mobile-SE-No suggestions found.png (640×364 px, 23 KB)

Acceptance Criteria:
  • Update mobile preview "No suggestions" empty state to match "New Designs" above

Event Timeline

KStoller-WMF renamed this task from Newcomer Homepage: Suggested Edits empty state when there are no suggested edits to Newcomer Homepage: Suggested Edits (mobile preview) empty state when there are no suggested edits.Jun 28 2024, 6:44 PM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF updated the task description. (Show Details)

Proposed solution:

(1) Change the empty state mobile preview to:

New mobile preview (1).png (225×344 px, 16 KB)

(2) If the arrow is clicked, the mobile Suggested Edits module empty state is shown:

Mobile-SE-No suggestions found.png (640×364 px, 23 KB)

Random thought: my understanding is that the Suggested Edits module empty state already exists. Should we consider utilizing the same copy for the empty state mobile preview to preserve translations?

Michael moved this task from Incoming to Doing on the Growth-Team (Sprint 17 (Growth Team)) board.

Let's try and see if we can get a first version out with this week's train.

Change #1051098 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Homepage: don't show edit count in mobile no structured tasks fallback

https://gerrit.wikimedia.org/r/1051098

Moving to Code Review for this first change that changes the text and drops the calls to AQS. Further changes are needed to adjust the icon, drop now-dead code for getting the edit count, add metrics, etc., so please move it back to "Doing" after 1051098 has been merged.

The new icon:

New mobile preview (1).png (225×344 px, 16 KB)

Are we already using that somewhere? If not, where would I find the .svg file?

The new icon:

New mobile preview (1).png (225×344 px, 16 KB)

Are we already using that somewhere? If not, where would I find the .svg file?

Thanks for raising that question @Michael! This is the .svg file:

On the mobile mock-up (mobile preview) the size is of 64x64 px.

(2) If the arrow is clicked, the mobile Suggested Edits module empty state is shown:

Mobile-SE-No suggestions found.png (640×364 px, 23 KB)

@Michael FYI, this is something that already exists, Rita designed this some time ago, see Growth features Figma file.

I am not sure if this is live though?

@JFernandez-WMF Ah, you're right, thank you! This is in fact also what is implemented (with slightly different copy). Then I have to investigate where that image is coming from for that view 🕵️
Thanks!

Urbanecm_WMF subscribed.

Moving to Code Review for this first change that changes the text and drops the calls to AQS. Further changes are needed to adjust the icon, drop now-dead code for getting the edit count, add metrics, etc., so please move it back to "Doing" after 1051098 has been merged.

Moving back to Doing, as requested.

Change #1051098 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Homepage: don't show edit count in mobile no structured tasks fallback

https://gerrit.wikimedia.org/r/1051098

Change #1051363 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Homepage: show no-results icon in mobile no structured tasks preview

https://gerrit.wikimedia.org/r/1051363

Change #1051374 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Completely drop code about the EditInfoService

https://gerrit.wikimedia.org/r/1051374

Change #1051363 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Homepage: show no-results icon in mobile no structured tasks preview

https://gerrit.wikimedia.org/r/1051363

Change #1051722 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: log how often a user's task queue is error/empty/ok

https://gerrit.wikimedia.org/r/1051722

Change #1051374 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Completely drop code about the EditInfoService

https://gerrit.wikimedia.org/r/1051374

Hi! About "Currently no structured tasks available"—is this really correct? I'm not a native English speaker, but it sounds like something is missing.

Perhaps it could be rephrased a bit? For example: "Currently, no structured tasks are available".

Hi! About "Currently no structured tasks available"—is this really correct? I'm not a native English speaker, but it sounds like something is missing.

Perhaps it could be rephrased a bit? For example: "Currently, no structured tasks are available".

Good point. Technically the phrase isn't grammatically correct, but I think concise "telegraphic style" error messages are fairly common.

That being said, I'm not opposed to making an improvement to the copy. @Michael / @JFernandez-WMF thoughts on improving the copy?
Ideas:

  • Currently, no structured tasks are available
  • No suggestions found
  • No suggestions are currently available.
  • Sorry, there are no suggestions available.

I'm not sure if I'm the best person to weigh in, as I'm neither a native speaker, nor have any training in writing copy. I find "Currently no structured tasks available" to be clear to understand. "Currently, no structured tasks are available" on the other hand feels ever so slightly more garden-path-y with the positive verb "are" emphasizing that something is available. "Currently, there are no structured tasks available." feels a bit better in that regard. But I'm probably overthinking this. (Also again: I don't really know what I'm talking about. I'm just a developer^^.)

Change #1051722 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: track how often a user's task queue is error/empty/ok

https://gerrit.wikimedia.org/r/1051722

Moving this to doing for creating some Grafana panels for the metrics added.

Change #1056121 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Homepage: track total Suggested edit queue views to calculate rates later

https://gerrit.wikimedia.org/r/1056121

Change #1056121 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Homepage: track total Suggested edit queue views to calculate rates later

https://gerrit.wikimedia.org/r/1056121

The remaining work, creating the Grafana panels, has been moved to T375600: Create Grafana panel with percentage of (mobile) homepage views with no available tasks. That task is blocked on the overall migration away from statsd/Graphite to statslib/Prometheus.

Let's close this task here.