Page MenuHomePhabricator
Create Task
Maniphest T368750

Newcomer Homepage: Suggested Edits (mobile preview) empty state when there are no suggested edits
Open, HighPublic
Actions

Assigned To
Michael
Authored By
KStoller-WMF
Fri, Jun 28, 3:45 PM
Tags
Referenced Files
F56123425: no-results.svg
Mon, Jul 1, 1:09 PM
F55981701: Mobile-SE-No suggestions found.png
Fri, Jun 28, 7:56 PM
F55981674: New mobile preview (1).png
Fri, Jun 28, 7:56 PM
F55970378: Screenshot 2024-06-26 at 9.36.12 AM.png
Fri, Jun 28, 3:45 PM
F55970704: Screenshot 2024-06-26 at 9.36.33 AM (1).png
Fri, Jun 28, 3:45 PM
Subscribers
Aklapper
Amire80
JFernandez-WMF
KStoller-WMF
Michael
Sgs
Urbanecm_WMF

Description

Task to improve the Suggested Edits module when no Suggested Edits are available, and address: T368405: Special:Homepage is rendered much slower (<1 sec to 2+ sec).

User story & summary:

As a newcomer visiting my Homepage, I want the Suggested Edits module to display helpful information even when there are no Suggested Edits available, so that I'm encouraged to contribute to Wikipedia.

Background & research:

this "mobile preview with edit-count" was introduced in Fall 2019 for T235810: Newcomer tasks: mobile preview.
In Fall 2020 it was switched to showing the first task right away instead, at least for some variants: T258021: Variant C/D: mobile preview for suggested edits module with first suggested edit.

The "mobile preview with edit-count" still displays on mobile as the empty state / when there are no suggested edits available. The edit-count is pulled from the Analytics Query Service (AQS) for every Homepage load, even when the the empty state isn't displayed, and is slowing down the page load.
The edit-count is currently rendering as "0". The "0" is the server-rendered response when it failed to retrieve the number of edits from the AQS. Once javascript kicks in, it will show as because the widget does not expect to get something that is not a number. (in this case it gets the error message from the server)

Current Designs:

Current Mobile Preview Suggested Edit empty state:

Screenshot 2024-06-26 at 9.36.33 AM (1).png (410×696 px, 37 KB)

Current Desktop Suggested Edit layout:

Screenshot 2024-06-26 at 9.36.12 AM.png (1×1 px, 105 KB)

Invision mockup.

Ideas
  • Match the current Desktop design: "No suggested edits are available at this time."
  • Consider different copy: "Currently no structured tasks available. Try selecting more topics and task-types or check back later."
  • Consider surfacing other information that might be more helpful for newer editors (we could consider using the community configurable "Help panel links" to surface the the first help link).
  • Hide the Suggested Edits module when there are no suggestions available.
New Designs:

(1) Change the empty state mobile preview to:

New mobile preview (1).png (225×344 px, 16 KB)

(2) If the arrow is clicked, the mobile Suggested Edits module empty state is shown:

Mobile-SE-No suggestions found.png (640×364 px, 23 KB)

Acceptance Criteria:
  • Update mobile preview "No suggestions" empty state to match "New Designs" above

Details

SubjectRepoBranchLines +/-
Completely drop code about the EditInfoServicemediawiki/extensions/GrowthExperimentsmaster+0 -212
Suggested edits: log how often a user's task queue is error/empty/okmediawiki/extensions/GrowthExperimentsmaster+23 -3
Homepage: show no-results icon in mobile no structured tasks previewmediawiki/extensions/GrowthExperimentsmaster+3 -1
Homepage: don't show edit count in mobile no structured tasks fallbackmediawiki/extensions/GrowthExperimentsmaster+126 -141
Customize query in gerrit

Related Objects
Search...

Event Timeline

KStoller-WMF created this task.Fri, Jun 28, 3:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Jun 28, 3:45 PM
KStoller-WMF triaged this task as High priority.Fri, Jun 28, 3:46 PM
KStoller-WMF edited projects, added Growth-Team (Sprint 17 (Growth Team)); removed Growth-Team.
KStoller-WMF updated the task description. (Show Details)Fri, Jun 28, 4:52 PM
KStoller-WMF added a parent task: T368405: Special:Homepage is rendered much slower (<1 sec to 2+ sec).Fri, Jun 28, 6:42 PM
KStoller-WMF mentioned this in T368405: Special:Homepage is rendered much slower (<1 sec to 2+ sec).
KStoller-WMF renamed this task from Newcomer Homepage: Suggested Edits empty state when there are no suggested edits to Newcomer Homepage: Suggested Edits (mobile preview) empty state when there are no suggested edits.Fri, Jun 28, 6:44 PM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF updated the task description. (Show Details)
JFernandez-WMF added a comment.Fri, Jun 28, 7:56 PM

Proposed solution:

(1) Change the empty state mobile preview to:

New mobile preview (1).png (225×344 px, 16 KB)

(2) If the arrow is clicked, the mobile Suggested Edits module empty state is shown:

Mobile-SE-No suggestions found.png (640×364 px, 23 KB)

JFernandez-WMF moved this task from Incoming to Doing on the Growth-Team (Sprint 17 (Growth Team)) board.Fri, Jun 28, 8:42 PM
KStoller-WMF updated the task description. (Show Details)Fri, Jun 28, 9:04 PM
KStoller-WMF updated the task description. (Show Details)
KStoller-WMF removed JFernandez-WMF as the assignee of this task.Fri, Jun 28, 9:06 PM
KStoller-WMF added a subscriber: JFernandez-WMF.
KStoller-WMF added a comment.Fri, Jun 28, 9:29 PM

Random thought: my understanding is that the Suggested Edits module empty state already exists. Should we consider utilizing the same copy for the empty state mobile preview to preserve translations?

KStoller-WMF moved this task from Doing to Incoming on the Growth-Team (Sprint 17 (Growth Team)) board.Mon, Jul 1, 3:58 AM
Michael claimed this task.Mon, Jul 1, 9:03 AM
Michael moved this task from Incoming to Doing on the Growth-Team (Sprint 17 (Growth Team)) board.

Let's try and see if we can get a first version out with this week's train.

Restricted Application added a project: User-Michael. · View Herald TranscriptMon, Jul 1, 9:03 AM
gerritbot added a comment.Mon, Jul 1, 11:02 AM

Change #1051098 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Homepage: don't show edit count in mobile no structured tasks fallback

https://gerrit.wikimedia.org/r/1051098

gerritbot added a project: Patch-For-Review.Mon, Jul 1, 11:02 AM
Michael moved this task from Doing to Code Review on the Growth-Team (Sprint 17 (Growth Team)) board.Mon, Jul 1, 11:17 AM

Moving to Code Review for this first change that changes the text and drops the calls to AQS. Further changes are needed to adjust the icon, drop now-dead code for getting the edit count, add metrics, etc., so please move it back to "Doing" after 1051098 has been merged.

Michael added a comment.Mon, Jul 1, 12:49 PM

The new icon:

New mobile preview (1).png (225×344 px, 16 KB)

Are we already using that somewhere? If not, where would I find the .svg file?

JFernandez-WMF added a comment.EditedMon, Jul 1, 1:09 PM
In T368750#9939569, @Michael wrote:

The new icon:

New mobile preview (1).png (225×344 px, 16 KB)

Are we already using that somewhere? If not, where would I find the .svg file?

Thanks for raising that question @Michael! This is the .svg file:

no-results.svg3 KBDownload

On the mobile mock-up (mobile preview) the size is of 64x64 px.

JFernandez-WMF added a comment.Mon, Jul 1, 6:46 PM

(2) If the arrow is clicked, the mobile Suggested Edits module empty state is shown:

Mobile-SE-No suggestions found.png (640×364 px, 23 KB)

@Michael FYI, this is something that already exists, Rita designed this some time ago, see Growth features Figma file.

I am not sure if this is live though?

Michael added a comment.Mon, Jul 1, 7:36 PM

@JFernandez-WMF Ah, you're right, thank you! This is in fact also what is implemented (with slightly different copy). Then I have to investigate where that image is coming from for that view 🕵️
Thanks!

Urbanecm_WMF moved this task from Code Review to Doing on the Growth-Team (Sprint 17 (Growth Team)) board.Tue, Jul 2, 12:40 PM
Urbanecm_WMF subscribed.
In T368750#9939272, @Michael wrote:

Moving to Code Review for this first change that changes the text and drops the calls to AQS. Further changes are needed to adjust the icon, drop now-dead code for getting the edit count, add metrics, etc., so please move it back to "Doing" after 1051098 has been merged.

Moving back to Doing, as requested.

gerritbot added a comment.Tue, Jul 2, 1:13 PM

Change #1051098 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Homepage: don't show edit count in mobile no structured tasks fallback

https://gerrit.wikimedia.org/r/1051098

Maintenance_bot removed a project: Patch-For-Review.Tue, Jul 2, 1:31 PM
gerritbot added a comment.Tue, Jul 2, 1:37 PM

Change #1051363 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Homepage: show no-results icon in mobile no structured tasks preview

https://gerrit.wikimedia.org/r/1051363

gerritbot added a project: Patch-For-Review.Tue, Jul 2, 1:37 PM
gerritbot added a comment.Tue, Jul 2, 1:56 PM

Change #1051374 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Completely drop code about the EditInfoService

https://gerrit.wikimedia.org/r/1051374

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Tue, Jul 2, 2:01 PM
KStoller-WMF closed subtask T368796: Data exploration: How does page load time impact Homepage engagement? as Resolved.Tue, Jul 2, 8:00 PM
gerritbot added a comment.Wed, Jul 3, 8:43 AM

Change #1051363 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Homepage: show no-results icon in mobile no structured tasks preview

https://gerrit.wikimedia.org/r/1051363

gerritbot added a comment.Wed, Jul 3, 10:51 AM

Change #1051722 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: log how often a user's task queue is error/empty/ok

https://gerrit.wikimedia.org/r/1051722

Michael moved this task from Doing to Code Review on the Growth-Team (Sprint 17 (Growth Team)) board.Wed, Jul 3, 12:15 PM
gerritbot added a comment.Wed, Jul 3, 12:38 PM

Change #1051374 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Completely drop code about the EditInfoService

https://gerrit.wikimedia.org/r/1051374

Amire80 subscribed.Wed, Jul 3, 1:36 PM

Hi! About "Currently no structured tasks available"—is this really correct? I'm not a native English speaker, but it sounds like something is missing.

Perhaps it could be rephrased a bit? For example: "Currently, no structured tasks are available".

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits