Page MenuHomePhabricator

Coordinate the updates of IP-using AbuseFilter filters to use `user_unnamed_ip`
Open, Needs TriagePublic

Description

Background

When temporary accounts are enabled on a wiki, any filter using ips via user_name will no longer be able to do so. Those filters need to be updated to use user_unnamed_ip instead. This should be done before temporary accounts are enabled so that filters will work seamlessly (user_unnamed_ip has support for anonymous users and will work as-expected on wikis without temporary accounts enabled) after rollout.

Migration steps
  • Ensure someone has access to protected variables (see T369610)
  • Communicate with maintainers about the necessary changes needed to the filters and request they make the changes (this is an opportunity to ensure everything works as expected before temporary accounts rolls out on the wiki)
  • Filters that haven't been updated (eg. on smaller wikis) can be updated by T&S after a tbd amount of time (but before temporary accounts are enabled on the wiki)
Deployment stages
  • Minor pilot wikis
  • Major pilot wikis
  • All wikis

Details

Other Assignee
STran

Event Timeline

kostajh renamed this task from Update IP-using AbuseFilter filters to use `user_unnamed_ip` to Coordinate the updates of IP-using AbuseFilter filters to use `user_unnamed_ip`.Oct 8 2024, 10:31 AM
kostajh assigned this task to sgrabarczuk.
kostajh updated Other Assignee, added: STran.
Tchanders subscribed.

Moving out of the sprint, since we're not expecting to do the major pilots communication this sprint.

As of today, there are 812 filters using ip_in_range.

As of today, there are 812 filters using ip_in_range.

Today it is 809 (mwscript ./extensions/AbuseFilter/maintenance/SearchFilters.php --wiki=testwiki --pattern=ip_in_range).

Clarification:

[kharlan@deploy2002 ~]$ mwscript ./extensions/AbuseFilter/maintenance/SearchFilters.php --wiki=testwiki --pattern="ip_in_range\(user_name" | wc -l
591
[kharlan@deploy2002 ~]$ mwscript ./extensions/AbuseFilter/maintenance/SearchFilters.php --wiki=testwiki --pattern="ip_in_range\( user_name" | wc -l
13

New condition:

[kharlan@deploy2002 ~]$ mwscript ./extensions/AbuseFilter/maintenance/SearchFilters.php --wiki=testwiki --pattern="ip_in_range\(user_unnamed_ip" | wc -l
2
[kharlan@deploy2002 ~]$ mwscript ./extensions/AbuseFilter/maintenance/SearchFilters.php --wiki=testwiki --pattern="ip_in_range\( user_unnamed_ip"
0