Page MenuHomePhabricator

[S] Open image in gallery view (from modal sheet)
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

While writing alt text, users should be able to open the image fullscreen to review it's contents. In gallery view, users can pinch and zoom on the image.

Requirements
  • If user taps on image thumbnail, Image should open in gallery view
  • Reuses standard gallery view
  • Supports pinch and zoom
  • If a user opens this and navigates back, any text that has been already written in the text field is retained
  • Relevant events are instrumented according to Data instrumentation plan and completed slides have been marked with a green background

[] Translations are added for target languages from UI Copy for Suggested edits Alt text on iOS (T370725) No translations needed for this task.

Nice to have:

  • If a user pinches to zoom in on the thumbnail, open it in gallery view
Design:

Can match image recommendations screen which has search & share
Figma:

image.png (667×375 px, 177 KB)
image.png (1×750 px, 778 KB)

Event Timeline

Tsevener renamed this task from Open image in gallery view (from modal sheet) to [S] Open image in gallery view (from modal sheet).Jul 23 2024, 6:17 PM
HNordeenWMF raised the priority of this task from Low to Medium.Jul 23 2024, 10:06 PM

@HNordeenWMF Just a heads up, also skipping design review on this one. Let me know if that's incorrect!

ABorbaWMF subscribed.

I am having some issues with this one on 7.5.8 (3979). Specifically, tapping the image thumbnail does not display the image in the gallery view

IMG_6395.PNG (2×1 px, 225 KB)

After tapping thumbnail
IMG_6396.PNG (2×1 px, 88 KB)

It works for me 7.5.8 (3979). Do you have the "Do not post image recommendations edit" dev setting turned on? That causes some bugs.

https://drive.google.com/drive/folders/13xM1JxAT6-e0FAISiytQW1HU2CWC7LFr

@Mazevedo Yes, that could be it, I'll try without

It is now working for me (without the dev setting toggled on); moving to sign off