Update the globalblock API to support specifying if account creation should be blocked
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Aug 2 2024, 5:56 PM

Description

The globalblock API allows callers to globally block in a similar way to the Special:GlobalBlock page. Therefore, in-line with T371693, the API should also support optionally disabling account creation.

To ensure that existing users of the API are not negatively affected, we should ensure that the default is to disable account creation.

Acceptance criteria

Update the globalblocks API to allow callers to optionally disable account creation (instead of always disabling account creation)

Details

	Subject	Repo	Branch	Lines +/-
	Update ApiGlobalBlock to optionally disable account creation	mediawiki/extensions/GlobalBlocking	master	+55 -10

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
			Restricted Task
Resolved		kostajh	T294511 2021 Security Team wikireplicas audit
Declined		None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
In Progress		Niharika	T324492 Temporary accounts - MVP
Open		None	T326816 [Epic] Update features for temporary accounts
Open		Dreamy_Jazz	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
Resolved		Dreamy_Jazz	T368949 [Epic] Implement global autoblocks from global user blocks
Resolved		None	T40648 Wiki Loves Monuments 2012 (tracking)
Duplicate		None	T42190 Anonymous only global block prevents account creation
Resolved	Feature	Dreamy_Jazz	T17273 Add "Prevent account creation" checkbox to allow global blocks which do not prevent account creation
Resolved		Dreamy_Jazz	T371718 Update the globalblock API to support specifying if account creation should be blocked
Resolved		Dreamy_Jazz	T371619 Update the GlobalBlockingManager to write to the gb_create_account column
Resolved		Dreamy_Jazz	T371604 Update the GlobalBlockLookup service to read the value of gb_create_account
Resolved		Dreamy_Jazz	T371601 Test the GlobalBlock class
Resolved		Ladsgroup	T371415 Add gb_autoblock_parent_id, gb_autoblock_enabled, and gb_create_account to the globalblocks table
Resolved		Dreamy_Jazz	T371248 Add gb_create_account column to the globalblocks table

Event Timeline

Dreamy_Jazz created this task.Aug 2 2024, 5:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2024, 5:56 PM

Change #1059415 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update ApiGlobalBlock to optionally disable account creation

https://gerrit.wikimedia.org/r/1059415

gerritbot added a project: Patch-For-Review.Aug 2 2024, 6:37 PM

Dreamy_Jazz added a subtask: T371619: Update the GlobalBlockingManager to write to the gb_create_account column.Aug 2 2024, 7:06 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Aug 2 2024, 7:26 PM

Dreamy_Jazz set the point value for this task to 1.

Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)); removed Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)).Aug 5 2024, 9:47 AM

Tchanders moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.

Dreamy_Jazz moved this task from Sprint Erhu (August 5th - August 16th) to Sprint Theremin (Aug 26 - Sept. 6) on the Trust and Safety Product Sprint board.Aug 27 2024, 12:28 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)); removed Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)).

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.

Change #1059415 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update ApiGlobalBlock to optionally disable account creation

https://gerrit.wikimedia.org/r/1059415

Dreamy_Jazz moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Aug 30 2024, 2:20 PM

For QA I would suggest using Special:ApiSandbox to globally block targets while checking and not checking the new allow-account-creation and local-allow-account-creation checkboxes on the page. These should work similarly to the Globally disable account creation and Locally disable account creation checkboxes on Special:GlobalBlock, except that the checkboxes are the inverse of each other.

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2024, 2:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Aug 30 2024, 3:00 PM

QA has been completed and the new code is functioning and displaying as expected, thank you @Dreamy_Jazz for the Test Notes.

Display of the allow-account-creation toggle, and the local-allow-account-creation toggle:

some Results of my testing this ticket:

Dreamy_Jazz updated the task description. (Show Details)Sep 4 2024, 8:51 AM

Dreamy_Jazz closed this task as Resolved.Sep 4 2024, 2:28 PM

	F57437586: image.png
	Sep 4 2024, 5:42 AM

	F57437626: image.png
	Sep 4 2024, 5:42 AM

	F57437546: image.png
	Sep 4 2024, 5:42 AM

	F57437372: image.png
	Sep 4 2024, 5:42 AM

Update the globalblock API to support specifying if account creation should be blockedClosed, ResolvedPublic1 Estimated Story PointsActions