| seth | |
| Aug 10 2024, 8:43 AM |
| F57267367: image.png | |
| Aug 11 2024, 12:46 PM |
| F57224947: image.png | |
| Aug 10 2024, 9:39 AM |
As the diff sizes (e.g. "+123" or "-432") are listed in their own column, there's no need to put them into additional (redundant) parentheses (e.g. "(+123)" or "(-432)").
Solution: just omit the parentheses. :-)
Example link: https://en.wikipedia.org/wiki/Special:PendingChanges
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Special:PendingChanges: remove parentheses from diff sizes | mediawiki/extensions/FlaggedRevs | master | +8 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Dogu | T191156 Convert FlaggedRevisions to Codex | |||
| Open | Novem_Linguae | T372187 Don't use parentheses around "Size" and "Since" values in pending-changes table |
Change #1061146 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):
[mediawiki/extensions/FlaggedRevs@master] Special:PendingChanges: remove parentheses from diff sizes
Change #1061146 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Special:PendingChanges: remove parentheses from diff sizes
I see the "since" parentheses in your original screenshot. But I cannot reproduce on my localhost, neither with latest master, nor a snapshot of the codebase from a couple days ago. Latest master looks like this to me:
Can you go on the beta cluster and see if you can get the "since" values to have parentheses? Example beta cluster link: https://en.wikipedia.beta.wmflabs.org/wiki/Special:PendingChanges. I think you can change en to your language if that's easier.
Only "(less than 1 hour ago)" is shown with parentheses in the "Since" column. Other durations (e.g., 2 hours) are shown without parentheses.
Would the following work?
.mw-fr-pending-changes-table .mw-diff-bytes::before,
.mw-fr-pending-changes-table .mw-diff-bytes::after {
content: '';
}I wrote a patch with that exact code already and it's in master. Great minds. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1061146
I'll have to test if it solves the "(less than 1 hour ago)" when I get to a computer. It definitely solves the other column (the size column).
Cool! Looks like it's working on https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:PendingChanges
It’s still there if you disable JavaScript, as well as for a moment on page load if JS is enabled. I haven’t looked into the code, but this is typically what happens when CSS is bundled with independent JavaScript code (independent in the sense that the CSS styles things other than those created by the JS). This should be fixed by moving CSS to its own ResourceLoader module and loading that module using OutputPage::addModuleStyles() rather than OutputPage::addModules().