Page MenuHomePhabricator

Thanks styled as link on mobile (no role attribute)
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Text is blue like a link
  • Underline appears:

Screenshot 2024-09-26 at 5.24.40 PM.png (120×282 px, 14 KB)

Screenshot 2024-09-26 at 5.25.42 PM.png (146×254 px, 10 KB)

What should have happened instead?:
No white underline.
These buttons should be marked up with role attribute as they are buttons.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1076051 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Thanks@master] Codex buttons that are anchor elements should have role button

https://gerrit.wikimedia.org/r/1076051

I've marked this as a train blocker as it seems like the labels are not visible at all now given other changes

image.png (480×320 px, 22 KB)
!

Michael triaged this task as Unbreak Now! priority.Sep 30 2024, 8:38 AM
Michael subscribed.

Deployment blockers are UBN.

Change #1076051 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] Codex buttons that are anchor elements should have role button

https://gerrit.wikimedia.org/r/1076051

Michael lowered the priority of this task from Unbreak Now! to High.Sep 30 2024, 12:13 PM

The change has been merged, so reducing the priority from UBN to high, because it is still important for this to go out with the next train.

Etonkovidova subscribed.

Checked on testwiki wmf.25 - the issue is fixed:

Screen Shot 2024-10-01 at 3.48.15 PM.png (644×1 px, 89 KB)
Another "thank" button also looks good:
Screen Shot 2024-10-01 at 3.48.59 PM.png (1×772 px, 106 KB)

The Wikitext button looks different on testwiki wmf.25 than on other wikis on wmf.24 - I filed it as a regression issue (not sure whether it was caused by the fix in this task) - T376226: [testwiki-wmf.25 regression] mobile: oo-ui-icon-wikiText button displayed incorrectly