Page MenuHomePhabricator
Create Task
Maniphest T376226

[testwiki-wmf.25 regression] mobile: oo-ui-icon-wikiText button displayed incorrectly
Open, Needs TriagePublic
Actions

Description

Likely related to T374145

Found when T375834: Thanks styled as link on mobile (no role attribute)
Steps:
On mobile testwiki wmf.25 go to History and click to display any revision of an article, e.g. https://test.m.wikipedia.org/w/index.php?title=MavetunaZilant21&diff=614859&oldid=614858

What happened:
The Wikitext icon displayed incorrectly:

Screen Shot 2024-10-01 at 4.06.14 PM.png (936×2 px, 208 KB)

What should happen:
The wikitext button displayed as before, e.g. wmf.24 https://en.m.wikipedia.org/w/index.php?diff=1248533684&oldid=1247889834&title=Shoko_Ikeda

Screen Shot 2024-10-01 at 4.13.08 PM.png (1×758 px, 155 KB)

Notes:

  • the issue is present only on mobile

Details

SubjectRepoBranchLines +/-
Disable unused icon variantsmediawiki/skins/MinervaNeuemaster+6 -2
OOUIImageModule: Disable mask-image for OOUI iconsmediawiki/coremaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Tue, Oct 1, 11:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Oct 1, 11:16 PM
Etonkovidova mentioned this in T375834: Thanks styled as link on mobile (no role attribute).Tue, Oct 1, 11:17 PM
Jdlrobson added a project: VisualEditor-VisualDiffs.Wed, Oct 2, 12:14 PM

I think this relates to the visual diff feature.

Maintenance_bot added a project: VisualEditor.Wed, Oct 2, 12:29 PM
Esanders subscribed.Wed, Oct 2, 1:50 PM

Looks like the mask-image property is being set, which seems unnecessary for an OOUI icon...

gerritbot added a comment.Wed, Oct 2, 2:01 PM

Change #1077398 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] OOUIImageModule: Disable mask-image for OOUI icons

https://gerrit.wikimedia.org/r/1077398

gerritbot added a project: Patch-For-Review.Wed, Oct 2, 2:01 PM
Esanders added a project: Regression.Thu, Oct 3, 1:25 PM
gerritbot added a comment.Thu, Oct 3, 1:25 PM

Change #1077398 abandoned by Esanders:

[mediawiki/core@master] OOUIImageModule: Disable mask-image for OOUI icons

https://gerrit.wikimedia.org/r/1077398

Maintenance_bot removed a project: Patch-For-Review.Thu, Oct 3, 1:30 PM
matmarex subscribed.Thu, Oct 3, 2:25 PM
Jdlrobson updated the task description. (Show Details)Thu, Oct 3, 2:43 PM
Esanders added a comment.Thu, Oct 3, 3:15 PM

There are also issues in the mobile editor:

image.png (221×294 px, 11 KB)

gerritbot added a comment.Thu, Oct 3, 5:12 PM

Change #1077757 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Disable unused icon variants

https://gerrit.wikimedia.org/r/1077757

gerritbot added a project: Patch-For-Review.Thu, Oct 3, 5:12 PM
Jdlrobson added a parent task: T374145: Migrate ResourceLoader Icons in Minerva to use Codex.Thu, Oct 3, 5:16 PM
Jdlrobson removed a project: Web-Team-Backlog.

Web team will follow up on this in T374145 which I've added a parent task. Leaving open for testing purposes when we get the fix applied.

Jdlrobson mentioned this in T374145: Migrate ResourceLoader Icons in Minerva to use Codex.Thu, Oct 3, 5:17 PM
gerritbot added a comment.Thu, Oct 3, 7:01 PM

Change #1077757 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Disable unused icon variants

https://gerrit.wikimedia.org/r/1077757

Maintenance_bot removed a project: Patch-For-Review.Thu, Oct 3, 7:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.26; 2024-10-08).Thu, Oct 3, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits