Page MenuHomePhabricator

Temporarily restrict local access to Special:GlobalContributions
Closed, ResolvedPublic

Description

T356294: Restrict which groups have access to Special:GlobalContributions expects to implement some form of cross-wiki permission checking in order to ensure that users can only see privileged information they have the rights to. Until then, we want to restrict access to Special:GlobalContributions to members of the global-temporary-account-viewer group (see T375117: Give access to checkuser-temporary-account on all wikis for any user who is in the checkuser or suppress group on any wiki) because that's the only group of privileged users we can guarantee has access to the information from other wikis. We don't want to disable Special:GC until this permission check is done, as we'd like to be able to allow users to test Special:GC between now and the minor pilot wiki deploy.

Based on the following premises:

  • Special:GlobalContributions will only be accessible from metawiki (see T376612: Implement Global Contributions as a central page on Meta and implement redirects from other projects)
  • No one needs IP reveal rights on meta, as meta only knows that temp accounts exists and doesn't have them enabled
  • The only local groups on meta with (eventual) access via either checkuser-temporary-account/checkuser-temporary-account-no-preference are:
    • checkuser (via extension.json)
    • checkuser-temporary-account-viewer (via autopromote in CommonSettings.php)
    • bureaucrat /sysop/suppress via core-Permissions.php
  • No one will be a member of checkuser-temporary-account-viewer, as the conditional for autopromotion ($wmgDisableIPMasking || $wmgEnableIPMasking) will return false for metawiki

We should then add a config to remove the checkuser-temporary-account/checkuser-temporary-account-no-preference rights from the remaining groups (checkuser/bureaucrat /sysop/suppress) on meta until T356294: Restrict which groups have access to Special:GlobalContributions is done (ETA is by minor pilot wiki deploy in ~1-2 weeks, as it's a blocker).

Related Objects

Event Timeline

This makes sense to me. So the order would be:

  1. Use config to ensure only global groups have IP reveal right on metawiki. That will allow global groups to test Special:GlobalContributions on metawiki.
  2. Implement cross-wiki permissions logic that satisfies T356294: Restrict which groups have access to Special:GlobalContributions.
  3. Fix the premissions on metawiki; i.e. revert that patch that goes with this task.
  4. Deploy to minor pilot wikis.
  5. Work on a cleaner solution for cross-wiki permission checks, if necessary.
STran updated the task description. (Show Details)

Change #1081415 had a related patch set uploaded (by STran; author: STran):

[operations/mediawiki-config@master] Disable IP reveal rights for local metawiki groups

https://gerrit.wikimedia.org/r/1081415

global-temporary-account-viewer [is] the only group of privileged users we can guarantee has access to the information from other wikis.

There are 9 global groups with access on other wikis. 8 for all wikis and 1, global sysops, on a subset of wikis.

Change #1081415 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable IP reveal rights for local metawiki groups

https://gerrit.wikimedia.org/r/1081415

Mentioned in SAL (#wikimedia-operations) [2024-10-21T13:55:33Z] <stran@deploy2002> Started scap sync-world: Backport for [[gerrit:1081415|Disable IP reveal rights for local metawiki groups (T377584)]], [[gerrit:1081138|Set redirect wiki for Special:GlobalContributions (T376612)]], [[gerrit:1080227|temp accounts: Make temp accounts known on metawiki (T376132)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-21T13:57:53Z] <stran@deploy2002> stran, kharlan: Backport for [[gerrit:1081415|Disable IP reveal rights for local metawiki groups (T377584)]], [[gerrit:1081138|Set redirect wiki for Special:GlobalContributions (T376612)]], [[gerrit:1080227|temp accounts: Make temp accounts known on metawiki (T376132)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-10-21T14:10:29Z] <stran@deploy2002> Finished scap sync-world: Backport for [[gerrit:1081415|Disable IP reveal rights for local metawiki groups (T377584)]], [[gerrit:1081138|Set redirect wiki for Special:GlobalContributions (T376612)]], [[gerrit:1080227|temp accounts: Make temp accounts known on metawiki (T376132)]] (duration: 14m 55s)

Change #1081988 had a related patch set uploaded (by STran; author: STran):

[operations/mediawiki-config@master] Disable local IP view right group on meta

https://gerrit.wikimedia.org/r/1081988

STran renamed this task from Temporary restrict local access to Special:GlobalContributions to Temporarily restrict local access to Special:GlobalContributions.Oct 21 2024, 2:35 PM

Change #1081988 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable local IP view right group on meta

https://gerrit.wikimedia.org/r/1081988

Mentioned in SAL (#wikimedia-operations) [2024-10-21T14:59:34Z] <stran@deploy2002> Started scap sync-world: Backport for [[gerrit:1081988|Disable local IP view right group on meta (T377584)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-21T15:01:49Z] <stran@deploy2002> stran: Backport for [[gerrit:1081988|Disable local IP view right group on meta (T377584)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-10-21T15:20:03Z] <stran@deploy2002> Finished scap sync-world: Backport for [[gerrit:1081988|Disable local IP view right group on meta (T377584)]] (duration: 20m 29s)

dom_walden subscribed.

I see that on https://meta.wikimedia.org/wiki/Special:ListGroupRights the rights checkuser-temporary-account and checkuser-temporary-account-no-preference do not appear at all.