mw-contributions-current css class missing from Special:Contributions
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Go to the contributions page for someone with current edits (like https://en.wikipedia.org/wiki/Special:Contributions/AntiCompositeNumber )
Using developer tools, search for .mw-contributions-current or run document.getElementsByClassName("mw-contributions-current")

What happens?:
Nothing found.

What should have happened instead?:
Entries marked with (current) should also have the class .mw-contributions-current.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
This was first reported by @Tamzin 25 minutes after T375659: 1.43.0-wmf.28 deployment blockers rolled to enwiki. The code to add the class still exists in ContributionsPager.php but was recently changed by T377482-related work.

Details

Subject	Repo	Branch	Lines +/-
tests: Add test for SpecialContributions current edit css class	mediawiki/core	master	+25 -6
ContributionsPager: Fix getTemplateParams() parameter	mediawiki/core	wmf/1.43.0-wmf.28	+2 -2
Fix getTemplateParams() $classes parameter	mediawiki/extensions/CheckUser	wmf/1.43.0-wmf.28	+1 -1
Fix getTemplateParams() $classes parameter	mediawiki/extensions/CheckUser	master	+1 -1
Fix getTemplateParams() $classes parameter	mediawiki/extensions/CheckUser	REL1_43	+1 -1
ContributionsPager: Fix getTemplateParams() parameter	mediawiki/core	REL1_43	+2 -2
ContributionsPager: Fix getTemplateParams() parameter	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T130824: Equip list entry of most current contribution with class
T356292: Return global contributions by temporary accounts given an IP address or range
Mentioned Here: T375659: 1.43.0-wmf.28 deployment blockers
T377482: Update ContributionsPager to allow subclasses more control over formatting

Event Timeline

AntiCompositeNumber created this task.Oct 24 2024, 7:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2024, 7:11 PM

Pppery moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Oct 24 2024, 7:30 PM

Nardog mentioned this in T356292: Return global contributions by temporary accounts given an IP address or range.Oct 24 2024, 9:12 PM

Nardog subscribed.

#1080108 appears to be the culprit.

TheresNoTime subscribed.Oct 24 2024, 9:15 PM

Change #1082854 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] ContributionsPager: Fix getTemplateParams() parameter

https://gerrit.wikimedia.org/r/1082854

gerritbot added a project: Patch-For-Review.Oct 24 2024, 9:16 PM

Ammarpad claimed this task.Oct 24 2024, 9:18 PM

Ammarpad added a project: Regression.Oct 24 2024, 9:21 PM

Change #1082858 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/CheckUser@master] Fix getTemplateParams() $classes parameter

https://gerrit.wikimedia.org/r/1082858

Tiloudeux subscribed.Oct 24 2024, 10:18 PM

Menestor subscribed.Oct 25 2024, 3:13 AM

Change #1082854 merged by Samtar:

[mediawiki/core@master] ContributionsPager: Fix getTemplateParams() parameter

https://gerrit.wikimedia.org/r/1082854

Change #1083177 had a related patch set uploaded (by Dreamy Jazz; author: Ammarpad):

[mediawiki/core@REL1_43] ContributionsPager: Fix getTemplateParams() parameter

https://gerrit.wikimedia.org/r/1083177

Change #1083178 had a related patch set uploaded (by Dreamy Jazz; author: Ammarpad):

[mediawiki/extensions/CheckUser@REL1_43] Fix getTemplateParams() $classes parameter

https://gerrit.wikimedia.org/r/1083178

Change #1082858 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Fix getTemplateParams() $classes parameter

https://gerrit.wikimedia.org/r/1082858

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Oct 25 2024, 2:00 PM

Change #1083177 merged by Dreamy Jazz:

[mediawiki/core@REL1_43] ContributionsPager: Fix getTemplateParams() parameter

https://gerrit.wikimedia.org/r/1083177

Change #1083178 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@REL1_43] Fix getTemplateParams() $classes parameter

https://gerrit.wikimedia.org/r/1083178

I've backported this to REL1_43, so that the class isn't missing for the release version.

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2024, 2:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes.Oct 25 2024, 3:00 PM

Ammarpad closed this task as Resolved.Oct 25 2024, 4:03 PM

Od1n mentioned this in T130824: Equip list entry of most current contribution with class.Oct 25 2024, 9:21 PM

Change #1083591 had a related patch set uploaded (by Kosta Harlan; author: Ammarpad):

[mediawiki/core@wmf/1.43.0-wmf.28] ContributionsPager: Fix getTemplateParams() parameter

https://gerrit.wikimedia.org/r/1083591

Change #1083592 had a related patch set uploaded (by Kosta Harlan; author: Ammarpad):

[mediawiki/extensions/CheckUser@wmf/1.43.0-wmf.28] Fix getTemplateParams() $classes parameter

https://gerrit.wikimedia.org/r/1083592

Change #1083592 merged by Hashar:

[mediawiki/extensions/CheckUser@wmf/1.43.0-wmf.28] Fix getTemplateParams() $classes parameter

https://gerrit.wikimedia.org/r/1083592

Change #1083753 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] tests: Add test for SpecialContributions current edit css class

https://gerrit.wikimedia.org/r/1083753

Change #1083591 merged by Hashar:

[mediawiki/core@wmf/1.43.0-wmf.28] ContributionsPager: Fix getTemplateParams() parameter

https://gerrit.wikimedia.org/r/1083591

Mentioned in SAL (#wikimedia-operations) [2024-10-28T08:24:14Z] <hashar> Pushed https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1083592 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1083592 for wmf/1.43.0-wmf.28 / T378132 due to a dependency loop

Mentioned in SAL (#wikimedia-operations) [2024-10-28T08:27:36Z] <hashar> Pushed https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1083592 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1083591 for wmf/1.43.0-wmf.28 / T378132 due to a dependency loop

Mentioned in SAL (#wikimedia-operations) [2024-10-28T08:28:29Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1083591|ContributionsPager: Fix getTemplateParams() parameter (T378132)]], [[gerrit:1083592|Fix getTemplateParams() $classes parameter (T378132)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-28T08:31:25Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1083591|ContributionsPager: Fix getTemplateParams() parameter (T378132)]], [[gerrit:1083592|Fix getTemplateParams() $classes parameter (T378132)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-10-28T08:38:07Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1083591|ContributionsPager: Fix getTemplateParams() parameter (T378132)]], [[gerrit:1083592|Fix getTemplateParams() $classes parameter (T378132)]] (duration: 09m 38s)

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.28; 2024-10-22); removed MW-1.43-notes.Oct 28 2024, 9:00 AM

The fix for this is live on all wikis. Thanks for reporting the issue and filing a patch, apologies for the breakage and inconvenience.

Change #1083753 merged by jenkins-bot: