Page MenuHomePhabricator
Create Task
Maniphest T380138

Special:SearchTranslations is not dark mode compatible
Open, LowPublic2 Estimated Story Points
Actions

Description

Details

SubjectRepoBranchLines +/-
Use LESS variables for the Translate extensionmediawiki/extensions/Translatemaster+286 -270
Use less variables to accommodate dark modemediawiki/extensions/Translatemaster+42 -37
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nemoralis created this task.Mon, Nov 18, 12:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Nov 18, 12:04 AM
Nikerabbit added a parent task: T371071: Dark mode not compatible with Translate extension Special:Translate page.Mon, Nov 18, 1:30 PM
Nikerabbit edited projects, added affects-translatewiki.net, MediaWiki-extensions-Translate; removed translatewiki.net.
gerritbot added a comment.Mon, Nov 18, 10:01 PM

Change #1091857 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Use less variables to accomodate dark mode

https://gerrit.wikimedia.org/r/1091857

gerritbot added a project: Patch-For-Review.Mon, Nov 18, 10:01 PM
jhsoby subscribed.Mon, Nov 18, 10:03 PM
gerritbot added a comment.Tue, Nov 19, 10:47 AM

Change #1091857 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Use less variables to accommodate dark mode

https://gerrit.wikimedia.org/r/1091857

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Tue, Nov 19, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Tue, Nov 19, 11:30 AM
Nikerabbit triaged this task as Low priority.Tue, Nov 19, 1:39 PM
Nikerabbit added projects: LPL Essential (LPL Essential 2024 Nov-Dec), Unplanned-Sprint-Work.
Nikerabbit set the point value for this task to 1.
Nikerabbit moved this task from Backlog to Pending Deployment on the LPL Essential (LPL Essential 2024 Nov-Dec) board.
abi_ subscribed.Tue, Nov 19, 4:41 PM
image.png (1×1 px, 181 KB)
image.png (1×1 px, 177 KB)
From translatewiki.netScreenshot from my local machine with Jon's patch deployed.

Other than the tabs, the UI looks good. I believe we can close this task once that is fixed. Thoughts?

Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.Thu, Nov 21, 8:57 AM
abi_ moved this task from Pending Deployment to Ready for dev on the LPL Essential (LPL Essential 2024 Nov-Dec) board.Fri, Nov 22, 1:40 PM

Latest changes are deployed on translatewiki.net: https://translatewiki.net/w/i.php?title=Special%3ASearchTranslations&query=test&language=en&vectornightmode=1

Tabs still not styled for dark mode.

abi_ added a project: patch-welcome.Fri, Nov 22, 1:50 PM
abi_ changed the point value for this task from 1 to 2.
gerritbot added a comment.Fri, Nov 22, 2:28 PM

Change #1094456 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Use LESS variables for Special:Translate

https://gerrit.wikimedia.org/r/1094456

gerritbot added a project: Patch-For-Review.Fri, Nov 22, 2:28 PM
Tacsipacsi subscribed.Sat, Nov 23, 8:18 AM
In T380138#10348061, @abi_ wrote:

Tabs still not styled for dark mode.

Nor the ULS language selector that appears when one clicks on the … button before 143 more languages.

Nikerabbit moved this task from Ready for dev to Needs Review on the LPL Essential (LPL Essential 2024 Nov-Dec) board.Mon, Nov 25, 8:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits