Page MenuHomePhabricator

Notice about page move appears in a wrong language in the page history
Closed, ResolvedPublic

Description

See https://incubator.wikimedia.org/w/index.php?title=Wy/cy/Hafan&action=history

(cur | prev) 19:57, 15 January 2013‎ Leinbach (Talk | contribs | block)‎ m . . (3,986 bytes) (0)‎ . . (Leinbach переименовал страницу Wy/cy в Wy/cy/Hafan: of course if you done it) (undo)


Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=44623

Details

Reference
bz44010

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz44010.

It appears in the user language, to be more precise, instead of the wiki content language.

And the message is logentry-move-move.

The bug is present only when UniversalLanguageSelector is enabled on the wiki.

I noted this earlier today in https://www.mediawiki.org/w/index.php?title=Manual:Pywikipediabot/id&action=history
Note that the entry is in Italian even though I'm using English as interface language, both in my preferences and according to ULS, now and then.

I'll ask Niklas to look into this when the European workday starts on Wednesday.

Initial response by Niklas is: "ULS can't break that stuff"

So please provide some proof that this is caused by UniversalLanguageSelector. If it's not related, we'll at least try to find out what's causing it and notify.

I tested this on a wiki with ULS enabled, and the bug was present for entries created then. I disabled ULS, and I moved a page and the bug did not appear for that entry, so I assumed ULS is somehow the cause.

I tried to test this on test2wiki but it's still on wmf7; on beta labs I get a fatal error which prevents me to save; testwiki, mw.o, meta and wikidata all have ULS, as well as TWN and its subdomains... How to test without a testing infrastructure???

There were two issues in language object construction in RequestContext::newExtranousContext:

  • ULS was always using global request context because correct context was not given
  • Even when I passed request context, cookie data from the primary context was leaking.

Fix in ULS:
https://gerrit.wikimedia.org/r/44231

Fixes in core (should imho be backported to 1.19 and 1.20):
https://gerrit.wikimedia.org/r/44226
https://gerrit.wikimedia.org/r/44227

Since deploying is in a funky state now I ask for help deploying these fixes once they have been reviewed.

(In reply to comment #8)

Fix in ULS:
https://gerrit.wikimedia.org/r/44231

Fixes in core (should imho be backported to 1.19 and 1.20):
https://gerrit.wikimedia.org/r/44226
https://gerrit.wikimedia.org/r/44227

Since deploying is in a funky state now I ask for help deploying these fixes
once they have been reviewed.

These are all merged now. Is this bug fixed?