Page MenuHomePhabricator

Add a contact us link into the english wikipedia footer
Closed, ResolvedPublic

Description

The request is to add the following to the configuration for the english wikipedia

$wgHooks['SkinTemplateOutputPageBeforeExec'][] = function( $sk, &$tpl ) {
        $tpl->set( 'contact', $sk->footerLink( 'contact', 'contact-url' ) );
        $tpl->data['footerlinks']['places'][] = 'contact';
        return true;
};

This would enable us to remove the 'hack' of adding it trough MediaWiki:Wikimedia-copyright that was used the last couple of years.


Version: wmf-deployment
Severity: enhancement

Details

Reference
bz46392

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:35 AM
bzimport set Reference to bz46392.

I've just requested that this li HTML element use an HTML id attribute here: https://en.wikipedia.org/w/index.php?title=MediaWiki_talk:Wikimedia-copyright&oldid=548382142#Minor_code_tweaks.

If this gets re-implemented in server-side logic, it would be nice if the li element specified an HTML id (as all the other li elements in the footer do). I can't tell from the PHP snippet in comment 0 whether the HTML output would include such an HTML id.

Footericons <li> id's are skin dependent. In fact if it's even a li at all is dependent on the skin.

Vector will use #footer-places-contact and MonoBook will use #contact. (Which actually sounds like a problem in itself)

@daniel: The fact that it works like that right now is actually just to preserve backwards compatibility in monobook. I guess we could just special case the 3 old link ids in mono book, so that the other (additional links) can all use the prefix no matter which skin they use.

Related URL: https://gerrit.wikimedia.org/r/59430 (Gerrit Change Ic742664871bbf75778914cc2b823d8b7e0920698)