Page MenuHomePhabricator

Unpatrolled edits not removable from patrollable list when page is deleted
Open, Needs TriagePublic

Description

(Seems not reproducible via UI anymore, but now/still via the API).


Situation: an edit is made that would normally show up in the patrollable list (e.g. go to Recent changes, then click Hide patrolled edits).

After the page it was made on is deleted, the edit remains unpatrolled and in the list. There is no way to patrol this edit now, nor see the change (not an issue for this problem, but a separate issue nonetheless).

There should be a way to patrol edits from either the recent changes list, or to patrol edits on a deleted page. Or patrollable edits that get deleted should be automatically marked as patrolled (not good if you undelete the page and MediaWiki would have had it marked as unpatrolled - not sure if this behavior occurs).

Details

Reference
bz51189

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:45 AM
bzimport added a project: MediaWiki-Patrolling.
bzimport set Reference to bz51189.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Jul 11 2013, 6:29 PM
Sjoerddebruin updated the task description. (Show Details)EditedApr 26 2017, 12:10 PM
Sjoerddebruin added a subscriber: Sjoerddebruin.

Can this be given higher priority? It is also possible to see privacy violations, while most of the sysops think that deleting the page is enough.

Seconding Sjoerddebruins request to give this higher priority. This was never an issue on svwp before, but beginning a few days ago this problem started to occur. Now I have to restore, patrol and redelete pages to get the number of unpatrolled pages to get lowered. I understand that it was given low priority, but it's been several years now and the issue seems to "grow".

Krinkle removed a subscriber: wikibugs-l-list.
Krinkle removed a subscriber: Krinkle.

I can't reproduce this. For me, the entries disappear from RecentChanges after deletion.

Please provide exact details (preferably steps to reproduce, if not at least information about an existing diff that shows the problem).

I'll need:

  • What URL you're on when you see the list after deletion
  • The diff (visible on above) URL (even though it's deleted, I can still see information about the diff in the DB).

This sounds like a serious bug, but we need to confirm. Thanks.

Mattflaschen-WMF raised the priority of this task from Low to Needs Triage.Apr 27 2017, 2:46 AM

Also, your wiki username and what groups you're in.

Nirmos added a subscriber: Nirmos.Apr 27 2017, 4:02 AM

Here's an example: https://sv.wikipedia.org/w/index.php?title=Sofia_Haase (timestamp URL: https://sv.wikipedia.org/w/index.php?title=Special:%C3%85terst%C3%A4ll&target=Sofia+Haase&timestamp=20170425133525)

It was created by an IP, deleted by Luriflax without being patrolled. The API (used by https://sv.wikipedia.org/wiki/MediaWiki:Gadget-RecentChangesUnpatrolledPages.js) still said the page was unpatrolled. Hence, I restored it, patrolled it and deleted it again. Now it does not show up as unpatrolled.

your wiki username

Nirmos

what groups you're in

["sysop", "*", "user", "autoconfirmed"]

Is that good enough or do you need more info?

Oh, and see T162871 which is closely related, but has to do with patrolling when moving pages.

Frisko added a subscriber: Frisko.Apr 27 2017, 1:37 PM

svwiki is now using https://sv.wikipedia.org/wiki/MediaWiki:Gadget-PatrolAndDelete.js as a temporary workaround until this is fixed. It attempts to patrol the page before deleting the page. Admins have gotten tired of restoring, patrolling and redeleting pages. If admins on other projects want help in installing the gadget, or have questions about how it works, feel free to ping me, either here or on-wiki.

Here's an example: https://sv.wikipedia.org/w/index.php?title=Sofia_Haase (timestamp URL: https://sv.wikipedia.org/w/index.php?title=Special:%C3%85terst%C3%A4ll&target=Sofia+Haase&timestamp=20170425133525)
It was created by an IP, deleted by Luriflax without being patrolled. The API (used by https://sv.wikipedia.org/wiki/MediaWiki:Gadget-RecentChangesUnpatrolledPages.js) still said the page was unpatrolled. Hence, I restored it, patrolled it and deleted it again. Now it does not show up as unpatrolled.

The bug report says, "go to Recent changes, then click Hide patrolled edits". Can you only reproduce it via the API, or also on the regular UI (I don't mean gadgets or user scripts)?

If on the UI, please provide the URL.

Ah, well. In that case I have reported a valid problem, but on the wrong task. I think I can live with that =)

Ah, well. In that case I have reported a valid problem, but on the wrong task. I think I can live with that =)

I wasn't saying it's not a bug (it is AFAICT), just asking for more information.

The discrepancy is between Special:NewPages (or more specifically Special:NewPages&hidepatrolled=1) and the API. Sometimes when deleting an unpatrolled page, that page stays unpatrolled according to the API. That means that the API will often report a higher number of unpatrolled pages than Special:NewPages does. So yes, I can only reproduce it via the API.