Page MenuHomePhabricator

VisualEditor: By default, images should not set the alignment
Closed, ResolvedPublic


The VisualEditor explicitly sets all images that are inserted using the dialog as thumb and right. "thumb" is fine, because it's not default, but that's what people want most of the time, but "right" shouldn't be there. "right" is the default for left-to-right Wikipedias, so it's redundant in English. The default for right-to-left Wikipedias is "left", so for these languages this behavior is unexpected.

The best solution is simply not to set the alignment and let the user change if it is needed.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:01 AM
bzimport set Reference to bz51851.

Should we remove the alignment completely (and risk people not putting one in? what's the potential side-effect of that?) or change the 'right' to 'left' on RTL wikis?

Unless I'm missing something, just remove if it's the default anyway. See an example:

  • Bug 51295 has been marked as a duplicate of this bug. ***

Change 75526 had a related patch set uploaded by Mooeypoo:
Image insertion alignment fix

Change 75526 merged by jenkins-bot:
Image insertion alignment fix