Page MenuHomePhabricator

[MLEB] isBrowserSupported is not compatible with MW < 1.21
Closed, ResolvedPublic

Description

ULS in the master version doesn't work with MW < 1.21, because $.client.test returns a different value in MW < 1.21.


Version: unspecified
Severity: normal

Details

Reference
bz52322

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:07 AM
bzimport set Reference to bz52322.
Amire80 created this task.Jul 31 2013, 1:48 PM

Can we have a root cause analysis for this?

This uses $.client.test( blacklist, null, true ), and has that changed in 1.21? Should that be backported to 1.20, or even 1.19?

I think this is the cause:

Along the way, a 3rd parameter was added to "test":

@param {boolean} [exactMatchOnly=false] Only return true if the browser is matched, otherwise

As default is false, and this parameter was not present, we can have different behaviour. The question is what exactly goes wrong on MediaWiki <1.21 for which browser(s)? Our blacklist is IE7 and below ('msie': [['<=', 7]]).

Change 80339 had a related patch set uploaded by Amire80:
Use the old way of checking browser support for MW < 1.22

https://gerrit.wikimedia.org/r/80339

Change 80339 merged by jenkins-bot:
Use the old way of checking browser support for MW < 1.22

https://gerrit.wikimedia.org/r/80339