Page MenuHomePhabricator

Gerrit should feature customizable message on Login page (No 'Forgot password' link in the gerrit login page.)
Closed, ResolvedPublicFeature

Description

The login page showing no 'Forgot Password' link

The gerrit login page doesn't have an option 'Forgot password' or 'reset password' so as to reset the password, if lost.
This is an essential feature, which almost all login pages should have.

https://gerrit.wikimedia.org/r/login/


Version: wmf-deployment
Severity: enhancement

Attached:

snapshot1.png (768×1 px, 95 KB)

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:33 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz58205.
bzimport added a subscriber: Unknown Object (MLST).

Isn't that because we are using LDAP for authentication and all forgotten passwords need to be recovered using labsconsole a.k.a. wikitech?

I could only imagine a link that sends you to https://wikitech.wikimedia.org/wiki/Special:PasswordReset

(In reply to comment #1)

Isn't that because we are using LDAP for authentication and all forgotten
passwords need to be recovered using labsconsole a.k.a. wikitech?

I could only imagine a link that sends you to
https://wikitech.wikimedia.org/wiki/Special:PasswordReset

Shouldn't the gerrit login page have a link to the same too to fit user convenience?

Peachey88 renamed this task from No 'Forgot password' link in the gerrit login page. to Gerrit should feature customizable message on Login page (No 'Forgot password' link in the gerrit login page.).Jul 18 2016, 1:37 PM
Peachey88 added a project: Upstream.
Peachey88 removed a subscriber: wikibugs-l-list.
demon raised the priority of this task from Low to Medium.Feb 14 2017, 9:58 PM

This can't be too hard. Let's see if we can get something upstreamed. Making it generally-configurable text (preferably w/ HTML) would be ideal, as then you could include login instructions (eg: "Use your LDAP credentials, which are the same as Wikitech") in addition to containing a link for password resetting.

You may need to add the support for both polygerrit and gwt ui.

Upstream are more in favour of changes for polygerrit then gwt ui.

It seems polygerrit uses the default login screen that gerrit provides.

What we could do is convert https://github.com/GerritCodeReview/gerrit/blob/461cff743afa2858e8f3ab7c51aacc698ab0fa5e/gerrit-httpd/src/main/resources/com/google/gerrit/httpd/auth/ldap/LoginForm.html into a soy template which would allow us to introduce a new variable and if we set it in gerrit with the forgotten link then it will show.

I would like to get upstream to support logging in / registering through rest api. That will allow us to get polygerrit to implement registering and creating accounts elements :).

I think we could potentially add support for this upstream if we follow how they do it for the error message.

We should add a new gerrit config that add a forgetPassword link.

Also side note, im updating the ui here https://gerrit.wikimedia.org/r/#/c/402665/ (Author of css / javascript is markusguenther).

It should really just point you to wikitech.wikimedia.org's page about reseting your password instead?

Yup, now that we have the refreshed login page im just going to add the link :)

Nowadays we have a custom login page with two links beneath it Code of Conduct and Privacy Policy. I guess we can add one to https://wikitech.wikimedia.org/wiki/Special:PasswordReset . That is defined by modules/gerrit/files/homedir/review_site/etc/GerritSiteFooter.html but that also reflects on every pages so it is not ideal.

Or we can use a css hack such as the one that adds the photo author name on the login page. That is defined in modules/gerrit/files/homedir/review_site/etc/GerritSite.css:


html.loginParent .gerritBody:after {
    content: "Image by Damien Boilley";
}

But that does not support HTML. So I guess we would need some javascript.

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 12:23 PM

The Sign Up link does send people to Wikitech: https://wikitech.wikimedia.org/w/index.php?title=Special:CreateAccount&returnto=Gerrit/NewUser , so at least to create an account people are directed to the source of trust.

Gerrit theme configuration is described at https://gerrit.wikimedia.org/r/Documentation/config-themes.html GerritSiteFooter.html is apparently only used for the login page and "the internally managed Gitweb servlet" (which we are not using).

I will add a link to https://wikitech.wikimedia.org/wiki/Special:PasswordReset

Change 766781 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/puppet@production] gerrit: on login page add link to reset password

https://gerrit.wikimedia.org/r/766781

Change 766781 merged by Dzahn:

[operations/puppet@production] gerrit: on login page add link to reset password

https://gerrit.wikimedia.org/r/766781

Screenshot from 2022-02-28 09-08-12.png (215×436 px, 45 KB)
deployed. login page now has the reset password link.