Page MenuHomePhabricator

FlaggedRevs reviews should be visible in CheckUser
Open, MediumPublicFeature

Description

We got an example of the user which has last edit (proper contribution) few months ago, but there are entries in the FlaggedRevs review log which indicate the user is reviewing changes.

When doing "get IP addresses" or "get edits" the message is shown:

No matches found. Last edit was on 5 January 2014 at XX:YY.

Either FlaggedRevs is not logging to CheckUser or CU query is broken. Need to recreate the case on the test wiki.

Filing under "Extension:CheckUser" for now unless proven innocent.

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:19 AM
bzimport added a project: CheckUser.
bzimport set Reference to bz59677.
bzimport added a subscriber: Unknown Object (MLST).

This is because FlaggedRevs does not log to RecentChanges. CheckUser only picks up RecentChanges by default. AbuseFilter (probably among other extensions) goes out of it's way to specifically log stuff to CheckUser directly if it's not going to make a RecentChange entry.

Dreamy_Jazz lowered the priority of this task from High to Medium.Jun 6 2022, 7:47 PM
Dreamy_Jazz subscribed.

I'm reviewing this and I don't think this needs to be high.

I've verified after getting a testing instance of FlaggedRevs with the enwiki configuration set, that the stability log entries are still not sent to CheckUser.

Tacsipacsi changed the subtype of this task from "Task" to "Bug Report".Jun 19 2022, 6:15 PM
Tacsipacsi updated the task description. (Show Details)
Tacsipacsi subscribed.

Change 806562 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Log FlaggedRevs reviews in CheckUser

https://gerrit.wikimedia.org/r/806562

Change 806937 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[integration/config@master] Add FlaggedRevs to phan dependencies for CheckUser

https://gerrit.wikimedia.org/r/806937

Change 807059 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Log FlaggedRevs reviews in CheckUser

https://gerrit.wikimedia.org/r/807059

Change 806937 merged by jenkins-bot:

[integration/config@master] Add FlaggedRevs to phan dependencies for CheckUser

https://gerrit.wikimedia.org/r/806937

Dreamy_Jazz renamed this task from FlaggedRevs reviews are not visible in CheckUser to FlaggedRevs reviews should be visible in CheckUser.Dec 29 2022, 11:18 PM
Dreamy_Jazz changed the subtype of this task from "Bug Report" to "Feature Request".

Moving to a feature request as this is not a bug per se.

Change 873779 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[integration/config@master] Add FlaggedRevs to the dependencies list for CheckUser

https://gerrit.wikimedia.org/r/873779

Change 873779 merged by jenkins-bot:

[integration/config@master] Add FlaggedRevs to the dependencies list of CheckUser

https://gerrit.wikimedia.org/r/873779

Mentioned in SAL (#wikimedia-releng) [2022-12-30T15:34:14Z] <hasharAway> Reloaded Zuul for https://gerrit.wikimedia.org/r/c/integration/config/+/873779/ Add FlaggedRevs to the dependencies list of CheckUser # T61677

It's not really needed. FR reviews trigger a log action. Once we have logs in CU, we get FR reviews for free.

@Ladsgroup, a bit confused by this. CheckUser already records logs events published to recent changes, but these are not recorded by CheckUser. As such I suspect these are not published to recent changes, and so this will be needed unless there is a plan to record all log entries even if they are not published to recent changes.

Change 807059 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Log FlaggedRevs reviews in CheckUser

Reason:

https://gerrit.wikimedia.org/r/807059