Page MenuHomePhabricator

Core skins should initialise and include like other skins/extensions do
Closed, ResolvedPublic

Description

Currently the core skins are set up such that they have a skinname.php file and a skinname directory and are automatically included as options if the skinname.php file is found in the main directory, but this setup doesn't scale.

Skins shouldn't have these loose files. All of the skin files should be in the skin's directory, and all skins should be included and initialised much like extensions are. Many non-core skins already do this.

Two issues with setting this up:

  • There would need to be some sort of default to account for the transition on existing wikis.
  • There would need to be a selection on install for which found skins will be made available, probably much the same as how found extensions can be selected to be enabled.

Version: 1.23.0
Severity: enhancement

Details

Reference
bz60453

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:03 AM
bzimport set Reference to bz60453.
Isarra created this task.Jan 26 2014, 11:45 PM

This is now largely done! https://gerrit.wikimedia.org/r/118345 https://gerrit.wikimedia.org/r/135413 https://gerrit.wikimedia.org/r/138795

However, there is still a lot of code that expects Vector to be present, or hardcoding things for Vector.

I'm going to mark this as FIXED for now. There is more work that can be done to make the situation better (and I am doing some of it), but the problem as described is comment 0 looks solved to me :)