remove $wgContLang and armourMath
Closed, ResolvedPublic

Description

Author: physik

Description:
armourMath does:

  • Armour rendered math against conversion.
  • Escape special chars in parsed math text. (in most cases are img elements) *
  • @param $text String: text to armour against conversion
  • @return String: armoured text where { and } have been converted to
  • { and }

*/
public static function armourMath( $text ) {
convert '-{' and '}-' to '-{' and '}-' to prevent
any unwanted markup appearing in the math image tag.
$text = strtr( $text, array( '-{' => '-{', '}-' => '}-' ) );
return $text;
}
I have to proposals:
A) (the far reaching proposal):
Replace amourMath by using the marker type nowiki
If there are arguments not to remove amourMath the alternative is
B) (remove $wgContLang):
see https://gerrit.wikimedia.org/r/#/c/87519/1


Version: master
Severity: normal

Details

Reference
bz60799
bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz60799.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Feb 3 2014, 11:21 PM

Change 111119 had a related patch set uploaded by Physikerwelt:
remove armourMath

https://gerrit.wikimedia.org/r/111119

Change 87519 had a related patch set uploaded by Physikerwelt:
Remove one $wgContLang usage.

https://gerrit.wikimedia.org/r/87519

physik wrote:

Please be aware that armourMath still belongs to core and not to extension math.

Change 87519 abandoned by Liangent:
Remove one $wgContLang usage.

Reason:
In favor of https://gerrit.wikimedia.org/r/#/c/111119/

https://gerrit.wikimedia.org/r/87519

Change 111119 had a related patch set uploaded by Frédéric Wang:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/111119

Change 111119 abandoned by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

Reason:
restructure changes

https://gerrit.wikimedia.org/r/111119

Change 112324 had a related patch set uploaded by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/112324

Change 116458 had a related patch set uploaded by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/116458

Change 116458 abandoned by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

Reason:
wrong branch

https://gerrit.wikimedia.org/r/116458

physik wrote:

I think this should go to math 2.0
Please do a code review at
https://gerrit.wikimedia.org/r/#/c/112324/
You can ignore the failed test for now...

Change 112324 merged by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/112324

Change 111119 restored by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/111119

Change 111119 had a related patch set uploaded by Physikerwelt:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/111119

Change 111119 merged by jenkins-bot:
remove armourMath and wgContLang (bug 60799)

https://gerrit.wikimedia.org/r/111119