The test TestVideoTranscode::testTranscodeJobs with data set #1 (array('video/webm', '/Users/amusso/projects/mediawiki/extensions/TimedMediaHandler/tests/phpunit/media/shuttle10seconds.1080x608.webm', 699018, 1080, 608, 'VIDEO', 522142, 29.97))
Fails with:
Undefined property: WebVideoTranscodeJob::$id
Example run https://integration.wikimedia.org/ci/job/mwext-TimedMediaHandler-testextensions-master/5/console
Version: master
Severity: normal
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| tests: Add `@covers WebVideoTranscodeJob` to VideoTranscodeTest | mediawiki/extensions/TimedMediaHandler | master | +19 -16 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Gilles | T63875 TimedMediaHandler unit tests are failing with current mediawiki/core | |||
| Open | None | T63878 TestVideoTranscode::testTranscodeJobs fails Undefined property: WebVideoTranscodeJob::$id |
And:
Failed asserting that false is true.
Change 115304 had a related patch set uploaded by Hashar:
Ignore TestVideoTranscode::testTranscodeJobs
I get this error
20:36:15 1) TestVideoThumbnail::testApiThumbnails with data set #0 (array('application/ogg', '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/TimedMediaHandler/tests/phpunit/media/test5seconds.electricsheep.300x400.ogv', 301477, 400, 300, 'VIDEO', 452216, 30))
20:36:15 Failed asserting that false is true.
20:36:15
20:36:15 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/TimedMediaHandler/tests/phpunit/TestVideoThumbnail.php:39
20:36:15 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:137
20:36:15
20:36:15 2) TestVideoThumbnail::testApiThumbnails with data set #1 (array('video/webm', '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/TimedMediaHandler/tests/phpunit/media/shuttle10seconds.1080x608.webm', 699018, 1080, 608, 'VIDEO', 522142, 29.97))
20:36:15 Failed asserting that false is true.
20:36:15
20:36:15 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/TimedMediaHandler/tests/phpunit/TestVideoThumbnail.php:39
20:36:15 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:137
@brion and @TheDJ can I add you since this is a broken test that is disabled but should be re enabled.
Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)
/tests/phpunit/VideoTranscodeTest.php still exists.
VideoTranscodeTest::testTranscodeJobs still exists.
And, it still has @group Broken and "Broken as per bug 61878" in its doc block.
I tried running it in CI just in case, since this seems to be the only test for non-trivial parts of WebVideoTranscode and WebVideoTranscodeJob. But, it still fails:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/1099241
There was 1 error:
1) VideoTranscodeTest::testTranscodeJobs with data set #2 (array('audio/midi', '/workspace/src/extensions/Tim...r.midi', 262, 'AUDIO'))
Undefined index: bandwidth
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/VideoTranscodeTest.php:44
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:338
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
Logs generated by test
--
There were 2 failures:
1) VideoTranscodeTest::testTranscodeJobs with data set #0 (array('application/ogg', '/workspace/src/extensions/Tim...00.ogv', 301477, 400, 300, 'VIDEO', 449642, 30))
Failed asserting that false is true.
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/VideoTranscodeTest.php:74
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:338
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
Logs generated by test
2) VideoTranscodeTest::testTranscodeJobs with data set #1 (array('video/webm', '/workspace/src/extensions/Tim...8.webm', 699018, 1080, 608, 'VIDEO', 522142, 29.97))
Failed asserting that false is true.
/workspace/src/extensions/TimedMediaHandler/tests/phpunit/VideoTranscodeTest.php:74
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:338
phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106Change #1099241 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/extensions/TimedMediaHandler@master] tests: Add `@covers WebVideoTranscodeJob` to VideoTranscodeTest
Did some minor playing around as well and I fixed the midi issue, but now there are 3 failures. Still not too far off, I might pick it up at some point.
1) VideoTranscodeTest::testTranscodeJobs with data set #0 (array('application/ogg', '/workspace/src/extensions/Tim...00.ogv', 301477, 400, 300, 'VIDEO', 449642, 30))
video has ogg
Failed asserting that false is true.
2) VideoTranscodeTest::testTranscodeJobs with data set #1 (array('video/webm', '/workspace/src/extensions/Tim...8.webm', 699018, 1080, 608, 'VIDEO', 522142, 29.97))
video has ogg
Failed asserting that false is true.
3) VideoTranscodeTest::testTranscodeJobs with data set #2 (array('audio/midi', '/workspace/src/extensions/Tim...r.midi', 262, 'AUDIO', 218))
Number of jobs executed must be at least 1
Failed asserting that 0 is equal to 1 or is greater than 1.