Page MenuHomePhabricator

#p-logo should be at the top of <body>
Closed, DuplicatePublic

Description

On an image-heavy page like https://en.wikipedia.org/wiki/Switzerland, browsers hit the limit of maximum concurrent connections. It takes a very long time before all images are retrieved. This fact could have been made invisible if the assets required for rendering the top portion of the page were loaded first. Instead, we load the logo last, so it appears very late, and when it does it causes a reflow of the sidebar. Blech.


Version: unspecified
Severity: normal

Details

Reference
bz65286

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:08 AM
bzimport set Reference to bz65286.
bzimport added a subscriber: Unknown Object (MLST).

This could be solved by doing something like https://gerrit.wikimedia.org/r/#/c/98356/ (basically creates a separate RL module for the logo – still pending review :( ) and setting the new module to position=>top?

On second thought, maybe we should actually put #p-logo at the beginning of page HTML… I ended up doing that in [[mw:Skin:Example]] as a simple, sane way of rendering the logo.

All other things equal, we should probably figure out which is the best from accessibility standpoint. A <img src=… alt="{{SITENAME}} logo"> instead of the weirdness we have now might actually make sense?

(I'm going to move this to Vector component because I bet no one wants to change all other skins. Many of them don't even display the logo.)

Suggest declining. Loading the content before the rest of the UI was a concious design decision.

Jdlrobson changed the task status from Open to Stalled.Feb 5 2016, 12:21 AM
Jdlrobson subscribed.

Seems like there is no consensus so marking as stalled.. how can we move this forward?