Page MenuHomePhabricator

$wgDefaultUserOptions['rememberpassword'] = 1 stopped working in 1.23
Open, MediumPublic

Description

Author: jlemley

Description:
Upon upgrading from 1.21 to 1.23, I noticed that the (now labeled) "Keep me logged in" checkbox is no longer checked by default.

I saw that in bug 52342 the "Remember my login" user preference was removed since it was redundant with the login page. Would that preference be needed in order for "$wgDefaultUserOptions['rememberpassword'] = 1" to work in LocalSettings?


Version: 1.23.0
Severity: normal
See Also: T54342: Remove "Remember my login"-option from the preferences

Details

Reference
bz67133

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:25 AM
bzimport set Reference to bz67133.
bzimport added a subscriber: Unknown Object (MLST).

Change 143908 had a related patch set uploaded by Rohan013:
$wgDefaultUserOptions['rememberpassword'] now sets the value of "keep me logged in" checkbox

https://gerrit.wikimedia.org/r/143908

This is due to the user preference being removed in https://gerrit.wikimedia.org/r/94614.

What does everybody think about how to handle this?

jlemley wrote:

Patch applied and confirmed working in REL1_23. Whether this is the final solution or not I'll leave to the experts, but this will work as a workaround for now.

Thanks Rohan!

I understand that the user preference was removed.

But why can't we repurpose this variable for the login form ? After all, it is still doing the same job it was designed for, just for a different component

IMO I think this is functionality that we should have, so that leaves us with a couple of options:

  1. Make a new global, backport it to 1.23, and indicate in the release notes how to work around the removed preference.
  1. Restore the user preference, but set it to an immutable preference type so that users cannot change it and it exists only as a default.

I really hate adding new globals, but at the same time it doesn't really feel right adding a user preference that is not actually a user preference. However, option 2 does allow seamless upgrading and means admins will not experience any change in functionality.

Removing backport flag since there's nothing to backport yet...