Page MenuHomePhabricator
Create Task
Maniphest T73072

Flow: Submitting 1 reply will delete any other reply-text-areas currently open in the same Topic
Closed, ResolvedPublic
Actions

Description

screenshot

If I have 2 (or more) reply areas open and with text in them, when I submit 1, the other should remain open.

Currently, if I compose 2 replies at once (see screenshot), and click "Reply" to save 1 of them, the other vanishes completely.

At minimum, I should get a warning that I'm going to lose unsaved changes. (I do have the preference checked, for "Warn me when I leave an edit page with unsaved changes"). But really it should just save the 1st post, and leave the 2nd open for further editing. It used to do this.

Version: unspecified
Severity: major

Attached:

Screenshot_from_2014-09-19_14:05:52.png (883×1 px, 99 KB)

Details

Reference
bz71072
SubjectRepoBranchLines +/-
Autosave commentsmediawiki/extensions/Flowmaster+137 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:58 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz71072.
• bzimport added a subscriber: Unknown Object (MLST).
Quiddity created this task.Sep 19 2014, 9:15 PM
• DannyH added a comment.Sep 24 2014, 6:07 PM

added to backlog: https://trello.com/c/0MPoG7iv

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:41 AM
EBernhardson triaged this task as Low priority.Feb 19 2015, 6:46 PM

This only applies within the same topic. Its annoying to fix with the current architecture, marking this as low priority for now.

Quiddity merged a task: T93576: when creating several reply posts in Flow, submitting one deletes all the rest.Mar 23 2015, 5:46 PM
Quiddity added subscribers: IKhitron, Amire80, Aklapper.
IKhitron added a comment.Mar 23 2015, 5:49 PM

If it as annoying to fix it, maybe you can at least avoid multiple edit at all?
Thanks.

EBernhardson added a comment.Mar 23 2015, 5:52 PM

We might want to consider some sort of autosaving like phabricator does, it wont solve the issue but it will make the current experience better.

Quiddity added a comment.Mar 23 2015, 5:52 PM

copy from merged bug:

  1. Go to a Flow board with some existing comments.
  2. Start writing a reply to one of them. Don't submit.
  3. Start writing a reply to another. Submit it.

Observed: The first comment is lost.

This probably shouldn't happen. I expect one comment to be submitted and the the other two to stay and wait for submission. (Auto-saving them as drafts would make a lot of people happy about not losing their work. Quora does it.)

Quiddity mentioned this in T93612: Auto-save post boxes locally.Mar 23 2015, 5:59 PM
• Mattflaschen-WMF added a comment.Mar 26 2015, 10:18 PM
In T73072#1141964, @EBernhardson wrote:

We might want to consider some sort of autosaving like phabricator does, it wont solve the issue but it will make the current experience better.

Tracked as T93612: Auto-save post boxes locally

Quiddity renamed this task from Flow: Submitting 1 reply will delete any other reply-text-areas currently open to Flow: Submitting 1 reply will delete any other reply-text-areas currently open in the same Topic.Aug 19 2015, 10:05 PM
Quiddity set Security to None.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 19 2015, 10:05 PM
Catrope closed this task as Resolved.Aug 19 2015, 11:55 PM
Catrope claimed this task.
Catrope subscribed.

Fixed by the recent editor rewrite

Catrope reopened this task as Open.Aug 19 2015, 11:56 PM

Sorry -- this wasn't fixed.

Catrope moved this task from Untriaged to Near-Term Interest on the Collaboration-Team-Triage board.Aug 19 2015, 11:57 PM
• DannyH moved this task from Near-Term Interest to Freezer on the Collaboration-Team-Triage board.Aug 21 2015, 5:25 PM
• ksmith subscribed.Nov 24 2015, 5:57 PM

+1 to either preventing editing multiple replies at the same time, or to warning the user that other replies in progress will be lost. That is, assuming a full fix is not going to happen soon. Losing data is a really poor user experience and should be fixed right away.

• ksmith mentioned this in T119539: Replying in Flow refreshes the page to hide all indications of other unread messages.Nov 24 2015, 6:15 PM
• Mattflaschen-WMF mentioned this in T119572: Hide all other reply links and reply text boxes when a reply is open.Nov 24 2015, 10:30 PM
EBernhardson unsubscribed.Jul 18 2018, 7:00 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 7:00 PM
SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 5:57 PM
gerritbot added a comment.Apr 20 2019, 1:11 PM

Change 505392 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] Autosave comments

https://gerrit.wikimedia.org/r/505392

gerritbot added a project: Patch-For-Review.Apr 20 2019, 1:11 PM
gerritbot added a comment.Apr 22 2019, 7:27 PM

Change 505392 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Autosave comments

https://gerrit.wikimedia.org/r/505392

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 22 2019, 8:00 PM
Etonkovidova closed this task as Resolved.Apr 25 2019, 9:32 PM
Etonkovidova subscribed.

Resolved as per T93612: Auto-save post boxes locally.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL