Page MenuHomePhabricator

VisualEditor: “Uncaught Error: Unable to parse title” when entering "Talk:" as a template
Closed, ResolvedPublic

Description

screenshot

Environment- test2, beta, production.

1> Select template. In the Add a Template dialog when the cursor is in the input box, hit spacebar.
2> The Add a Template button becomes active.click on it.
JS console error-“Uncaught Error: Unable to parse title”.

Screenshot attached.


Version: unspecified
Severity: minor

Attached:

Details

Reference
bz71998

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz71998.
Swainr created this task.Oct 13 2014, 3:29 PM

Confirmed - test2, Betalabs, produciton(Chrome, FF)

The following error is dispayed:
Uncaught Error: Unable to parse title VM5621:36
TitleVM5621:36

ve.dm.MWTemplateModel.newFromNameload.php?debug=false&lang=en&modules=ext.disambiguator.visualEditor%7Cext.math.visualEditor%7Cext.v…:257

ve.ui.MWTemplatePlaceholderPage.onAddTemplateload.php?debug=false&lang=en&modules=ext.disambiguator.visualEditor%7Cext.math.visualEditor%7Cext.v…:277

oo.EventEmitter.emitVM5625:7

OO.ui.ButtonWidget.onClickload.php?debug=false&lang=en&modules=ext.visualEditor.core%2CviewPageTarget%7Cmediawiki.feedback%7C…:615

jQuery.event.dispatchload.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141017T2…:65

elemData.handleload.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141017T2…:60

gerritadmin wrote:

Change 168531 had a related patch set uploaded by SuchetaG:
Add template button remains disabled when entering space as a template

https://gerrit.wikimedia.org/r/168531

gerritadmin wrote:

Change 168531 merged by jenkins-bot:
Add template button remains disabled when entering space as a template

https://gerrit.wikimedia.org/r/168531

(In reply to Gerrit Notification Bot from comment #3)

Change 168531 merged by jenkins-bot:
Add template button remains disabled when entering space as a template

https://gerrit.wikimedia.org/r/168531

This fixes the issue as filed: when you type a space, the Add template button remains disabled. However, there are still a few values that you can use to make it crash, like "Talk:" (I was expecting "|" to break to, but surprisingly it doesn't because of unrelated evil hacks).

That is part of a larger issue though, which I've filed as bug 72468.

gerritadmin wrote:

Change 170071 had a related patch set uploaded by SuchetaG:
Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle()

https://gerrit.wikimedia.org/r/170071

gerritadmin wrote:

Change 170071 merged by jenkins-bot:
Replacing MWTitleInputWidget.getValue() with MWTitleInputWidget.getTitle()

https://gerrit.wikimedia.org/r/170071

Fixed for validating template titles - verified in betalabs FF

the fix is a part of 71249.

Verified the fix in production along with the bug fix for 71249.