WikiPage.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Nov 15 18:34:47 mw1029: #012Notice: Undefined property: stdClass::$newContent in /srv/mediawiki/php-1.25wmf7/includes/page/WikiPage.php on line 2095

Details

Reference: bz73474

	Subject	Repo	Branch	Lines +/-
	Use isset in WikiPage prepareContentForEdit for newContent	mediawiki/core	master	+1 -1

Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:46 AM

• bzimport added a project: MediaWiki-General.

• bzimport set Reference to bz73474.

• bzimport added a subscriber: Unknown Object (MLST).

Reedy created this task.Nov 15 2014, 6:44 PM

• mmodell added a project: Wikimedia-production-error.Feb 16 2015, 7:06 PM

• mmodell subscribed.

Krenair subscribed.Mar 21 2015, 2:46 AM

This makes no sense. The only place that we set mPreparedEdit (other than to false, which is checked in this case) also sets ->newContent on it...

That said...

krenair@tin:/srv/mediawiki-staging/php-1.25wmf21$ grep "mPreparedEdit =" extensions/* -R
extensions/FlaggedRevs/backend/FlaggableWikiPage.php:		$this->mPreparedEdit = $page->mPreparedEdit;
krenair@tin:/srv/mediawiki-staging/php-1.25wmf21$

• demon raised the priority of this task from Medium to High.Jun 11 2015, 4:30 PM

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.

• demon added subscribers: • demon, aaron.

• demon lowered the priority of this task from High to Medium.Jun 11 2015, 4:38 PM

Krinkle renamed this task from PHP notice in hhvm.log: Undefined property: stdClass::$newContent in includes/page/WikiPage.php to PHP Notice: Undefined property: stdClass::$newContent in includes/page/WikiPage.php.Nov 14 2015, 2:03 AM

Krinkle updated the task description. (Show Details)

Krinkle set Security to None.

Krinkle removed a subscriber: • wikibugs-l-list.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2015, 2:03 AM

Notice: Undefined property: stdClass::$newContent in /srv/mediawiki/php-1.27.0-wmf.6/includes/page/WikiPage.php on line 2067

Still happen regularly (13x in the last hour).

Yep, still happening...

Undefined property: stdClass::$newContent in /srv/mediawiki/php-1.27.0-wmf.7/includes/page/WikiPage.php on line 2067

Still happening in MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3))

Krinkle unsubscribed.Jun 2 2016, 7:47 PM

Change 301636 had a related patch set uploaded (by Addshore):
Use isset in WikiPage prepareContentForEdit for newContent

https://gerrit.wikimedia.org/r/301636

Addshore moved this task from Dec2019/1.35.wmf.10+ to Mar 2019 / 1.33wmf20-23 on the Wikimedia-production-error board.Jul 28 2016, 4:27 PM

Change 301636 merged by jenkins-bot:
Use isset in WikiPage prepareContentForEdit for newContent

https://gerrit.wikimedia.org/r/301636

Should now be fixed.

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).Jul 28 2016, 5:00 PM

I don't think sprinkling isset is a good approach in the long run.

In T75474#2504366, @Nikerabbit wrote:

I don't think sprinkling isset is a good approach in the long run.

That looks like the exact intention of the check.

Krinkle moved this task from Mar 2019 / 1.33wmf20-23 to Resolved on the Wikimedia-production-error board.Mar 19 2019, 3:46 PM

Restricted Application added a project: User-Addshore. · View Herald TranscriptMar 19 2019, 3:46 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM

PHP Notice: Undefined property: stdClass::$newContent in includes/page/WikiPage.phpClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Event Timeline

PHP Notice: Undefined property: stdClass::$newContent in includes/page/WikiPage.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions