Page MenuHomePhabricator
Create Task
Maniphest T76076

[Regression wmf10] Cannot open any inspectors, they just flicker and get closed
Closed, ResolvedPublic
Actions

Description

Go to Insert>Comment

The comment inspector does not open and closes immediately

Details

SubjectRepoBranchLines +/-
Fix window manager logicVisualEditor/VisualEditorwmf/1.25wmf10+31 -14
Fix window manager logicVisualEditor/VisualEditormaster+31 -14
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Nov 26 2014, 8:07 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen changed Security from none to None.
Ryasmeen subscribed.

Getting same behavior for Gallery too

Ryasmeen renamed this task from [Regression pre-wmf10] Cannot open comment box, it just flickers and gets closed to [Regression pre-wmf10] Cannot open comment/gallery/special character inspector, they just flicker and get closed.Nov 26 2014, 8:13 PM
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Nov 26 2014, 8:15 PM
Jdforrester-WMF renamed this task from [Regression pre-wmf10] Cannot open comment/gallery/special character inspector, they just flicker and get closed to [Regression wmf10] Cannot open comment/gallery/special character inspector, they just flicker and get closed.Nov 26 2014, 9:23 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added projects: VisualEditor-MediaWiki, VisualEditor-EditingTools.
Jdforrester-WMF merged a task: T76134: Insert special character broken.Nov 29 2014, 2:22 AM
Jdforrester-WMF added subscribers: zeljkofilipin, Amire80.
Jdforrester-WMF renamed this task from [Regression wmf10] Cannot open comment/gallery/special character inspector, they just flicker and get closed to [Regression wmf10] Cannot open any inspectors, they just flicker and get closed.Nov 29 2014, 2:39 AM
Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.
Jdforrester-WMF merged a task: T76087: [Regression wmf10] cannot open Formula inspector .
Jdforrester-WMF added subscribers: Etonkovidova, Esanders.
gerritbot added a project: Patch-For-Review.Dec 1 2014, 2:16 PM

Change 176663 had a related patch set uploaded (by Esanders):
Fix window manager logic

https://gerrit.wikimedia.org/r/176663

Patch-For-Review

Jdforrester-WMF moved this task from External and Administrivia to Blocked on the VisualEditor board.Dec 1 2014, 4:58 PM
Jdforrester-WMF merged a task: T76087: [Regression wmf10] cannot open Formula inspector .Dec 1 2014, 5:10 PM
Jdforrester-WMF added a subscriber: Swainr.
gerritbot added a comment.Dec 1 2014, 6:28 PM

Change 176698 had a related patch set uploaded (by Jforrester):
Fix window manager logic

https://gerrit.wikimedia.org/r/176698

Patch-For-Review

gerritbot added a comment.Dec 1 2014, 6:31 PM

Change 176663 merged by jenkins-bot:
Fix window manager logic

https://gerrit.wikimedia.org/r/176663

Esanders mentioned this in Unknown Object (Diffusion Commit).Dec 1 2014, 6:31 PM
• Catrope moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Dec 1 2014, 6:43 PM
gerritbot added a comment.Dec 1 2014, 6:53 PM

Change 176698 merged by jenkins-bot:
Fix window manager logic

https://gerrit.wikimedia.org/r/176698

Jdforrester-WMF mentioned this in Unknown Object (Diffusion Commit).Dec 1 2014, 6:54 PM
Jdforrester-WMF closed this task as Resolved.Dec 2 2014, 12:07 AM
Jdforrester-WMF added projects: WMF-deploy-2014-12-03-(1.25wmf11), WMF-deploy-2014-11-26-(1.25wmf10).
zeljkofilipin added a comment.EditedDec 2 2014, 9:22 AM

This is still broken for insert special character at beta:

http://en.wikipedia.beta.wmflabs.org/wiki/Language_Screenshot?veaction=edit

Tested on the latest Chrome and Firefox.

zeljkofilipin added a comment.Dec 2 2014, 5:48 PM

Probably related to T76097.

Ryasmeen added a comment.Dec 2 2014, 6:45 PM

I am still getting this issue for Gallery,Special Character,comment and while opening math inspector for an existing formulae

Ryasmeen reopened this task as Open.Dec 2 2014, 6:45 PM
Jdforrester-WMF merged tasks: T76420: [Regression wmf10] Editing a formula causes the inspector to close immediately, T76507: [Regression pre-wmf11] Cannot edit inserted Formulae.Dec 2 2014, 6:56 PM
Jdforrester-WMF added subscribers: Jdforrester-WMF, • Catrope, Aklapper.
In T76076#802027, @zeljkofilipin wrote:

Probably related to T76097.

Don't think so; looks like my testing of four inspectors wasn't enough. :-(

Jdforrester-WMF moved this task from FY 18-19 Q3/Q4 to Blocked on the VisualEditor board.Dec 2 2014, 7:12 PM
Esanders added a comment.Dec 2 2014, 7:28 PM

Definitely fixed in master. Probably has pulled through to beta labs.

Ryasmeen added a comment.Dec 2 2014, 8:39 PM

Now fixed in Betalabs for all inspectors.

Ryasmeen moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Dec 2 2014, 8:40 PM
Ryasmeen closed this task as Resolved.Dec 2 2014, 8:47 PM
Ryasmeen added a project: Verified-in-Phase0.Dec 2 2014, 11:55 PM

Verified in test2

Ryasmeen added a comment.Dec 4 2014, 12:11 AM

Verified in en.wiki

Ryasmeen added a project: Verified-in-Phase2.Dec 4 2014, 12:11 AM
Jdforrester-WMF removed a project: Patch-For-Review.Dec 4 2014, 9:48 PM
Esanders mentioned this in rGVEDeed8fcb877f6: Fix window manager logic.Mar 3 2015, 7:37 PM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Aug 5 2015, 12:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits