Page MenuHomePhabricator

Allow continuing one or more fully-complete uploads that are in stashed mode
Open, MediumPublic


UploadWizard stores uploaded files in the upload stash, then proceeds to collect metadata for them from the user. That sometimes breaks and the upload process has to be restarted. When that happens, there is no reason why the user should have to reupload the file (we could be talking about huge video files) which is already sitting there in the stash.

One possible implementation: in the upload step, if there are files in the stash, show a warning to the user saying "there are aborted uploads, do you wish to continue them?" and then allow him to pick files from the stash. (This does not work for Flickr uploads where the URL is a metadata source as well, although not sure if the stash is used at all for those.)

See also T77826.

Event Timeline

Steinsplitter moved this task from Incoming to Uploading on the Commons board.
Jdforrester-WMF triaged this task as Low priority.Sep 4 2015, 6:56 PM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptSep 4 2015, 6:56 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 7:04 PM
Jdforrester-WMF renamed this task from Add the upload stash as a file source to UploadWizard to Allow continuing one or more fully-complete uploads that are in stashed mode .Sep 14 2015, 11:50 PM
Jdforrester-WMF set Security to None.

I like this idea, but I see at least two blockers:

  • We don't purge the upload stash of files for which the user intentionally cancelled the upload, by clicking the "Remove" button in the 'Upload' step. In fact it seems that there is no API for this.
  • There seems to be no way to recover the original filename. I'm not sure if UploadWizard is not passing it correctly, or if it can't currently be stored in the stash at all.
brion added a subscriber: brion.Oct 25 2015, 3:23 AM

Inability to recover is really painful when something stalls or fails after uploading a couple gigs worth of video files... have to start all over and reupload everything from scratch.

MarkTraceur raised the priority of this task from Low to Medium.Dec 11 2015, 5:53 PM

Change 258484 had a related patch set uploaded (by MarkTraceur):
[WIP] API to fetch data about stashed images

Change 259320 had a related patch set uploaded (by MarkTraceur):
[WIP] Resume stashed uploads

Change 258484 merged by jenkins-bot:
API to fetch data about stashed images

@MarkTraceur: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task?
If you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action...Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)

MarkTraceur removed MarkTraceur as the assignee of this task.Mar 18 2020, 4:45 PM
MarkTraceur added a subscriber: MarkTraceur.