Page MenuHomePhabricator
Create Task
Maniphest T85561

Allow continuing one or more fully-complete uploads that are in stashed mode
Open, MediumPublic
Actions

Description

UploadWizard stores uploaded files in the upload stash, then proceeds to collect metadata for them from the user. That sometimes breaks and the upload process has to be restarted. When that happens, there is no reason why the user should have to reupload the file (we could be talking about huge video files) which is already sitting there in the stash.

One possible implementation: in the upload step, if there are files in the stash, show a warning to the user saying "there are aborted uploads, do you wish to continue them?" and then allow him to pick files from the stash. (This does not work for Flickr uploads where the URL is a metadata source as well, although not sure if the stash is used at all for those.)

See also T77826.

Details

SubjectRepoBranchLines +/-
[WIP] Resume stashed uploadsmediawiki/extensions/UploadWizardmaster+351 -39
API to fetch data about stashed imagesmediawiki/coremaster+166 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tgr created this task.Dec 30 2014, 9:50 PM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added projects: UploadWizard, Multimedia.
Tgr mentioned this in T77826: Investigate if there is a low-effort way to recover entered details when the upload process has to be restarted.
Tgr mentioned this in T43740: Upload Wizard should auto-save current inputs (e.g. in DOM storage) and allow continuing after errors.
Tgr subscribed.
• Gilles added a parent task: T91652: Address technical issues responsible for funnel drop-offs in UploadWizard.Mar 6 2015, 5:39 AM
Steinsplitter added a project: Commons.Mar 13 2015, 6:38 PM
Steinsplitter moved this task from Incoming to Uploading on the Commons board.
MarkTraceur added a parent task: T96911: Improve UploadWizard UX (tracking).Apr 22 2015, 8:39 PM
Ricordisamoa subscribed.Apr 22 2015, 8:43 PM
Jdforrester-WMF triaged this task as Low priority.Sep 4 2015, 6:56 PM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptSep 4 2015, 6:56 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 7:04 PM
Jdforrester-WMF mentioned this in T112543: Allow continuing the partially-complete upload in stashed mode after warning.Sep 14 2015, 4:51 PM
Jdforrester-WMF renamed this task from Add the upload stash as a file source to UploadWizard to Allow continuing one or more fully-complete uploads that are in stashed mode .Sep 14 2015, 11:50 PM
Jdforrester-WMF set Security to None.
matmarex subscribed.Sep 15 2015, 2:08 PM

I like this idea, but I see at least two blockers:

  • We don't purge the upload stash of files for which the user intentionally cancelled the upload, by clicking the "Remove" button in the 'Upload' step. In fact it seems that there is no API for this.
  • There seems to be no way to recover the original filename. I'm not sure if UploadWizard is not passing it correctly, or if it can't currently be stored in the stash at all.
• brooke subscribed.Oct 25 2015, 3:23 AM

Inability to recover is really painful when something stalls or fails after uploading a couple gigs worth of video files... have to start all over and reupload everything from scratch.

• brooke added a parent task: T116510: Batch video upload tracking bug.Oct 25 2015, 3:25 AM
zhuyifei1999 moved this task from Uploading to Uploading (UploadWizard, cross-wiki upload, chunked uploading and API) on the Commons board.Nov 15 2015, 8:20 AM
MarkTraceur claimed this task.Dec 7 2015, 8:37 PM
matmarex merged a task: T120711: Resume existing stashed uploads in the first step.Dec 7 2015, 8:39 PM
matmarex added subscribers: MarkTraceur, StudiesWorld.
MarkTraceur raised the priority of this task from Low to Medium.Dec 11 2015, 5:53 PM
gerritbot subscribed.Dec 11 2015, 5:53 PM

Change 258484 had a related patch set uploaded (by MarkTraceur):
[WIP] API to fetch data about stashed images

https://gerrit.wikimedia.org/r/258484

gerritbot added a project: Patch-For-Review.Dec 11 2015, 5:53 PM
gerritbot added a comment.Dec 15 2015, 7:53 PM

Change 259320 had a related patch set uploaded (by MarkTraceur):
[WIP] Resume stashed uploads

https://gerrit.wikimedia.org/r/259320

gerritbot added a comment.Jan 15 2016, 5:02 PM

Change 258484 merged by jenkins-bot:
API to fetch data about stashed images

https://gerrit.wikimedia.org/r/258484

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 15 2016, 6:00 PM
MarkTraceur unsubscribed.Jan 27 2017, 10:16 PM
Liuxinyu970226 subscribed.Nov 27 2017, 10:26 AM
Seb35 mentioned this in T97539: UploadStash - Cannot serve a file larger than 1048576 bytes. .Nov 18 2018, 2:07 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Mar 1 2020, 6:55 AM

@MarkTraceur: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task?
If you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action... → Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)

MarkTraceur removed MarkTraceur as the assignee of this task.Mar 18 2020, 4:45 PM
MarkTraceur subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits