Page MenuHomePhabricator

keyboard selector hiding site id input
Closed, ResolvedPublic

Description

The keyboard selector is hiding the site id input when adding a new sitelink. https://commons.wikimedia.org/wiki/File:Wikidata_bug,_Overlapped_drop-downs.png shows the issue.

Event Timeline

This should be an issue with every input element that features a suggestion / auto-completion mechanism (e.g. entityselector).

IME supplied by ULS places itself always below the input element--a different position is used only if there is not enough space below the input element.
See jquery.ime.js: IMESelector.prototype.position.

Technical alternatives:

  • Suppress IME on every input element that features a suggestion / auto-completion mechanism applying "noime" CSS class to those elements.
  • Have IME provide an option that allows specifying preferred position(s)...
    • ... by adjusting ULS IME code or having the ULS IME code adjusted.
    • ... by overriding ULS IME code in Wikibase.

class="noime" is an option? Nice. This should be applied to all input elements where the user does not need to type non-ASCII characters. Unfortunately this is not the case here. But it's an intermediate solution. I suggest to do it.

Yes. Let's try class="noime" for now on the siteid input field.

@Amire80: do you have a better solution for the future for this?

gerritbot subscribed.

Change 189705 had a related patch set uploaded (by Tobias Gritschacher):
Added "noime" class to site id input

https://gerrit.wikimedia.org/r/189705

Patch-For-Review

Change 189705 merged by jenkins-bot:
Added "noime" class to site id input

https://gerrit.wikimedia.org/r/189705

Change 191642 had a related patch set uploaded (by Hoo man):
Added "noime" class to site id input

https://gerrit.wikimedia.org/r/191642

Patch-For-Review

Change 191642 merged by jenkins-bot:
Added "noime" class to site id input

https://gerrit.wikimedia.org/r/191642