Page MenuHomePhabricator

Remove GetLocalURL::Internal hack from CommonsMetadata
Closed, ResolvedPublic


Once the patch in the parent task is merged, this ugly hack can be removed from CommonsMetadata.

Event Timeline

Tgr claimed this task.
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr triaged this task as Lowest priority.Apr 3 2015, 7:03 AM
Aklapper removed Tgr as the assignee of this task.Jun 19 2020, 4:31 PM
Aklapper added a subscriber: Tgr.

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)

Platform engineering is working on refactoring/cleaning up the Title::get***URL methods. Very early strawman is T282283

As a part of the project, we want to drop all hooks from Title::getLocalURL - hooking into title on such a low level doesn't seem to be needed ( no hook handlers except CommonsMetadata ) and in general is too global. The replacement for Title methods will be a service, so if an extension wants to change globally how the URLs are rendered, it can redefine a service.

CommonsMetadata is the only extension that uses 'GetLocalURL::Internal hook. It could be fixed by working on T263581 but the documentation for the extension also states that "The extension in its current form is intended to be a temporary solution, eventually replaced by Wikidata on Commons.", so we don't want to work on the extension if it is going to be removed soon-ish.

Thus, a question: are the any plans to remove this temporary extension anytime soon, if yes - when, if not - what's needed for this to be removed?

Change 724154 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/extensions/CommonsMetadata@master] Remove a temporary hook hack to make absolute URLs

Change 724154 merged by jenkins-bot:

[mediawiki/extensions/CommonsMetadata@master] Remove a temporary hook hack to make absolute URLs

Pchelolo claimed this task.