T9. When deleting board or topic, contributions should move from Contributions to DeletedContributions
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Currently, they stay in Contributions. See T61809: Flow: Comments in a deleted topic are not visible in Deleted Contributions page.

Details

Subject	Repo	Branch	Lines +/-
Show revisions from deleted boards in DeletedContribtions instead of Contributions	mediawiki/extensions/Flow	master	+4 -3
Let extensions add entries to Special:DeletedContributions	mediawiki/core	master	+111 -4
Add Flow revisions to Special:DeletedContributions	mediawiki/extensions/Flow	master	+75 -17

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T78640 Co-op: bot can create a Flow board for each new mentored editor (tracking)
Invalid	• Capt_Swing	T76785 Co-op: get approval for hostbot to flow-create-board right
Resolved	• Capt_Swing	T90811 delete testwiki co-op pages
Resolved	• DannyH	T72697 Delete extra boards on ruwiki (was:Enable Flow for testing in ruwiki)
Resolved	matthiasmullie	T90970 T10. Board deletion action does not appear in tabs
Resolved	matthiasmullie	T90077 Board Deletion Issues (affects Co-op)
Resolved	matthiasmullie	T90973 T9. When deleting board or topic, contributions should move from Contributions to DeletedContributions

Event Timeline

• Mattflaschen-WMF created this task.Feb 26 2015, 11:21 PM

• Mattflaschen-WMF raised the priority of this task from to High.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added projects: StructuredDiscussions, Collaboration-Team-Triage.

• Mattflaschen-WMF added subscribers: • Capt_Swing, • Fhocutt, I_JethroBT and 4 others.

• Mattflaschen-WMF mentioned this in T90077: Board Deletion Issues (affects Co-op).Feb 26 2015, 11:29 PM

• DannyH moved this task from Untriaged to Team discussion on the Collaboration-Team-Triage board.Mar 2 2015, 5:46 PM

• DannyH set Security to None.Mar 2 2015, 7:11 PM

• DannyH edited a custom field.

• DannyH moved this task from Team discussion to Ready for next sprint on the Collaboration-Team-Triage board.Mar 2 2015, 7:22 PM

Xaosflux subscribed.Mar 10 2015, 2:45 AM

• DannyH edited projects, added Collaboration-Team-Sprint-S-2015-03-25; removed Collaboration-Team-Triage.Mar 17 2015, 7:56 PM

Change 198715 had a related patch set uploaded (by Matthias Mullie):
[WIP] Add Flow revisions to Special:DeletedContributions

https://gerrit.wikimedia.org/r/198715

Change 198716 had a related patch set uploaded (by Matthias Mullie):
Let extensions add entries to Special:DeletedContributions

https://gerrit.wikimedia.org/r/198716

matthiasmullie claimed this task.Mar 23 2015, 1:49 PM

matthiasmullie moved this task from Sprint S - ends March 25 to In Development on the Collaboration-Team-Sprint-S-2015-03-25 board.

• DannyH added a project: Collaboration-Team-Triage.Mar 24 2015, 11:10 PM

• DannyH moved this task from Ready for next sprint to Sprint S+ (temp for meeting) on the Collaboration-Team-Triage board.

Above patches will remove revisions for deleted posts from Special:Contributions, and show them in Special:DeletedContributions instead.

That's not all there's to it, though: I guess we also need to cascade these things?

If a board gets deleted, everything that was on the board should move to Special:DeletedContributions
If a topic gets deleted, all revisions for posts in the topic should move to Special:DeletedContributions

Right?

• DannyH moved this task from Sprint S+ (temp for meeting) to Sprint T (temporary for meeting) on the Collaboration-Team-Triage board.Mar 25 2015, 6:08 PM

• DannyH moved this task from Sprint T (temporary for meeting) to Sprint S+ (temp for meeting) on the Collaboration-Team-Triage board.

• DannyH added a project: Collaboration-Team-Sprint-T-2015-04-08.Mar 25 2015, 7:25 PM

• DannyH moved this task from Sprint T - ends April 8 to Needs Code Review on the Collaboration-Team-Sprint-T-2015-04-08 board.

• DannyH removed a project: Collaboration-Team-Triage.Mar 25 2015, 7:29 PM

• DannyH renamed this task from When deleting board or topic, contributions should move from Contributions to DeletedContributions to T9. When deleting board or topic, contributions should move from Contributions to DeletedContributions.Mar 25 2015, 7:37 PM

In T90973#1148500, @matthiasmullie wrote:

Above patches will remove revisions for deleted posts from Special:Contributions, and show them in Special:DeletedContributions instead.

That's not all there's to it, though: I guess we also need to cascade these things?

If a board gets deleted, everything that was on the board should move to Special:DeletedContributions

If a topic gets deleted, all revisions for posts in the topic should move to Special:DeletedContributions

Yes, and vice-versa for undeletion.

EBernhardson moved this task from Needs Code Review to Code Review Started on the Collaboration-Team-Sprint-T-2015-04-08 board.Mar 25 2015, 9:40 PM

Merged these two patches, moving back into first column to finish the points raised above.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 30 2015, 8:16 PM

EBernhardson moved this task from Code Review Started to Sprint T - ends April 8 on the Collaboration-Team-Sprint-T-2015-04-08 board.Mar 30 2015, 8:17 PM

Change 198716 merged by jenkins-bot:
Let extensions add entries to Special:DeletedContributions

https://gerrit.wikimedia.org/r/198716

Change 198715 merged by jenkins-bot:
Add Flow revisions to Special:DeletedContributions

https://gerrit.wikimedia.org/r/198715

Diffusion mentioned this in rMEXT9de990790147: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 30 2015, 8:26 PM

matthiasmullie mentioned this in rMW62a5454aad86: Let extensions add entries to Special:DeletedContributions.Mar 30 2015, 8:26 PM

matthiasmullie mentioned this in rEFLWaa7a47729691: Add Flow revisions to Special:DeletedContributions.

• Mattflaschen-WMF moved this task from Sprint S+ (temp for meeting) to Untriaged on the Collaboration-Team-Triage board.Mar 31 2015, 3:36 AM

matthiasmullie moved this task from Sprint T - ends April 8 to In Development on the Collaboration-Team-Sprint-T-2015-04-08 board.Mar 31 2015, 12:15 PM

Change 200853 had a related patch set uploaded (by Matthias Mullie):
Show revisions from deleted boards in DeletedContribtions instead of Contributions

https://gerrit.wikimedia.org/r/200853

matthiasmullie moved this task from In Development to Needs Code Review on the Collaboration-Team-Sprint-T-2015-04-08 board.Mar 31 2015, 12:22 PM

EBernhardson moved this task from Needs Code Review to Code Review Started on the Collaboration-Team-Sprint-T-2015-04-08 board.Apr 2 2015, 6:18 PM

• DannyH added a parent task: T72697: Delete extra boards on ruwiki (was:Enable Flow for testing in ruwiki).Apr 2 2015, 7:58 PM

• Mattflaschen-WMF merged a task: Restricted Task.Apr 2 2015, 8:26 PM

• Mattflaschen-WMF added subscribers: Jalexander, He7d3r.

matthiasmullie mentioned this in T95280: Make workflows aware of page_id.Apr 7 2015, 12:21 PM

EBernhardson moved this task from Code Review Started to Product Review on the Collaboration-Team-Sprint-T-2015-04-08 board.Apr 7 2015, 8:29 PM

Change 200853 merged by jenkins-bot:
Show revisions from deleted boards in DeletedContribtions instead of Contributions

https://gerrit.wikimedia.org/r/200853

Diffusion mentioned this in rMEXTa3105dd82ee9: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 7 2015, 8:38 PM

matthiasmullie mentioned this in rEFLWdcd7c57a9d01: Show revisions from deleted boards in DeletedContribtions instead of….Apr 7 2015, 8:38 PM