Page MenuHomePhabricator

When deleting StructuredDiscussion content, deleted content is misattributed to the sysop that deleted it
Open, HighPublic

Assigned To
None
Authored By
Quiddity
Nov 6 2015, 7:37 PM
Referenced Files
F31615196: Screen Shot 2020-02-13 at 3.18.17 PM.png
Feb 13 2020, 11:26 PM
Tokens
"The World Burns" token, awarded by Base."Manufacturing Defect?" token, awarded by Jules78120."The World Burns" token, awarded by revi."Orange Medal" token, awarded by Billinghurst."Manufacturing Defect?" token, awarded by MarcoAurelio."Orange Medal" token, awarded by Krinkle."Love" token, awarded by Framawiki."Pterodactyl" token, awarded by Nemo_bis.

Description

This was implemented in T90973: T9. When deleting board or topic, contributions should move from Contributions to DeletedContributions but seems to have broken since then.
E.g. I Deleted these 3 topics (one, two, three), but nothing at all is showing up in the user's Contributions or their DeletedContributions.

Amended description from 2018-12-14 (UTC): When an administrator deletes Flow content, said contributions are attributed to the deleting sysop and logged in the sysop's personal DeletedContributions log. This is unlogical, causes copyright issues on edits being misatributed and most importantly, T118024#2314965 (real example: I've just deleted threats towards an editor and now those edits appear on my personal deleted contributions log, which as you can imagine, makes no sense and is unnaceptable).

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Mattflaschen-WMF renamed this task from When deleting Flow topic or post, contributions should move from Contributions to DeletedContributions to When deleting Flow topic or post, contributions should appear in DeletedContributions.Nov 6 2015, 10:51 PM
Mattflaschen-WMF set Security to None.

I've just deleted a Flow Topic and blocked a user for harassment with my volunteer account. Now, I can be accused of harassment by an other sysop because there is no proof of my actions: Special:DeletedContributions is blank for the blocked user.

(Fortunately, people trust me. At least, I hope. :))

Yes, this is problematic and makes searching deleted Flow things complicated and hard. It'd be good to have this fixed indeed. Thanks.

And are visible in deleted contributions of deletor. Is this intentional?

MarcoAurelio renamed this task from When deleting Flow topic or post, contributions should appear in DeletedContributions to When deleting StructuredDiscussion content, attribute the deleted content to its author nor the sysop that deleted it.Dec 14 2018, 11:47 AM
MarcoAurelio updated the task description. (Show Details)
MarcoAurelio raised the priority of this task from High to Unbreak Now!.Dec 14 2018, 11:48 AM

Per my amended description above. This needs to be addressed now. I am fed up of having vandalic edits (some of them plain libel, death threats, etc.) misattributed to me because of this.

Para32556677 lowered the priority of this task from Unbreak Now! to Lowest.Dec 23 2018, 4:59 PM
Paladox raised the priority of this task from Lowest to Unbreak Now!.Dec 23 2018, 5:04 PM
greg lowered the priority of this task from Unbreak Now! to High.Jan 3 2019, 8:04 PM
greg subscribed.

Per my amended description above. This needs to be addressed now. I am fed up of having vandalic edits (some of them plain libel, death threats, etc.) misattributed to me because of this.

Unfortunately that's not a good reason for using UBN!, I'm setting this to High instead. I agree that it still needs to be fixed as soon as it can be.

Per my amended description above. This needs to be addressed now. I am fed up of having vandalic edits (some of them plain libel, death threats, etc.) misattributed to me because of this.

Unfortunately that's not a good reason for using UBN!, I'm setting this to High instead. I agree that it still needs to be fixed as soon as it can be.

Definitely. And it's been at high priority since 2015 ... who and when will fix this?

Catrope subscribed.

We're planning to address this in the coming few months, possibly later this month.

Catrope renamed this task from When deleting StructuredDiscussion content, attribute the deleted content to its author nor the sysop that deleted it to When deleting StructuredDiscussion content, deleted content is misattributed to the sysop that deleted it.Jan 11 2019, 11:43 PM

Notes for testing after the fix:

  • Deleting a Flow topic will be attributed to the person who deleted the topic
  • Deleting a Flow post - Special:DeletedContributions will display it twice - for a user who deleted it and for a post author
  • Rollback/undo will not be on Special:DeletedContributions
  • MassDelete are on Special:DeletedContributions
MMiller_WMF subscribed.

I am moving this to the Growth Team's "Upcoming Work" column so that it can be among the next bugs we address that are outside our normal feature development stream.

What found when re-testing the current behavior
(1) Records of deleted Flow board content (deleted posts and topics) will be displayed on Special:DeletedContributions (and not in Special:Contributions) under the name of an admin who deleted the content:

e.g. ET13 deleted a Flow board topic and a page - Special:DeletedContributions will display the following, stating that ET13 deleted a topic and a post:

Screen Shot 2020-02-13 at 3.18.17 PM.png (490×1 px, 144 KB)

So the answer is 'yes, at least, it's a current behavior' to

And are visible in deleted contributions of deletor. Is this intentional?

(2) Revisions that were un-done/reverted will be shown on Special:Contributions but not on Special:DeletedContributions.

Just encountered this again and spent a while trying to figure out why there were no contributions to be found by a user -

I am moving this to the Growth Team's "Upcoming Work" column so that it can be among the next bugs we address that are outside our normal feature development stream.

This has been in "Upcoming Work" since 2020 and that column now appears to be hidden from the workboard. Moving back to inbox for this to be visible to (and please please addressed by) the growth team (personally I would prefer T332022 but I might be in the minority)

It won't be seen by the Growth Team because it has Growth-Team-Filtering and projects with that tag are hidden from the workboard by default.

KStoller-WMF subscribed.

Sorry to hear that this is still an issue and that it's been neglected for so long!

In T118024#9274893, @DannyS712 wrote:
(personally I would prefer T332022 but I might be in the minority)

Personally, I agree. WMF is currently attempting to support three different discussion features, and I don't think it makes sense to maintain all three indefinitely.

Based on usage, I'm not sure it makes sense to invest engineering time into Flow, given that the long term plan is T332022: [Epic] Undeploying StructuredDiscussions (Flow).

In August 2023, on average:

  • DiscussionTools is used about 18,780 times per day.
  • Flow is used about 250 times per day.
  • LiquidThreads is used less than once per day.

Although there isn't yet a timeline for sunsetting / undeploying Flow, the Growth team currently has this communication task in progress: T346108: [EPIC] IP Masking: StructuredDiscussions (Flow)/LiquidThreads Community discussion.