Page MenuHomePhabricator
Create Task
Maniphest T93694

Icons for redirects, disambig, red link suggestions; default icon when there is no image
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
• sucheta
Authored By
• sucheta
Mar 23 2015, 11:41 PM
Tags
Referenced Files
F158018: types-of-results.png
Apr 28 2015, 6:16 AM
F158014: article.svg
Apr 28 2015, 6:16 AM
F158016: redirect.svg
Apr 28 2015, 6:16 AM
F158017: disamb.svg
Apr 28 2015, 6:16 AM
F158015: not-found.svg
Apr 28 2015, 6:16 AM
Subscribers
Aklapper
Esanders
gerritbot
Jdforrester-WMF
• KHammerstein
• Nirzar
Pginer-WMF
View All 9 Subscribers

Description

  • Article icon: OOjs UI, Content icon pack, "Article" icon Use local
  • Redirect icon: OOjs UI, Editing-Advanced icon pack, "Redirect" icon Use local
  • Disambiguation article icon: Use local
  • New article icon: Use local

Details

SubjectRepoBranchLines +/-
Show different icons for different result typesmediawiki/extensions/VisualEditormaster+154 -8
Link inspector images and descriptionsmediawiki/extensions/VisualEditormaster+134 -26
Customize query in gerrit

Related Objects
Search...

Event Timeline

• sucheta created this task.Mar 23 2015, 11:41 PM
• sucheta claimed this task.
• sucheta raised the priority of this task from to Medium.
• sucheta updated the task description. (Show Details)
• sucheta added projects: VisualEditor 2014/15 Q4 blockers, Design, VisualEditor-MediaWiki-Links, VisualEditor.
• sucheta added subscribers: • santhosh, Pginer-WMF, Jdforrester-WMF and 2 others.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 11:41 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Mar 25 2015, 10:00 PM
Catrope renamed this task from Icons for redirects, disambig, red links; default icon when there is no image to Icons for redirects, disambig, red link suggestions; default icon when there is no image.Apr 4 2015, 7:44 PM
Catrope set Security to None.
Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Apr 15 2015, 6:24 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF removed • sucheta as the assignee of this task.Apr 22 2015, 4:58 PM
gerritbot subscribed.Apr 24 2015, 2:22 PM

Change 174725 had a related patch set uploaded (by Esanders):
Link inspector images and descriptions

https://gerrit.wikimedia.org/r/174725

gerritbot added a project: Patch-For-Review.Apr 24 2015, 2:22 PM
Jdforrester-WMF moved this task from Backlog to Doing on the VisualEditor 2014/15 Q4 blockers board.Apr 24 2015, 4:48 PM
Jdforrester-WMF updated the task description. (Show Details)Apr 24 2015, 7:50 PM
gerritbot added a comment.Apr 27 2015, 11:51 PM

Change 174725 merged by jenkins-bot:
Link inspector images and descriptions

https://gerrit.wikimedia.org/r/174725

Esanders mentioned this in rEVED3963b1daf2fa: Link inspector images and descriptions.Apr 27 2015, 11:52 PM
Jdforrester-WMF assigned this task to • sucheta.Apr 28 2015, 12:04 AM
Jdforrester-WMF added a project: WMF-deploy-2015-04-29_(1.26wmf4).
• Nirzar subscribed.Apr 28 2015, 6:16 AM

Here are the icons for the placeholders for different types of links/pages

article.svg738 BDownload

not-found.svg2 KBDownload

redirect.svg1 KBDownload

disamb.svg1 KBDownload

types-of-results.png (763×680 px, 27 KB)

Jdforrester-WMF added a comment.Apr 28 2015, 2:31 PM
In T93694#1240869, @Nirzar wrote:

Here are the icons for the placeholders for different types of links/pages

article.svg738 BDownload

not-found.svg2 KBDownload

redirect.svg1 KBDownload

disamb.svg1 KBDownload

types-of-results.png (763×680 px, 27 KB)

Thanks so much!

Esanders subscribed.Apr 28 2015, 3:09 PM

If these are going to be icons, they need to be 24x24 (be clear at that size, and snapped to the grid where appropriate). They must also be monochrome (disambig has two tones).

• Nirzar added a comment.Apr 28 2015, 7:42 PM

@Esanders can you tell me the dimension for the placeholder? (the grey box)

Esanders added a comment.Apr 28 2015, 11:10 PM

@Nirzar - we have a little bit of room to be flexible there but currently we are showing the icons at 2x (48x48) with no extra padding. Ideally the icons would look good at 24x24 and 48x48.

gerritbot added a comment.Apr 28 2015, 11:18 PM

Change 207120 had a related patch set uploaded (by Jforrester):
[WIP] Add new icons for link search results

https://gerrit.wikimedia.org/r/207120

Liuxinyu970226 subscribed.Apr 29 2015, 1:49 AM
Jdforrester-WMF updated the task description. (Show Details)Apr 29 2015, 4:57 PM
gerritbot added a comment.Apr 29 2015, 5:01 PM

Change 207120 merged by jenkins-bot:
Show different icons for different result types

https://gerrit.wikimedia.org/r/207120

Esanders mentioned this in rEVED65112a7e10bd: Show different icons for different result types.Apr 29 2015, 5:01 PM
Jdforrester-WMF closed this task as Resolved.Apr 29 2015, 5:17 PM
Jdforrester-WMF moved this task from Doing to Done on the VisualEditor 2014/15 Q4 blockers board.
Liuxinyu970226 unsubscribed.Apr 29 2015, 11:40 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to FY 18-19 Q3/Q4 on the VisualEditor board.May 6 2015, 12:56 AM
Jdforrester-WMF removed a project: Patch-For-Review.May 6 2015, 10:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL