Page MenuHomePhabricator
Create Task
Maniphest T93895

Remove this.uploads from the UploadWizard class
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

I'm SICK. AND. TIRED. OF. THIS. ARRAY.

It should be in each step, and each step already gets a copy of the last step's this.uploads in its moveTo method. So we're GOOD.

Details

SubjectRepoBranchLines +/-
Get rid of some event handlers in mw.UploadWizardmediawiki/extensions/UploadWizardmaster+43 -94
Move this.uploads, addUpload & removeUpload to controllersmediawiki/extensions/UploadWizardmaster+135 -138
[WIP] Move upload handling to the step objectsmediawiki/extensions/UploadWizardmaster+250 -267
Customize query in gerrit

Related Objects
Search...

Event Timeline

MarkTraceur created this task.Mar 25 2015, 3:07 PM
MarkTraceur claimed this task.
MarkTraceur raised the priority of this task from to Medium.
MarkTraceur updated the task description. (Show Details)
MarkTraceur added projects: UploadWizard-Refactoring, UploadWizard, Multimedia-Sprint-2015-03-18.
MarkTraceur subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptMar 25 2015, 3:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MarkTraceur added subtasks: T93894: Move resetFileStepUploads into the file step, T93893: Move startUploads into the upload step controller, T93892: Move showNext into the step controllers (and simplify it), T93891: Change isComplete to query step objects instead of upload objects, T93889: Move newUpload into the Upload step controller, T93888: Move setUploadFilled to the file step controller.Mar 25 2015, 3:07 PM
MarkTraceur set Security to None.Mar 25 2015, 3:41 PM
MarkTraceur edited a custom field.
• Gilles edited projects, added Multimedia-Sprint-2015-03-25; removed Multimedia-Sprint-2015-03-18.Mar 25 2015, 3:44 PM
gerritbot subscribed.Mar 26 2015, 8:06 PM

Change 199985 had a related patch set uploaded (by MarkTraceur):
[WIP] Move upload handling to the step objects

https://gerrit.wikimedia.org/r/199985

gerritbot added a project: Patch-For-Review.Mar 26 2015, 8:06 PM
MarkTraceur closed subtask T93889: Move newUpload into the Upload step controller as Invalid.Mar 26 2015, 8:52 PM
MarkTraceur closed subtask T93894: Move resetFileStepUploads into the file step as Invalid.
MarkTraceur edited a custom field.
MarkTraceur edited subtasks, added: T90741: Move file metadata copy handling to describe step, change UX; removed: T93888: Move setUploadFilled to the file step controller, T93889: Move newUpload into the Upload step controller, T93894: Move resetFileStepUploads into the file step.
MarkTraceur added a parent task: T96906: Refactor UploadWizard to be maintainable.Apr 22 2015, 8:08 PM
MarkTraceur closed subtask T93892: Move showNext into the step controllers (and simplify it) as Resolved.Apr 23 2015, 2:56 PM
matmarex closed subtask T93893: Move startUploads into the upload step controller as Resolved.Apr 24 2015, 6:33 PM
matmarex closed subtask T93891: Change isComplete to query step objects instead of upload objects as Resolved.
Jdforrester-WMF moved this task from Untriaged to Next up on the Multimedia board.Apr 30 2015, 4:08 PM
Jdforrester-WMF moved this task from Next up to Doing on the Multimedia board.
MarkTraceur moved this task from Doing to Next up on the Multimedia board.Sep 4 2015, 5:17 PM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptSep 4 2015, 5:17 PM
matmarex mentioned this in T119764: Clean the code review queue of extensions/UploadWizard.Nov 27 2015, 9:27 PM
gerritbot added a comment.Dec 1 2015, 3:25 PM

Change 199985 abandoned by MarkTraceur:
[WIP] Move upload handling to the step objects

Reason:
Mostly superseded by change 254913

https://gerrit.wikimedia.org/r/199985

MarkTraceur lowered the priority of this task from Medium to Low.Dec 3 2015, 8:03 PM
MarkTraceur added a project: Technical-Debt.
gerritbot added a comment.Dec 7 2015, 5:26 PM

Change 254913 had a related patch set uploaded (by MarkTraceur):
Remove upload handling from UploadWizard object

https://gerrit.wikimedia.org/r/254913

gerritbot added a comment.Dec 7 2015, 5:26 PM

Change 254913 abandoned by MarkTraceur:
Remove upload handling from UploadWizard object

Reason:
Needs some serious Flickr refactoring, which I don't want to do right now, so I'm going to close this so we can focus on fixing bugs

https://gerrit.wikimedia.org/r/254913

gerritbot added a comment.Dec 15 2015, 7:52 PM

Change 254913 restored by MarkTraceur:
Remove upload handling from UploadWizard object

Reason:
I forgot I was using this as the base for something.

https://gerrit.wikimedia.org/r/254913

Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.Jan 22 2016, 11:45 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jul 7 2016, 2:09 PM
gerritbot added a comment.Oct 26 2016, 12:32 AM

Change 318019 had a related patch set uploaded (by Matthias Mullie):
Move this.uploads, addUpload & removeUpload to controllers

https://gerrit.wikimedia.org/r/318019

gerritbot added a project: Patch-For-Review.Oct 26 2016, 12:32 AM

Change 318020 had a related patch set uploaded (by Matthias Mullie):
Get rid of some event handler in mw.UploadWizard

https://gerrit.wikimedia.org/r/318020

matthiasmullie moved this task from Next up to Needs code review on the Multimedia board.Oct 31 2016, 10:29 AM
gerritbot added a comment.Nov 15 2016, 8:05 PM

Change 318019 merged by jenkins-bot:
Move this.uploads, addUpload & removeUpload to controllers

https://gerrit.wikimedia.org/r/318019

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 15 2016, 9:00 PM
matmarex closed this task as Resolved.Nov 16 2016, 10:26 AM
matmarex reassigned this task from MarkTraceur to matthiasmullie.
matmarex removed a project: Patch-For-Review.
matmarex subscribed.

\o/

TheDJ awarded a token.Nov 16 2016, 2:07 PM
gerritbot added a comment.Nov 16 2016, 3:42 PM

Change 318020 merged by jenkins-bot:
Get rid of some event handlers in mw.UploadWizard

https://gerrit.wikimedia.org/r/318020

Aklapper removed a subtask: T90741: Move file metadata copy handling to describe step, change UX.Dec 14 2022, 2:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits