Page MenuHomePhabricator
Create Task
Maniphest T95176

After editing, the references have their numbering and their style altered
Open, MediumPublic
Actions

Description

With the Web visual editor, what you see is not what you get.

Safari on iOS 8.2 on iPad in landscape.

I go to https://fr.wikipedia.org/wiki/Montr%C3%A9al
At the beginning, are the refs: 5, 6, 7, 8
I click modifier.
I edit the article with the Web visual editor.
Now, these refs are: [3], [4], [5], [6]

  1. The numbers have changed. This is incorrect. Editing refs is already difficult. Inconsistent numbers make editing refs a puzzle.
  2. The refs now have []. This makes me think that saving my edit will put refs with [] in the article, but the saved article does not get the refs with []. Actually, I prefer the refs with the [].

It would be nice to have the refs keep their number.
Having the refs keep their [] would be nice too.

Thank you.

Nnemo

Details

SubjectRepoBranchLines +/-
Provide ext.style.fr.css without square bracketsmediawiki/extensions/Citemaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

Nnemo created this task.Apr 6 2015, 4:00 PM
Nnemo raised the priority of this task from to Needs Triage.
Nnemo updated the task description. (Show Details)
Nnemo added projects: VisualEditor, MediaWiki-General.
Nnemo subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2015, 4:00 PM
Nnemo updated the task description. (Show Details)Apr 6 2015, 5:10 PM
Nnemo set Security to None.
Nnemo updated the task description. (Show Details)Apr 6 2015, 5:23 PM
Aklapper renamed this task from The refs have their number and their style altered to After editing, references have their numbering and style altered.Apr 7 2015, 2:10 PM
Aklapper edited projects, added VisualEditor-MediaWiki-References; removed MediaWiki-General.
Jdforrester-WMF renamed this task from After editing, references have their numbering and style altered to ext.cite.css styling for French has square brackets, but frwiki does not.Aug 13 2015, 9:35 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added a project: Cite.
Jdforrester-WMF added a parent task: T104927: Use ext.cite.style to style output, rather than wikitext styling.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Arlolra subscribed.Aug 13 2015, 10:52 PM

See https://phabricator.wikimedia.org/T86782#1465463

gerritbot subscribed.Aug 13 2015, 11:06 PM

Change 231455 had a related patch set uploaded (by Jforrester):
Provide ext.style.fr.css without square brackets

https://gerrit.wikimedia.org/r/231455

gerritbot added a project: Patch-For-Review.Aug 13 2015, 11:06 PM
Esanders subscribed.Aug 24 2015, 3:08 PM

(bringing over discussion from above patch)

The french override is done on-wiki at https://fr.wikipedia.org/wiki/MediaWiki:Cite_reference_link . They have wrapped the brackets in a span and then hidden them with css. If we wan't consistency we'd need to parse that message, and other messages.

As the possible inputs are fairly complex (group, key, label, subkey) we basically need to reproduce function linkRef from Cite_body in JavaScript.

ssastry subscribed.Aug 24 2015, 7:37 PM
In T95176#1567745, @Esanders wrote:

If we wan't consistency we'd need to parse that message, and other messages.

No, we want to deprecate site messages for customizing cite ( T86782 ). We should use CSS on Parsoid-generated html for replicating those customizations.

Nnemo renamed this task from ext.cite.css styling for French has square brackets, but frwiki does not to After editing, the ref calls have their style and their number altered.Oct 8 2015, 8:18 PM
Nnemo added a comment.EditedOct 8 2015, 8:24 PM

I am open to editing the title of the task to a better meaning. But I think it is better to keep the title a description of the issue, rather than turning it into the technical cause of the issue. When I saw the title of that task that I had created, I had no idea what it is about.

Furthermore, the problem is not only the [], it is also the number inside.

Nnemo renamed this task from After editing, the ref calls have their style and their number altered to After editing, the ref calls have their numbering and their style altered.Oct 8 2015, 8:25 PM
Nnemo renamed this task from After editing, the ref calls have their numbering and their style altered to After editing, the references have their numbering and their style altered.
Nnemo awarded a token.
Izno moved this task from Unsorted backlog to Doing on the Cite board.Feb 20 2016, 3:04 AM
Krzysiu mentioned this in T128294: Wrong numbers of references and template boundaries in VisualEditor.Feb 27 2016, 9:46 PM
Jdforrester-WMF removed a parent task: T104927: Use ext.cite.style to style output, rather than wikitext styling.Apr 3 2016, 7:04 AM
Jdforrester-WMF closed this task as a duplicate of T51346: Cite CSS should be adjusted by wikis to set a non-standard rendering style (e.g. 1.0, 1.1 / a,b,c, removing brackets, etc.).
gerritbot added a comment.Apr 3 2016, 7:08 AM

Change 231455 abandoned by Jforrester:
Provide ext.style.fr.css without square brackets

Reason:
OK, Common.css bloat it is. :-(

https://gerrit.wikimedia.org/r/231455

Nnemo added a comment.Aug 6 2016, 10:57 PM
This comment was removed by Nnemo.
Nnemo reopened this task as Open.Aug 6 2016, 10:58 PM
Nnemo added a comment.Aug 6 2016, 11:02 PM

This task T95176 is not a duplicate of the task T51346.

  1. This task is about the numbering and the style of the ref calls. Actually, the numbering inconsistency is more important than the style inconsistency.
  1. The task T51346, as I understand, is for removing the []. In the task T95176 here, I do not request that, I rather request the opposite: applying the [] of the what-you-see in the what-you-get.
Izno moved this task from Doing to Parsoid/VE implementation on the Cite board.Apr 9 2019, 5:42 PM
Umherirrender removed a project: Patch-For-Review.Apr 5 2022, 7:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits