Move code specific to page editing out of ve.init.mw.Target
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	• Catrope
	Apr 24 2015, 8:00 PM

Description

Right now, Flow doesn't use ve.init.mw.Target because its multi-surface support isn't as good as sa.Target's, and mw.Target contains a lot of code Flow doesn't need (because mw.Target assumes you're only editing one page, rather than a multitude of non-page things). However, there are a number of things in mw.Target that Flow could and should benefit from (e.g. getHtml for T97165: Flow doesn't strip browser plugin garbage or fixBase and related functionality for T96492: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ ). So we should split MW-specific code (in ve.init.mw.Target) from "MW page editing-specific code" (in ve.init.mw.PageTarget or something?)

Details

	Subject	Repo	Branch	Lines +/-
	[BREAKING CHANGE] Create ve.init.mw.Target base class	mediawiki/extensions/VisualEditor	master	+463 -342
	Rename mw.Target to mw.ArticleTarget	mediawiki/extensions/VisualEditor	master	+106 -106

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T52000 Enable VisualEditor by default for all users of all Wikimedia wikis
Open	None	T138391 Enable VisualEditor by default for all users of all Wikisources
Open	None	T138966 Make the VisualEditor/ProofreadPage integration good enough to enable by default
Resolved	Tpt	T93525 Add the visual editor to Wikisource
Resolved	coren	T48580 Create a VisualEditor plugin to integrate with ProofreadPage
Open	None	T121110 Flow should use one VisualEditor target per page
Open	None	T97165 Flow doesn't strip browser plugin garbage
Resolved	Esanders	T97168 Make mw.flow.ve.Target inherit from ve.init.mw.Target, not sa.Target
Resolved	Esanders	T97166 Move code specific to page editing out of ve.init.mw.Target

Event Timeline

• Catrope created this task.Apr 24 2015, 8:00 PM

• Catrope raised the priority of this task from to Needs Triage.

• Catrope updated the task description. (Show Details)

• Catrope added projects: VisualEditor, StructuredDiscussions.

• Catrope subscribed.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 24 2015, 8:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Catrope removed projects: Collaboration-Team-Triage, StructuredDiscussions.Apr 24 2015, 8:00 PM

• Catrope set Security to None.

• Catrope added a parent task: T97168: Make mw.flow.ve.Target inherit from ve.init.mw.Target, not sa.Target.

Jdforrester-WMF triaged this task as High priority.Apr 24 2015, 8:01 PM

Jdforrester-WMF added projects: Technical-Debt, VisualEditor-MediaWiki.

Jdforrester-WMF added a parent task: T97165: Flow doesn't strip browser plugin garbage.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.May 8 2015, 1:43 AM

Jdforrester-WMF moved this task from Freezer to To Triage on the VisualEditor board.Jul 21 2015, 6:48 PM

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jul 31 2015, 11:34 PM

Change 258158 had a related patch set uploaded (by Esanders):
Rename mw.Target to mw.ArticleTarget

https://gerrit.wikimedia.org/r/258158

gerritbot added a project: Patch-For-Review.Dec 10 2015, 4:26 PM

Change 258158 merged by jenkins-bot:
Rename mw.Target to mw.ArticleTarget

https://gerrit.wikimedia.org/r/258158

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 10 2015, 5:00 PM

Flow/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js:		ve.init.mw.Target.static.fixBase( htmlDoc );
Flow/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js:		// Based on ve.init.mw.Target.prototype.setupSurface
Flow/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js:		ve.init.mw.Target.static.fixBase( htmlDoc );

In T97166#1869859, @Krenair wrote:

Flow/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js:		ve.init.mw.Target.static.fixBase( htmlDoc );
Flow/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js:		// Based on ve.init.mw.Target.prototype.setupSurface
Flow/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js:		ve.init.mw.Target.static.fixBase( htmlDoc );

https://gerrit.wikimedia.org/r/#/c/258174/ for the fix.

Change 258452 had a related patch set uploaded (by Esanders):
[BREAKING CHANGE] Create ve.init.mw.Target base class

https://gerrit.wikimedia.org/r/258452