Page MenuHomePhabricator

Create a VisualEditor plugin to integrate with ProofreadPage
Closed, ResolvedPublic40 Estimated Story Points

Assigned To
Authored By
Tpt
Mar 26 2013, 8:31 PM
Referenced Files
F4145216: Capture.PNG
Jun 9 2016, 3:35 AM
Tokens
"Party Time" token, awarded by Liuxinyu970226."Love" token, awarded by Aubrey."Mountain of Wealth" token, awarded by RandomDSdevel."Like" token, awarded by Johan."Love" token, awarded by jayantanth."Love" token, awarded by Elitre."Like" token, awarded by Jdforrester-WMF."Love" token, awarded by Bodhisattwa."Like" token, awarded by iecetcwcpggwqpgciazwvzpfjpwomjxn."Like" token, awarded by Rastus_Vernon."Like" token, awarded by Tpt."Like" token, awarded by Ricordisamoa.

Description

Page: pages are not plain wikitext pages but are split into three textareas: header, footer and body and a proofreading level tag (note 1).
So, an adaptation of the VisualEditor to these pages is needed in order to make edition of the pages work.

The UI need to be tweaked in order to allow the splitting of the main textarea into three and the edition of the Proofreading level at the save of page as it works currently for wikitext editing (example: https://en.wikisource.org/w/index.php?title=Page:La_Fontaine_-_The_Original_Fables_Of,_1913.djvu/20&action=edit ).

An other useful (but less important thing) things is to add modules to the Visual Editor to support specific tags used by Wikisource like <pages>, <section> and <poem>.

note 1: structure of the page as save in the database:
<noinclude><pagequality level="LEVEL" user="LAST PROOFREADER" />HEADER<div class="pagetext">BODY<noinclude>FOOTER</noinclude>


Version: unspecified
Severity: enhancement

This card tracks a proposal from the 2015 Community Wishlist Survey: https://meta.wikimedia.org/wiki/2015_Community_Wishlist_Survey

This proposal received 41 support votes, and was ranked #23 out of 107 proposals. https://meta.wikimedia.org/wiki/2015_Community_Wishlist_Survey/Wikisource#Visual_Editor_adapted_for_Wikisource

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
IMPORTANT: If you are a community developer interested in working on this task: The Wikimedia Hackathon 2016 (Jerusalem, March 31 - April 3) focuses on #Community-Wishlist-Survey projects. There is some budget for sponsoring volunteer developers. THE DEADLINE TO REQUEST TRAVEL SPONSORSHIP IS TODAY, JANUARY 21. Exceptions can be made for developers focusing on Community Wishlist projects until the end of Sunday 24, but not beyond. If you or someone you know is interested, please REGISTER NOW.
coren added a subscriber: coren.

I will be in Jerusalem, and will concentrate on coordinating work on this task while there (as well as hack on it myself).

I will be in Jerusalem, and will concentrate on coordinating work on this task while there (as well as hack on it myself).

Great! I'll be in Jerusalem too and willing to work on it.

Current status: we now have a proper design for Page namespace that is in progress but - as a first step - we now have usable mainspace editing with Visual Editor (including the transclusion tag). This is currently working on a test server, and is scheduled for the deployment train Tueseday, Apr 5 (and deployed on group 1 that inlcludes the Wikisources on Apr 6).

@Jdforrester-WMF is planning to turn the configuration switch on April 7.

At that point, Visual Editor will become available as a beta feature on fr.wikisource.org for all content namespaces except Page (that's the next part being worked on now).

@Jdforrester-WMF is planning to turn the configuration switch on April 7.

At that point, Visual Editor will become available as a beta feature on fr.wikisource.org for all content namespaces except Page (that's the next part being worked on now).

Clarification: This will be for all Wikisources, not just frws. :-)

Clarification: This will be for all Wikisources, not just frws. :-)

Oh, yeah. Good point. It will be available (selectable from the beta features selector) on all Wikisources.

works well in chrome and firefox. saved first new article.

Insert -> Pages -> there is no "onlysection" attribute

Z.

This was deployed in the new Single Edit Tab mode. The basic explanation is at https://www.mediawiki.org/wiki/VisualEditor/Single_edit_tab if anyone is looking for information.

What is missing to consider this task Resolved?

I am trying to summarize the progress on this task at https://meta.wikimedia.org/wiki/Wikimedia_Blog/Drafts/WIP_Wikimedia_Hackathon_2016_post#The_connection_with_the_Community_Wishlist. Is there any beautiful screenshot in Commons that we can reuse?

What is missing to consider this task Resolved?

We are still waitng for Page namespace support which is the main editing namespace for most wikisources. Moreover, many new wikisourcians edit only in the Page namespace. The general trend is to have articles in main namespace automatically or semi-automatically generated basing on data from Index and Page namespaces. So having VE support in main namespace may be a nice feature, but mostly useless.

i noted some buggy interaction for the insert > pages, initially rather than subsequenly editing pages template https://www.mediawiki.org/wiki/VisualEditor/Feedback

We are still waitng for Page namespace support which is the main editing namespace for most wikisources. Moreover, many new wikisourcians edit only in the Page namespace. The general trend is to have articles in main namespace automatically or semi-automatically generated basing on data from Index and Page namespaces. So having VE support in main namespace may be a nice feature, but mostly useless.

Indeed. Having VE there at all was a preliminary requirement, not the end result. :-)

Change 284681 had a related patch set uploaded (by Esanders):
WIP Sectioned edit target for page namespace

https://gerrit.wikimedia.org/r/284681

Is it safe to assume this feature will not suddenly become active and in use in production once code from this task is merged? Sorry that I need to ask ... but I have been unpleasantly surprised in the past (definitely not referring to the developers active on this or related task), and I hope to avoid that occurring in this case.

I think WS folk would like to play with it a little in a test bed before it becomes active somehow, and will need longer than a few days as the deploy process moves from beta/test/prod.

I certainly would be happy to do some QA work on it, if given a decent window to work with. i.e. I cant make any promises to help if the approach is: it is merged, and will be deployed in three days, happy hunting.

Is it safe to assume this feature will not suddenly become active and in use in production once code from this task is merged?

It will certainly remain as a beta feature for quite some time, requiring explicit activation.

Is it safe to assume this feature will not suddenly become active and in use in production once code from this task is merged?

It will certainly remain as a beta feature for quite some time, requiring explicit activation.

Well why not activate it on https://test2.wikipedia.org at the very least? The ProofreadPage extension is already 'enabled' there and nobody really uses it for proofreading; just for testing &/or illustrative purposes.

If not, please remember to make the beta "option" available there as well.

when trying to insert > pages get a 404 error ;' trying to switch to code hangs.
when refresshing and repeating it saves properly. on chrome browser

Capture.PNG (572×809 px, 57 KB)

Is there already a place/time made out to work on this during the Hackathon?

Change 284681 merged by jenkins-bot:
Sectioned edit target for page namespace

https://gerrit.wikimedia.org/r/284681

Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 40.

Is there already a place/time made out to work on this during the Hackathon?

Table in Room 12 if you're not there!

Parsoid support for extensions implementing their own contentmodels at https://gerrit.wikimedia.org/r/295707

Change 295707 had a related patch set uploaded (by Cscott):
Allow extensions to handle specific contentmodels.

https://gerrit.wikimedia.org/r/295707

Change 295707 merged by jenkins-bot:
Allow extensions to handle specific contentmodels.

https://gerrit.wikimedia.org/r/295707