⚓ T97457 Flow edit area should have a placeholder when in VE mode

	Subject	Repo	Branch	Lines +/-
	Copy placeholders over to VE surfaces	mediawiki/extensions/Flow	master	+14 -11

Status	Assigned	Task
Open	None	T95512 Flow entry fields should not look terrible
Resolved	Catrope	T97457 Flow edit area should have a placeholder when in VE mode
Resolved	Esanders	T96593 Be able to set placeholder text (generic content?) on an empty CE surface

Pginer-WMF created this task.Apr 28 2015, 6:59 PM

Pginer-WMF raised the priority of this task from to Needs Triage.

Pginer-WMF updated the task description. (Show Details)

Pginer-WMF added projects: StructuredDiscussions, Design, Collaboration-Team-Triage.

Pginer-WMF added a subtask: T96593: Be able to set placeholder text (generic content?) on an empty CE surface.

Pginer-WMF mentioned this in T96421: A8. Polish the entry fields after VE integration.

Pginer-WMF added subscribers: Pginer-WMF, Aklapper, • DannyH.

• Mattflaschen-WMF triaged this task as Medium priority.Apr 28 2015, 8:06 PM

• Mattflaschen-WMF subscribed.

Pginer-WMF mentioned this in T100828: Should VE toolbar float?.Jun 3 2015, 3:07 PM

Jdforrester-WMF closed subtask T96593: Be able to set placeholder text (generic content?) on an empty CE surface as Resolved.Jun 29 2015, 8:59 PM

Change 221777 had a related patch set uploaded (by Catrope):
Use placeholder support in VE once it becomes available

https://gerrit.wikimedia.org/r/221777

gerritbot added a project: Patch-For-Review.Jun 29 2015, 9:58 PM

Catrope claimed this task.Jun 29 2015, 9:59 PM

Catrope added a project: Collaboration-Team-Sprint-D-2015-06-30.

Catrope set Security to None.

Catrope moved this task from Sprint D - ends July 1 to Needs Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 29 2015, 10:01 PM

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 30 2015, 5:21 PM

Change 221777 merged by jenkins-bot:
Copy placeholders over to VE surfaces

https://gerrit.wikimedia.org/r/221777

Diffusion mentioned this in rMEXT18704b4de11a: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Jun 30 2015, 5:23 PM

Esanders mentioned this in rEFLWc734d1209cda: Copy placeholders over to VE surfaces.Jun 30 2015, 5:23 PM

• DannyH added a project: Collaboration-Team-Sprint-E-Everywhere-2015-07-14.Jun 30 2015, 7:39 PM

• DannyH moved this task from Sprint E - ends July 14 to QA Review on the Collaboration-Team-Sprint-E-Everywhere-2015-07-14 board.

https://phabricator.wikimedia.org/T97451 "Make source/wikitext icon consistent" is still Open.

Presently there is a difference between icons:

<a title="Switch to Wikitext editor" role="button" class="oo-ui-tool-link" aria-disabled="false" tabindex="0">
<span class="oo-ui-iconElement-icon oo-ui-icon-flow-switch-editor"></span><span class="oo-ui-tool-title">Switch to Wikitext editor</span>
<span dir="ltr" class="oo-ui-tool-accel" lang="en"></span></a></span>

vs

<a href="#" title="Switch to VisualEditor" class="mw-ui-button flow-js flow-editor-switcher mw-ui-checked" data-flow-interactive-handler="switchEditor" 
data-flow-target="< .flow-editor textarea.flow-editor-initialized">
				&lt;/&gt;
			</a>

Refer to 3.A on https://phabricator.wikimedia.org/T96421: Switch to wikitext mode.

It should be a regular pressed button. That is, look dark grey, not green. (T94877).

On the mock-up the pressed button looks darker - but currently there is:

mw-ui-button:active, .mw-ui-button.mw-ui-checked {

background: #CCC none repeat scroll 0% 0%;
box-shadow: none;

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jul 1 2015, 5:09 PM

• DannyH moved this task from QA Review to Product Review on the Collaboration-Team-Sprint-E-Everywhere-2015-07-14 board.Jul 1 2015, 5:38 PM

• DannyH closed this task as Resolved.Jul 2 2015, 4:37 PM

• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-E-Everywhere-2015-07-14 board.

Quiddity moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jul 29 2015, 11:57 PM

Flow edit area should have a placeholder when in VE mode
Closed, ResolvedPublic
Actions

Description

Details

Related Objects
Search...

Event Timeline

Flow edit area should have a placeholder when in VE modeClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Flow edit area should have a placeholder when in VE mode
Closed, ResolvedPublic
Actions

Related Objects
Search...