This seems to be a fairly new error, I don't remember seeing it before, and it's one of the top errors on fatalmonitor.
maybe related to T89169?
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | PRODUCTION ERROR | • Catrope | T99210 Cannot modify header information - headers already sent in /srv/mediawiki/hhvm-fatal-error.php on line 814 | ||
| Resolved | PRODUCTION ERROR | matmarex | T94900 Potentially unsafe "href" attribute value |
Event Timeline
Comment Actions
I don't think it is related to T89169. The hhvm-fatal-error.php script is 500 error handler for the HHVM fcgi process.
Comment Actions
I'm seeing it paired with the OOUI fatal:
2015-05-15T05:41:33.000Z mw1250 hhvm Fatal: Fatal error: exception 'OOUI\Exception' with message 'Potentially unsafe 'href' attribute value. Scheme: ''; value: '/wiki/%D8%AA%D8%B5%D9%86%D9%8A%D9%81:872'.' in /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Tag.php:317
Stack trace:
#0 /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Tag.php(359): OOUI\Tag->toString()
#1 /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Tag.php(337): OOUI\Tag->__toString()
#2 /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Element.php(274): OOUI\Tag->toString()
#3 /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Tag.php(359): OOUI\Element->toString()
#4 /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Tag.php(337): OOUI\Tag->__toString()
#5 /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Element.php(274): OOUI\Tag->toString()
#6 /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Tag.php(359): OOUI\Element->toString()
#7 /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Tag.php(337): OOUI\Tag->__toString()
#8 /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Element.php(274): OOUI\Tag->toString()
#9 /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Tag.php(359): OOUI\Element->toString()
#10 /srv/mediawiki/php-1.26wmf5/includes/OutputPage.php(1515): OOUI\Tag->__toString()
#11 /srv/mediawiki/php-1.26wmf5/extensions/Collection/Collection.body.php(380): OutputPage->addHTML()
#12 /srv/mediawiki/php-1.26wmf5/extensions/Collection/Collection.body.php(71): SpecialCollection->renderBookCreatorPage()
#13 /srv/mediawiki/php-1.26wmf5/includes/specialpage/SpecialPage.php(384): SpecialCollection->execute()
#14 /srv/mediawiki/php-1.26wmf5/includes/specialpage/SpecialPageFactory.php(582): SpecialPage->run()
#15 /srv/mediawiki/php-1.26wmf5/includes/MediaWiki.php(285): SpecialPageFactory::executePath()
#16 /srv/mediawiki/php-1.26wmf5/includes/MediaWiki.php(583): MediaWiki->performRequest()
#17 /srv/mediawiki/php-1.26wmf5/includes/MediaWiki.php(432): MediaWiki->main()
#18 /srv/mediawiki/php-1.26wmf5/index.php(46): MediaWiki->run()
#19 /srv/mediawiki/w/index.php(3): include()
#20 {main} in /srv/mediawiki/php-1.26wmf5/vendor/oojs/oojs-ui/php/Tag.php on line 361
2015-05-15T05:41:33.000Z mw1250 hhvm Warning: Warning: Cannot modify header information - headers already sent in /srv/mediawiki/hhvm-fatal-error.php on line 814Comment Actions
Pending deployment of | Avoid 'Potentially unsafe "href" attribute value' exceptions for relative URLs (T94900).
oojs/ui needs to be bumped.
Comment Actions
Fix for T94900 emergency deployed as https://gerrit.wikimedia.org/r/216005 since it apparently was a massive problem which no one mentioned before and and needed to be fixed immediately right now regardless of everything. Presumably this should be fixed now?
Comment Actions
Changed prio to unbreak now because apparently that's what it is. I'm about to deploy the oojs/ui update.
Comment Actions
Fix is deployed now. Going to the URLs mentioned in the error log doesn't cause exceptions any more, so I'm gonna call this fixed.
Comment Actions
Most of the Cannot modify header information - headers already sent came from T94900 which is now fixed. Not much more to do on this task and I can confirm there is way less such messages in logstash.