Page MenuHomePhabricator
Create Task
Maniphest T99258

For CSS and JS pages, the direction of #mw-content-text should only be forced to LTR if showing the page content, not history
Closed, ResolvedPublic
Actions

Description

Take a look at this page: https://fa.wikipedia.org/w/index.php?title=%D9%85%D8%AF%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Common.css&action=history

The content should be flowing from right to left (it is a history page) just like this example: https://fa.wikipedia.org/w/index.php?title=%D8%B1%DB%8C%D8%AD%D8%A7%D9%86&action=history

However, it flows from left to right. Having looked at the source code it appears the root cause is that the div #mw-content-text has a class mw-content-ltr and a dir attribute of ltr. These would make sense for the when the content of the page is viewed, but not for the history view.

Details

SubjectRepoBranchLines +/-
Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally"mediawiki/corewmf/1.26wmf5+9 -5
Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally"mediawiki/corewmf/1.26wmf6+9 -5
Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally"mediawiki/coremaster+9 -5
Customize query in gerrit

Related Objects

Event Timeline

Huji created this task.May 15 2015, 4:45 PM
Huji raised the priority of this task from to High.
Huji updated the task description. (Show Details)
Huji subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2015, 4:45 PM
greg added a project: MediaWiki-Internationalization.May 15 2015, 4:47 PM
greg set Security to None.
Catrope subscribed.May 15 2015, 4:53 PM

Probably a regression from https://gerrit.wikimedia.org/r/#/c/208282/

gerritbot subscribed.May 15 2015, 4:56 PM

Change 211138 had a related patch set uploaded (by Catrope):
Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally"

https://gerrit.wikimedia.org/r/211138

gerritbot added a project: Patch-For-Review.May 15 2015, 4:56 PM
Catrope added a comment.May 15 2015, 6:14 PM

I've figured out why this broke: my patch applied mw-content-{ltr,rtl} to every page view, including history, but MediaWiki:*.js pages always have LTR content, so we made their history pages LTR as well. That's obviously wrong, the history page should be in the UI directionality regardless of the page's content directionality.

gerritbot added a comment.May 15 2015, 6:45 PM

Change 211138 merged by jenkins-bot:
Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally"

https://gerrit.wikimedia.org/r/211138

Catrope mentioned this in rMW4d2932efd22c: Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally".May 15 2015, 6:46 PM
matmarex subscribed.May 17 2015, 9:11 PM
matmarex raised the priority of this task from High to Unbreak Now!.May 17 2015, 9:17 PM
matmarex mentioned this in T98583: wrong ltr direction for rtl wikis.

T98583 may or may not be the same issue. The fix for this should probably be backported on Monday. I'd submit it for SWAT but I'll be busy; @Catrope, can you do it?

gerritbot added a comment.May 18 2015, 10:02 PM

Change 211893 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally"

https://gerrit.wikimedia.org/r/211893

gerritbot added a comment.May 18 2015, 10:03 PM

Change 211894 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally"

https://gerrit.wikimedia.org/r/211894

gerritbot added a comment.May 19 2015, 3:27 PM

Change 211894 merged by jenkins-bot:
Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally"

https://gerrit.wikimedia.org/r/211894

Anomie mentioned this in rMW3132cb69c8f8: Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally".May 19 2015, 3:27 PM
gerritbot added a comment.May 19 2015, 3:30 PM

Change 211893 merged by jenkins-bot:
Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally"

https://gerrit.wikimedia.org/r/211893

Anomie mentioned this in rMW427fe9f7a750: Revert "Follow-up ee320648fd1: output mw-content-{ltr,rtl} unconditionally".May 19 2015, 3:30 PM
matmarex added subscribers: Ebrahim, Ladsgroup.May 19 2015, 3:39 PM

Resolved and deployed. The fix might take a while to kick in for anonymous users, since they are viewing cached pages. Sorry it took so long. The local hacks mentioned in T98583#1292249 can be removed now. (@Ebraminio, @Ladsgroup, can you do it?)

matmarex closed this task as Resolved.May 19 2015, 3:39 PM
matmarex removed a project: Patch-For-Review.
matmarex merged a task: T98583: wrong ltr direction for rtl wikis.
matmarex added a subscriber: Yamaha5.
Ebrahim added a comment.May 19 2015, 5:08 PM

Looks great. Done. Thank you.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptSep 24 2017, 11:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL