Thanks for the help @Jdlrobson, Tell if this commit is ok ?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Today
Fri, Jul 5
ok @Chrissy_Codes, fell free to ask for help, if you get stuck in any issue.
ok @Pppery
@NewtonKamau you still working on this ?
@Ssm.allrounder are you still working on this Task, if not I would like work on it.
@Pppery I happy to claim this task, if @Chrissy_Codes is haing some issues.
Thu, Jul 4
I have increased the form - width to 400px,
I am tring to solve this issue and have changed @color-inverted to @color-inverted-fixed, as it has beed asked https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/MobileFrontend/+/refs/heads/master/resources/mobile.mediaViewer/ImageCarousel.less#86
Wed, Jul 3
In T368809#9951891, @Pppery wrote:"Bug:" needs to be immediately before "Change-Id:" in the commit message. See https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Phabricator
See also https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_(your_own_or_someone_else's) on how to amend changes within one patchset rather than uploading a new one for every subsequent change
In T368809#9951759, @Pppery wrote:Note that this was done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1051832, whose commit message was formatted in a way that didn't cause Gerritbot to see it. Someone should abandon https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1051337 as a duplicate.
Congrats on your first merged Gerrit patch!
Tue, Jul 2
I am new to this, apologies for any mistake. If somebody can look into, this. I think its not assigned for review to the proper maintainers. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/LiquidThreads/+/1051362